https://bugzilla.redhat.com/show_bug.cgi?id=2272354

Peter Robinson pbrobinson@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value Blocks| |2272352

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=2272352 [Bug 2272352] parsec-tool-0.7.0 is available

https://bugzilla.redhat.com/show_bug.cgi?id=2272354

Peter Robinson pbrobinson@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Comment|0 |updated

--- Comment #0 has been edited ---

SPEC: https://pbrobinson.fedorapeople.org/rust-yasna.spec SRPM: https://pbrobinson.fedorapeople.org/rust-yasna-0.5.2-1.fc39.src.rpm

Description: Generic session middleware for the warp HTTP framework

FAS: pbrobinson

koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=115678137

https://bugzilla.redhat.com/show_bug.cgi?id=2272354

--- Comment #2 from Peter Robinson pbrobinson@gmail.com --- (In reply to Fabio Valentini from comment #1)

1. unaddressed FIXME:

...

# FIXME: no license files detected

This needs to be addressed in one way or another, I see you already filed an issue - thanks! https://github.com/qnighy/yasna.rs/issues/76

Ideally, upstream should be asked to include "LICENSE-*" files here: https://github.com/qnighy/yasna.rs/blob/master/Cargo.toml#L14-L17

And publish new versions. Can you submit a PR for this?

It's on my backlog but I don't see upstream fix should block it, yes I'll update locally to add the LICENSE file.

Until that is fixed upstream, you will need to include the license files from https://github.com/qnighy/yasna.rs manually as separate source files.

2. Why do tests fail on 32-bit x86? Is this a real problem in the code or

problems with the tests?

TBH I don't have time to look into it and I don't personally care about 32 bit

Not sure if this addresses *all* failures on i686, but it would be great if that commit could be included as a patch and the tests enabled unconditionally.

I would generally just err on disabling 32 bit in general, can you explain why it matters?

https://bugzilla.redhat.com/show_bug.cgi?id=2272354

--- Comment #4 from Fabio Valentini decathorpe@gmail.com --- Sorry for the delay.

I just checked, and the patch that was proposed by debian packagers indeed fixes the test failures. Can you include it make tests run unconditionally?

Ideally, the license files would also come from upstream URLs instead of being plain files, to indicate that they are, indeed, from upstream.

Something like this should do it:

""" Source1: https://github.com/qnighy/yasna.rs/raw/yasna-0.5.0/LICENSE-APACHE Source2: https://github.com/qnighy/yasna.rs/raw/yasna-0.5.0/LICENSE-MIT

# backport upstream patch to fix test failures on 32-bit architectures Patch: https://github.com/qnighy/yasna.rs/commit/bf5afbe.patch """

https://bugzilla.redhat.com/show_bug.cgi?id=2272354

--- Comment #6 from Peter Robinson pbrobinson@gmail.com --- (In reply to Fabio Valentini from comment #5)

Are you still interested in getting this crate packaged?

Yes, need it for the newer parsec-tool

https://bugzilla.redhat.com/show_bug.cgi?id=2272354

Davide Cavalca davide@cavalca.name changed:

What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2296139

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=2296139 [Bug 2296139] Review Request: rust-p12 - Pure rust pkcs12 tool

https://bugzilla.redhat.com/show_bug.cgi?id=2272354

Fabio Valentini decathorpe@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|ASSIGNED |CLOSED Last Closed| |2024-09-12 20:55:25

--- Comment #9 from Fabio Valentini decathorpe@gmail.com ---

*** This bug has been marked as a duplicate of bug 2312030 ***