[Bug 537431] New: Review Request: mono-bouncycastle - Bouncy Castle Crypto Package for Mono
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: mono-bouncycastle - Bouncy Castle Crypto Package for Mono
https://bugzilla.redhat.com/show_bug.cgi?id=537431
Summary: Review Request: mono-bouncycastle - Bouncy Castle Crypto Package for Mono Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: kalev@smartlink.ee QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://kalev.fedorapeople.org/mono-bouncycastle.spec SRPM URL: http://kalev.fedorapeople.org/mono-bouncycastle-1.5-1.fc12.src.rpm Description: The Bouncy Castle Crypto package is a C# implementation of cryptographic algorithms. It is a port of the Bouncy Castle Java APIs, with approximately 80% of the functionality ported. The C# API is constantly kept uptodate with bug fixes and new test cases from the Java build (and vice versa sometimes), thus benefitting from the large user base and real-world use the Java version has seen.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=537431
Kalev Lember kalev@smartlink.ee changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |langel@redhat.com Alias| |mono-bouncycastle
--- Comment #1 from Kalev Lember kalev@smartlink.ee 2009-11-13 11:09:40 EDT --- About naming: There is already bouncycastle Java package [1] in Fedora, which is why I used "bouncycastle" as part of the name. Another option would have been "bccrypto" (from upstream zip file name). There doesn't seem to be any official guidelines about Mono package names, so I chose to prefix it with mono-, resulting in mono-bouncycastle.
I'm CC-ing the Java package maintainer in case he has some suggestions about naming / packaging of this library.
[1] https://admin.fedoraproject.org/pkgdb/packages/name/bouncycastle
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=537431
Kalev Lember kalev@smartlink.ee changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |537437(itextsharp)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=537431
--- Comment #2 from Kalev Lember kalev@smartlink.ee 2009-11-29 07:32:06 EDT --- Scratch build (for F-12, since nant in rawhide is currently broken wrt bug 538908): http://koji.fedoraproject.org/koji/taskinfo?taskID=1836123
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=537431
--- Comment #3 from Kalev Lember kalev@smartlink.ee 2009-12-01 16:46:18 EDT --- * Tue Dec 01 2009 Kalev Lember kalev@smartlink.ee - 1.5-2 - Use the system mono.snk key instead of regenerating on every build
Spec URL: http://kalev.fedorapeople.org/mono-bouncycastle.spec SRPM URL: http://kalev.fedorapeople.org/mono-bouncycastle-1.5-2.fc13.src.rpm
Scratch build for rawhide now that nant is working again: http://koji.fedoraproject.org/koji/taskinfo?taskID=1842242
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=537431
--- Comment #4 from Kalev Lember kalev@smartlink.ee 2009-12-02 06:27:13 EDT --- * Wed Dec 02 2009 Kalev Lember kalev@smartlink.ee - 1.5-3 - Temporarily bundle mono.snk with this package to fix build on < F-13
Spec URL: http://kalev.fedorapeople.org/mono-bouncycastle.spec SRPM URL: http://kalev.fedorapeople.org/mono-bouncycastle-1.5-3.fc13.src.rpm Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1843092
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=537431
Thomas Janssen thomasj@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |thomasj@fedoraproject.org AssignedTo|nobody@fedoraproject.org |thomasj@fedoraproject.org Flag| |fedora-review?
--- Comment #5 from Thomas Janssen thomasj@fedoraproject.org 2009-12-02 14:03:04 EDT --- + rpmlint is fine for a mono package. The permission is needed to run the script.
rpmlint rpmbuild/RPMS/x86_64/mono-bouncycastle-1.5-3.fc11.x86_64.rpm srpm-review-test/mono-bouncycastle-1.5-3.fc13.src.rpm mono-bouncycastle.x86_64: E: no-binary mono-bouncycastle.x86_64: W: only-non-binary-in-usr-lib mono-bouncycastle.src: W: strange-permission bccrypto-generate-zip.sh 0755 2 packages and 0 specfiles checked; 1 errors, 2 warnings.
+ The package must be named according to the Package Naming Guidelines . + The spec file match the base package %{name}, in the format %{name}.spec unless your package has an exemption. + The package meets the Packaging Guidelines. + The package must be licensed with a Fedora approved license and meet the Licensing Guidelines . ! The License field in the package spec file must match the actual license.
Part of the source states: Apache Software License 1.1 (ASL 1.1) The Webpage says: MIT X11
Change the license to: MIT with ASL 1.1
+ The spec file is written in American English. + The spec file is legible. + The sources used to build the package must match the upstream source, as provided in the spec URL. md5 d400421918c0c20f2f53fa003e25eb11
+ It compiles + ExcludeArch done. + BuildRequires listed. + Packages must NOT bundle copies of system libraries. + Package owns all directories that it creates. + Permissions are set properly. + %clean section + Macros usage + The package must contain code, or permissable content. + %doc handling + At the beginning of %install, each package MUST run rm -rf %{buildroot} (or $RPM_BUILD_ROOT).
Package will be approved after you corrected the license field.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=537431
--- Comment #6 from Kalev Lember kalev@smartlink.ee 2009-12-02 14:41:27 EDT --- Thanks for the review, Thomas!
My main reason for packaging bouncycastle was to get iTextSharp [1] included in Fedora. However, ASL 1.1 would make those two libraries incompatible. I sent a mail [2] to bouncycastle csharp development mailing list, asking if it would be possible to relicense the ASL 1.1 bits under ASL 2.0 instead.
Anyway, this doesn't prevent from completing mono-bouncycastle review. According to Licensing Guidelines [3], separator between multiple licenses should be 'and', so I changed the License tag to read 'MIT and ASL 1.1'.
Spec URL: http://kalev.fedorapeople.org/mono-bouncycastle.spec SRPM URL: http://kalev.fedorapeople.org/mono-bouncycastle-1.5-4.fc13.src.rpm
[1] https://bugzilla.redhat.com/show_bug.cgi?id=537437 [2] http://www.bouncycastle.org/csharpdevmailarchive/msg00370.html [3] http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#Multiple_Licensi...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=537431
Thomas Janssen thomasj@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #7 from Thomas Janssen thomasj@fedoraproject.org 2009-12-02 15:12:10 EDT --- *Approved*
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=537431
Kalev Lember kalev@smartlink.ee changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #8 from Kalev Lember kalev@smartlink.ee 2009-12-02 15:43:25 EDT --- New Package CVS Request ======================= Package Name: mono-bouncycastle Short Description: Bouncy Castle Crypto Package for Mono Owners: kalev Branches: F-11 F-12 InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=537431
Kevin Fenzi kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
--- Comment #9 from Kevin Fenzi kevin@tummy.com 2009-12-03 01:39:30 EDT --- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=537431
--- Comment #10 from Fedora Update System updates@fedoraproject.org 2009-12-03 04:49:35 EDT --- mono-bouncycastle-1.5-4.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/mono-bouncycastle-1.5-4.fc12
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=537431
--- Comment #11 from Fedora Update System updates@fedoraproject.org 2009-12-03 04:50:22 EDT --- mono-bouncycastle-1.5-4.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/mono-bouncycastle-1.5-4.fc11
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=537431
--- Comment #12 from Fedora Update System updates@fedoraproject.org 2009-12-04 18:37:39 EDT --- mono-bouncycastle-1.5-4.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=537431
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Fixed In Version| |1.5-4.fc11 Resolution| |ERRATA
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=537431
--- Comment #13 from Fedora Update System updates@fedoraproject.org 2009-12-04 18:54:45 EDT --- mono-bouncycastle-1.5-4.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=537431
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|1.5-4.fc11 |1.5-4.fc12
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla