https://bugzilla.redhat.com/show_bug.cgi?id=2299655

Dorinda dbassey@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |dbassey@redhat.com

--- Comment #1 from Dorinda dbassey@redhat.com --- Spec file LGTM I tried a local build and it builds correctly.

I can't do an official review yet since this Package is dependent on virtio-vsock which is still in the process of being packaged, `Problem: nothing provides requested (crate(virtio-vsock/default) >= 0.6.0 with crate(virtio-vsock/default) < 0.7.0~) `

https://bugzilla.redhat.com/show_bug.cgi?id=2299655

--- Comment #3 from Sandro Bonazzola sbonazzo@redhat.com --- (In reply to Dorinda from comment #2)

I just noticed that it's missing a man page. it might be worth considering adding a patch on the man page and opening an issues about it upstream.

Opened a PR there: https://github.com/rust-vmm/vhost-device/pull/698 I will add the same patch in the rpm once approved upstream.

https://bugzilla.redhat.com/show_bug.cgi?id=2299655

--- Comment #5 from Sandro Bonazzola sbonazzo@redhat.com --- PR got accepted, pushing an update

https://bugzilla.redhat.com/show_bug.cgi?id=2299655

--- Comment #7 from Sandro Bonazzola sbonazzo@redhat.com --- Note for reviewers about:

[ ]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/doc, /usr/share/man, /usr/src/debug, /usr, /usr/src, /usr/share, /usr/lib, /usr/bin, /usr/share/licenses [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/doc, /usr/share/man, /usr/lib, /usr/src/debug, /usr, /usr/src, /usr/share, /usr/bin, /usr/share/licenses

In this case it's a false positive as `repoquery --requires vhost-device-vsock-0.2.0-1.fc41.x86_64.rpm --tree` shows:

``` vhost-device-vsock-0:0.2.0-1.fc41.x86_64 _ glibc-0:2.39.9000-35.fc41.x86_64 [5: basesystem, libgcc(x86-64), glibc-common = 2.39.9000-35.fc41, glibc-langpack = 2.39.9000-35.fc41, (glibc-gconv-extra(x86-64) = 2.39.9000-35.fc41 if redhat-rpm-config)] | _ basesystem-0:11-21.fc41.noarch [2: filesystem, setup] | | _ filesystem-0:3.18-23.fc41.x86_64 [1: setup] ... ```

and filesystem package owns above listed directories. I think there's a bug in how debug packages are generated as vhost-device-vsock-debuginfo and rust-vhost-device-vsock-debugsource have no requirements at all and I think they should at least require filesystem package. I'll file bug report for both the issues.

https://bugzilla.redhat.com/show_bug.cgi?id=2299655

--- Comment #9 from Sandro Bonazzola sbonazzo@redhat.com --- Pushed a fix for the false positive stuff here: https://pagure.io/FedoraReview/pull-request/521 Running it with the fix detected an issue with the man1 directory ownership, fixing.

https://bugzilla.redhat.com/show_bug.cgi?id=2299655

Fabio Valentini decathorpe@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST Flags| |fedora-review+ Assignee|nobody@fedoraproject.org |decathorpe@gmail.com CC| |decathorpe@gmail.com

--- Comment #11 from Fabio Valentini decathorpe@gmail.com --- Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ licenses of statically linked dependencies are correctly taken into account ✅ license files are included with %license in %files ✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer)

https://bugzilla.redhat.com/show_bug.cgi?id=2299655

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|RELEASE_PENDING |MODIFIED

--- Comment #13 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-1fd1123596 (rust-vhost-device-vsock-0.2.0-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-1fd1123596

https://bugzilla.redhat.com/show_bug.cgi?id=2299655 Bug 2299655 depends on bug 2299173, which changed state.

Bug 2299173 Summary: Review Request: rust-virtio-vsock - Virtio vsock device implementation https://bugzilla.redhat.com/show_bug.cgi?id=2299173

What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA