https://bugzilla.redhat.com/show_bug.cgi?id=2103477
Fabio Valentini <decathorpe(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |POST
Assignee|nobody(a)fedoraproject.org |decathorpe(a)gmail.com
Flags| |fedora-review+
--- Comment #6 from Fabio Valentini <decathorpe(a)gmail.com> ---
Package was generated with rust2rpm, simplifying the review.
- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines
Package APPROVED.
===
Recommended post-import rust-sig tasks:
- add @rust-sig with "commit" access as package co-maintainer
- set bugzilla assignee overrides to @rust-sig (optional)
- set up package on
release-monitoring.org:
project: $crate
homepage:
https://crates.io/crates/$crate
backend: crates.io
version scheme: semantic
version filter: alpha;beta;rc;pre
distro: Fedora
Package: rust-$crate
- track package in koschei for all built branches
===
Two minor issues / warnings:
- If you're patching the print_bytes dependency, either bump it to plain
"0.6"
(which is what you have packaged),
or, if you want to stay compatible with what upstream does, use
">=0.4,<0.7"
instead.
Using open-ended ">=0.4" is slightly dangerous, because it is compatible
with
*any* version higher than 0.4,
which is probably not what you want (and which will also lead to very
confusing error messages if the print_bytes crate ever changes its APIs).
- Make sure that you import the correct files into dist-git.
The linked SRPM is already mangled by rpmautospec for some reason.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2103477