https://bugzilla.redhat.com/show_bug.cgi?id=2009155
Bug ID: 2009155 Summary: python-oslo-messaging - OpenStack common messaging library Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: hiwkby@yahoo.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://hiwkby.fedorapeople.org/python-oslo-messaging.spec SRPM URL: https://hiwkby.fedorapeople.org/python-oslo-messaging-12.9.1-1.fc36.src.rpm Description: The Oslo project intends to produce a python library containing infrastructure code shared by OpenStack projects. The APIs provided by the project should be high quality, stable, consistent and generally useful.
The Oslo messaging API supports RPC and notifications over a number of different messaging transports. Fedora Account System Username: hiwkby
This package retired two years ago but the former packager says feel free to take it. I will take this and update to 12.9.1. https://src.fedoraproject.org/rpms/python-oslo-messaging https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/...
https://bugzilla.redhat.com/show_bug.cgi?id=2009155
Hirotaka Wakabayashi hiwkby@yahoo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value Summary|python-oslo-messaging - |Review Request: |OpenStack common messaging |python-oslo-messaging - |library |OpenStack common messaging | |library Blocks| |2009146, 1992629, 1991145
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1991145 [Bug 1991145] Review Request: python-oslo-service - Oslo service library https://bugzilla.redhat.com/show_bug.cgi?id=1992629 [Bug 1992629] Review Request: python-oslo-middleware - OpenStack Oslo Middleware library https://bugzilla.redhat.com/show_bug.cgi?id=2009146 [Bug 2009146] Review Request: python-oslo-metrics - OpenStack Oslo Metrics library
https://bugzilla.redhat.com/show_bug.cgi?id=2009155
Mattia Verga mattia.verga@proton.me changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1663668
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1663668 [Bug 1663668] Review Request: python-k2hr3-osnl - K2hR3 OpenStack Notification Listener
https://bugzilla.redhat.com/show_bug.cgi?id=2009155
--- Comment #1 from Hirotaka Wakabayashi hiwkby@yahoo.com --- Hello, I updated the version to 14.0.0.
Spec URL: https://hiwkby.fedorapeople.org/python-oslo-messaging.spec SRPM URL: https://hiwkby.fedorapeople.org/python-oslo-messaging-14.0.0-1.fc38.src.rpm Koji(success!): https://koji.fedoraproject.org/koji/taskinfo?taskID=93461252
https://bugzilla.redhat.com/show_bug.cgi?id=2009155
Jakub Kadlčík jkadlcik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jkadlcik@redhat.com
--- Comment #2 from Jakub Kadlčík jkadlcik@redhat.com --- Hello Hirotaka, thank you for the package.
Koji(success!): https://koji.fedoraproject.org/koji/taskinfo?taskID=93461252
Not a success :D
No matching package to install: 'python3-oslo-metrics' No matching package to install: 'python3-oslo-middleware' No matching package to install: 'python3-oslo-service'
The python3-oslo-middleware is being done in RHBZ 1992629 but I can't find tickets for the remaining two. If you will be adding them yourself, feel free to ping me and I will prioritize their review.
https://bugzilla.redhat.com/show_bug.cgi?id=2009155
--- Comment #3 from Hirotaka Wakabayashi hiwkby@yahoo.com --- Hi Jakub! Thanks a lot for your feedback! I filed the remaining two packages and fixed the issues on them. I would truly appreciate it if you would kindly check them too!
* python-oslo-metrics https://bugzilla.redhat.com/show_bug.cgi?id=2009146#c3 * python-oslo-service https://bugzilla.redhat.com/show_bug.cgi?id=1991145#c3
I also fixed the issues on python-oslo-middleware.
* python-oslo-middleware https://bugzilla.redhat.com/show_bug.cgi?id=1992629#c7
Not a success :D
I am sorry that I missed the failure...orz I updated the python-oslo-messaging.spec. However koji build is still unsuccessful because of the package dependencies.
Spec URL: https://hiwkby.fedorapeople.org/python-oslo-messaging.spec SRPM URL: https://hiwkby.fedorapeople.org/python-oslo-messaging-14.0.0-2.fc38.src.rpm Koji(unsuccess...orz): https://koji.fedoraproject.org/koji/taskinfo?taskID=93644843
``` $ diff -c public_html/python-oslo-messaging.spec python-oslo-messaging.spec *** public_html/python-oslo-messaging.spec 2022-10-26 10:15:08.634392166 +0000 --- python-oslo-messaging.spec 2022-11-01 00:04:05.652081505 +0000 *************** *** 12,30 **** by the project should be high quality, stable, consistent and generally \ useful.
- %global common_desc1 \ - Tests for the OpenStack common messaging library. - %global pypi_name oslo.messaging %global pkg_name oslo-messaging
Name: python-oslo-messaging Version: 14.0.0 ! Release: 1%{?dist} Summary: OpenStack common messaging library
License: ASL 2.0 ! URL: https://launchpad.net/oslo Source0: https://tarballs.openstack.org/%%7Bpypi_name%7D/%%7Bpypi_name%7D-%%7Bupstrea... # Required for tarball sources verification %if 0%{?sources_gpg} == 1 --- 12,27 ---- by the project should be high quality, stable, consistent and generally \ useful.
%global pypi_name oslo.messaging %global pkg_name oslo-messaging
Name: python-oslo-messaging Version: 14.0.0 ! Release: 2%{?dist} Summary: OpenStack common messaging library
License: ASL 2.0 ! URL: https://opendev.org/openstack/oslo.messaging Source0: https://tarballs.openstack.org/%%7Bpypi_name%7D/%%7Bpypi_name%7D-%%7Bupstrea... # Required for tarball sources verification %if 0%{?sources_gpg} == 1 *************** *** 52,58 **** BuildRequires: python3-fixtures BuildRequires: python3-hacking BuildRequires: python3-kombu >= 1:4.6.6 - BuildRequires: python3-mock BuildRequires: python3-oslo-config BuildRequires: python3-oslo-metrics BuildRequires: python3-oslo-middleware --- 49,54 ---- *************** *** 139,145 **** BuildRequires: python3-kafka
%description -n python3-%{pkg_name}-tests ! %{common_desc1}
%description %{common_desc} --- 135,141 ---- BuildRequires: python3-kafka
%description -n python3-%{pkg_name}-tests ! Tests for the OpenStack common messaging library.
%description %{common_desc} *************** *** 193,198 **** --- 189,197 ----
%changelog + * Tue Nov 01 2022 Hirotaka Wakabayashi hiwkby@yahoo.com - 14.0.0-2 + - Fixes issues on the packaging guidelines + * Wed Oct 26 2022 Hirotaka Wakabayashi hiwkby@yahoo.com - 14.0.0-1 - Update to 14.0.0
```
Thanks in advance, Hirotaka
https://bugzilla.redhat.com/show_bug.cgi?id=2009155
--- Comment #4 from Hirotaka Wakabayashi hiwkby@yahoo.com --- Hello, I fixed the issue on the packaging guidelines
Spec URL: https://hiwkby.fedorapeople.org/python-oslo-messaging.spec SRPM URL: https://hiwkby.fedorapeople.org/python-oslo-messaging-14.0.0-3.fc38.src.rpm Koji(unsuccess...orz): https://koji.fedoraproject.org/koji/taskinfo?taskID=93926697
``` $ diff -c public_html/python-oslo-messaging.spec python-oslo-messaging.spec *** public_html/python-oslo-messaging.spec 2022-11-01 00:25:44.540360201 +0000 --- python-oslo-messaging.spec 2022-11-08 02:11:07.003786314 +0000 *************** *** 17,23 ****
Name: python-oslo-messaging Version: 14.0.0 ! Release: 2%{?dist} Summary: OpenStack common messaging library
License: ASL 2.0 --- 17,23 ----
Name: python-oslo-messaging Version: 14.0.0 ! Release: 3%{?dist} Summary: OpenStack common messaging library
License: ASL 2.0 *************** *** 39,45 ****
%package -n python3-%{pkg_name} Summary: OpenStack common messaging library ! %{?python_provide:%python_provide python3-%{pkg_name}}
BuildRequires: python3-devel BuildRequires: python3-setuptools --- 39,45 ----
%package -n python3-%{pkg_name} Summary: OpenStack common messaging library ! %py_provides python3-pkg_resources
BuildRequires: python3-devel BuildRequires: python3-setuptools *************** *** 189,194 **** --- 189,197 ----
%changelog + * Tue Nov 08 2022 Hirotaka Wakabayashi hiwkby@yahoo.com - 14.0.0-3 + - Fixes issues on the packaging guidelines + * Tue Nov 01 2022 Hirotaka Wakabayashi hiwkby@yahoo.com - 14.0.0-2 - Fixes issues on the packaging guidelines
```
``` $ sudo dnf install -y ~/dev/packages/RPMS/noarch/python3-oslo-messaging-14.0.0-3.fc38.noarch.rpm $ rpm -q --whatprovides python3-oslo-messaging python3-oslo-messaging-14.0.0-3.fc38.noarch ```
https://bugzilla.redhat.com/show_bug.cgi?id=2009155
--- Comment #5 from Hirotaka Wakabayashi hiwkby@yahoo.com --- Sorry, I fixed an issue on the guidelines again because I read the old guidelines and made a mistake...orz
Spec URL: https://hiwkby.fedorapeople.org/python-oslo-messaging.spec SRPM URL: https://hiwkby.fedorapeople.org/python-oslo-messaging-14.0.0-4.fc38.src.rpm Koji(unsuccess...orz): https://koji.fedoraproject.org/koji/taskinfo?taskID=93962680
``` $ diff -c public_html/python-oslo-messaging.spec python-oslo-messaging.spec *** public_html/python-oslo-messaging.spec 2022-11-08 02:11:07.003786314 +0000 --- python-oslo-messaging.spec 2022-11-09 02:40:02.835283149 +0000 *************** *** 17,23 ****
Name: python-oslo-messaging Version: 14.0.0 ! Release: 3%{?dist} Summary: OpenStack common messaging library
License: ASL 2.0 --- 17,23 ----
Name: python-oslo-messaging Version: 14.0.0 ! Release: 4%{?dist} Summary: OpenStack common messaging library
License: ASL 2.0 *************** *** 39,45 ****
%package -n python3-%{pkg_name} Summary: OpenStack common messaging library ! %py_provides python3-pkg_resources
BuildRequires: python3-devel BuildRequires: python3-setuptools --- 39,45 ----
%package -n python3-%{pkg_name} Summary: OpenStack common messaging library ! %py_provides python3-%{pkg_name}
BuildRequires: python3-devel BuildRequires: python3-setuptools *************** *** 189,194 **** --- 189,197 ----
%changelog + * Wed Nov 09 2022 Hirotaka Wakabayashi hiwkby@yahoo.com - 14.0.0-4 + - Fixes issues on the packaging guidelines + * Tue Nov 08 2022 Hirotaka Wakabayashi hiwkby@yahoo.com - 14.0.0-3 - Fixes issues on the packaging guidelines ```
``` $ rpmspec -P python-oslo-messaging.spec | grep -B 3 Provides
%package -n python3-oslo-messaging Summary: OpenStack common messaging library Provides: python3-oslo-messaging = 14.0.0-4.fc38 Provides: python3.11-oslo-messaging = 14.0.0-4.fc38 Provides: python-oslo-messaging = 14.0.0-4.fc38
$ sudo dnf install -y ~/dev/packages/RPMS/noarch/python3-oslo-messaging-14.0.0-4.fc38.noarch.rpm $ rpm -q --whatprovides python3-oslo-messaging python3-oslo-messaging-14.0.0-4.fc38.noarch
```
https://bugzilla.redhat.com/show_bug.cgi?id=2009155
--- Comment #6 from Hirotaka Wakabayashi hiwkby@yahoo.com --- Hello, I fixed another issue.
Spec URL: https://hiwkby.fedorapeople.org/python-oslo-messaging.spec SRPM URL: https://hiwkby.fedorapeople.org/python-oslo-messaging-14.0.0-5.fc38.src.rpm Koji(unsuccess...orz): https://koji.fedoraproject.org/koji/taskinfo?taskID=94227860
``` $ diff -c public_html/python-oslo-messaging.spec python-oslo-messaging.spec *** public_html/python-oslo-messaging.spec 2022-11-09 02:40:02.835283149 +0000 --- python-oslo-messaging.spec 2022-11-16 03:46:52.397596333 +0000 *************** *** 17,23 ****
Name: python-oslo-messaging Version: 14.0.0 ! Release: 4%{?dist} Summary: OpenStack common messaging library
License: ASL 2.0 --- 17,23 ----
Name: python-oslo-messaging Version: 14.0.0 ! Release: 5%{?dist} Summary: OpenStack common messaging library
License: ASL 2.0 *************** *** 173,179 **** %license LICENSE %doc README.rst %{python3_sitelib}/oslo_messaging ! %{python3_sitelib}/*.egg-info %{_bindir}/oslo-messaging-send-notification %{_bindir}/oslo-messaging-send-notification-3 %exclude %{python3_sitelib}/oslo_messaging/tests --- 173,179 ---- %license LICENSE %doc README.rst %{python3_sitelib}/oslo_messaging ! %{python3_sitelib}/%{pypi_name}-%{version}-py%{python3_version}.egg-info %{_bindir}/oslo-messaging-send-notification %{_bindir}/oslo-messaging-send-notification-3 %exclude %{python3_sitelib}/oslo_messaging/tests *************** *** 189,194 **** --- 189,197 ----
%changelog + * Wed Nov 16 2022 Hirotaka Wakabayashi hiwkby@yahoo.com - 14.0.0-5 + - Fixes issues on the packaging guidelines + * Wed Nov 09 2022 Hirotaka Wakabayashi hiwkby@yahoo.com - 14.0.0-4 - Fixes issues on the packaging guidelines
```
https://bugzilla.redhat.com/show_bug.cgi?id=2009155
--- Comment #7 from Hirotaka Wakabayashi hiwkby@yahoo.com --- Hello, I fixed another issue.
Spec URL: https://hiwkby.fedorapeople.org/python-oslo-messaging.spec SRPM URL: https://hiwkby.fedorapeople.org/python-oslo-messaging-14.0.0-6.fc38.src.rpm Koji(unsuccess...orz): https://koji.fedoraproject.org/koji/taskinfo?taskID=95115668
The reason for unsuccess is due to a dependent package is still unavailable but the package will be available soon. Please see: https://bugzilla.redhat.com/show_bug.cgi?id=1991145
``` *** python-oslo-messaging.spec.14.0.0-5 2022-12-09 05:44:25.988831648 +0000 --- python-oslo-messaging.spec 2022-12-09 05:45:20.223081852 +0000 *************** *** 17,23 ****
Name: python-oslo-messaging Version: 14.0.0 ! Release: 5%{?dist} Summary: OpenStack common messaging library
License: ASL 2.0 --- 17,23 ----
Name: python-oslo-messaging Version: 14.0.0 ! Release: 6%{?dist} Summary: OpenStack common messaging library
License: ASL 2.0 *************** *** 62,68 **** BuildRequires: python3-cachetools BuildRequires: python3-redis BuildRequires: python3-kafka !
Requires: python3-pbr Requires: python3-amqp >= 2.5.2 --- 62,70 ---- BuildRequires: python3-cachetools BuildRequires: python3-redis BuildRequires: python3-kafka ! BuildRequires: python3-testscenarios ! BuildRequires: python3-pifpaf ! BuildRequires: python3-confluent-kafka
Requires: python3-pbr Requires: python3-amqp >= 2.5.2 *************** *** 189,210 ****
%changelog ! * Wed Nov 16 2022 Hirotaka Wakabayashi hiwkby@yahoo.com - 14.0.0-5 - Fixes issues on the packaging guidelines
! * Wed Nov 09 2022 Hirotaka Wakabayashi hiwkby@yahoo.com - 14.0.0-4 - Fixes issues on the packaging guidelines
! * Tue Nov 08 2022 Hirotaka Wakabayashi hiwkby@yahoo.com - 14.0.0-3 - Fixes issues on the packaging guidelines
! * Tue Nov 01 2022 Hirotaka Wakabayashi hiwkby@yahoo.com - 14.0.0-2 - Fixes issues on the packaging guidelines
! * Wed Oct 26 2022 Hirotaka Wakabayashi hiwkby@yahoo.com - 14.0.0-1 - Update to 14.0.0
! * Thu Sep 30 2021 Hirotaka Wakabayashi hiwkby@yahoo.com - 12.9.1-1 - Un-retired and update to 12.9.1
* Tue Feb 26 2019 Alfredo Moralejo amoralej@redhat.com - 8.1.2-1 --- 191,216 ----
%changelog ! * Fri Dec 09 2022 Hirotaka Wakabayashi hiwkby@yahoo.com - 14.0.0-6 ! - Adds BuildRequires for tests ! - Fixes issues on the packaging guidelines ! ! * Wed Nov 16 2022 Hirotaka Wakabayashi hiwkby@yahoo.com - 14.0.0-5 - Fixes issues on the packaging guidelines
! * Wed Nov 09 2022 Hirotaka Wakabayashi hiwkby@yahoo.com - 14.0.0-4 - Fixes issues on the packaging guidelines
! * Tue Nov 08 2022 Hirotaka Wakabayashi hiwkby@yahoo.com - 14.0.0-3 - Fixes issues on the packaging guidelines
! * Tue Nov 01 2022 Hirotaka Wakabayashi hiwkby@yahoo.com - 14.0.0-2 - Fixes issues on the packaging guidelines
! * Wed Oct 26 2022 Hirotaka Wakabayashi hiwkby@yahoo.com - 14.0.0-1 - Update to 14.0.0
! * Thu Sep 30 2021 Hirotaka Wakabayashi hiwkby@yahoo.com - 12.9.1-1 - Un-retired and update to 12.9.1
* Tue Feb 26 2019 Alfredo Moralejo amoralej@redhat.com - 8.1.2-1 ```
Thanks in advance, Hirotaka
https://bugzilla.redhat.com/show_bug.cgi?id=2009155
--- Comment #8 from Hirotaka Wakabayashi hiwkby@yahoo.com ---
The reason for unsuccess is due to a dependent package is still unavailable but the package will be available soon. Please see: https://bugzilla.redhat.com/show_bug.cgi?id=1991145
Koji(success!) https://koji.fedoraproject.org/koji/taskinfo?taskID=95330465
https://bugzilla.redhat.com/show_bug.cgi?id=2009155
--- Comment #10 from Jakub Kadlčík jkadlcik@redhat.com --- Hello Hirotaka, I am really sorry, that I didn't reply. This somehow went under my radar.
The package looks good, and I'd give +1 but I have an issue when trying to build it in Copr. I am getting:
No matching package to install: 'python3-pyngus'
Also, there is now 14.2.3 version but that can be updated after the package review.
Product: Fedora Version: rawhide Component: Package Review
Hirotaka Wakabayashi hiwkby@yahoo.com has canceled Package Review package-review@lists.fedoraproject.org's request for Hirotaka Wakabayashi hiwkby@yahoo.com's needinfo: Bug 2009155: Review Request: python-oslo-messaging - OpenStack common messaging library https://bugzilla.redhat.com/show_bug.cgi?id=2009155
--- Comment #11 from Hirotaka Wakabayashi hiwkby@yahoo.com --- Hello Jakub, Thanks for the comment!!
No matching package to install: 'python3-pyngus'
OK, I will check the package status and update this package.
Also, there is now 14.2.3 version but that can be updated after the package
review.
Sure, I will update the version too.
Hirotaka
https://bugzilla.redhat.com/show_bug.cgi?id=2009155
Hirotaka Wakabayashi hiwkby@yahoo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |hiwkby@yahoo.com Flags|needinfo?(hiwkby@yahoo.com) | Status|NEW |ASSIGNED
--- Comment #11 from Hirotaka Wakabayashi hiwkby@yahoo.com --- Hello Jakub, Thanks for the comment!!
No matching package to install: 'python3-pyngus'
OK, I will check the package status and update this package.
Also, there is now 14.2.3 version but that can be updated after the package review.
Sure, I will update the version too.
Hirotaka
https://bugzilla.redhat.com/show_bug.cgi?id=2009155
Xavier Bachelot xavier@bachelot.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |xavier@bachelot.org Assignee|hiwkby@yahoo.com |jkadlcik@redhat.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=2009155
--- Comment #12 from Hirotaka Wakabayashi hiwkby@yahoo.com --- Thanks for the updates. This bug is WIP. python3-pyngus, on which oslo.messaging depends, was retired half a year ago as a FTBFS/FTI bugs. So, I am working to unretire the pyngus package firstly.
https://bugzilla.redhat.com/show_bug.cgi?id=2009155
--- Comment #13 from Hirotaka Wakabayashi hiwkby@yahoo.com --- (In reply to Hirotaka Wakabayashi from comment #12)
Thanks for the updates. This bug is WIP. python3-pyngus, on which oslo.messaging depends, was retired half a year ago as a FTBFS/FTI bugs. So, I am working to unretire the pyngus package firstly.
Hello, the unretirement of the pyngus package is completed and I uploaded the new spec file that updates the version to 14.7.0.
Spec URL: https://hiwkby.fedorapeople.org/python-oslo-messaging.spec SRPM URL: https://hiwkby.fedorapeople.org/python-oslo-messaging-14.7.0-1.fc41.src.rpmH... is the diff
Koji scratch build result(success) https://koji.fedoraproject.org/koji/taskinfo?taskID=116584453
Here is the diff. ``` $ diff -c python-oslo-messaging.spec.1 python-oslo-messaging.spec *** python-oslo-messaging.spec.1 Fri Dec 9 05:45:20 2022 --- python-oslo-messaging.spec Fri Apr 19 02:41:43 2024 *************** *** 1,5 **** %{!?sources_gpg: %{!?dlrn:%global sources_gpg 1} } ! %global sources_gpg_sign 0xa63ea142678138d1bb15f2e303bdfd64dd164087
%{!?upstream_version: %global upstream_version %{version}%{?milestone}} %global with_doc 1 --- 1,5 ---- %{!?sources_gpg: %{!?dlrn:%global sources_gpg 1} } ! %global sources_gpg_sign 0x2ef3fe0ec2b075ab7458b5f8b702b20b13df2318
%{!?upstream_version: %global upstream_version %{version}%{?milestone}} %global with_doc 1 *************** *** 16,23 **** %global pkg_name oslo-messaging
Name: python-oslo-messaging ! Version: 14.0.0 ! Release: 6%{?dist} Summary: OpenStack common messaging library
License: ASL 2.0 --- 16,23 ---- %global pkg_name oslo-messaging
Name: python-oslo-messaging ! Version: 14.7.0 ! Release: 1%{?dist} Summary: OpenStack common messaging library
License: ASL 2.0 *************** *** 191,196 **** --- 191,199 ----
%changelog + * Fri Apr 19 2024 Hirotaka Wakabayashi hiwkby@yahoo.com - 14.7.0-1 + - Update to 14.7.0 + * Fri Dec 09 2022 Hirotaka Wakabayashi hiwkby@yahoo.com - 14.0.0-6 - Adds BuildRequires for tests - Fixes issues on the packaging guidelines ```
Koji scratch build result(success) https://koji.fedoraproject.org/koji/taskinfo?taskID=116584453
Thanks in advance, Hirotaka
https://bugzilla.redhat.com/show_bug.cgi?id=2009155
--- Comment #14 from Hirotaka Wakabayashi hiwkby@yahoo.com --- [fedora-review-service-build]
https://bugzilla.redhat.com/show_bug.cgi?id=2009155
--- Comment #15 from Jakub Kadlčík jkadlcik@redhat.com --- Hello Hirotaka,
[fedora-review-service-build]
Just to clarify, you tried to trigger the build correctly. There problem why it wasn't triggered was likely this: https://github.com/FrostyX/fedora-review-service/issues/42
Name: python-oslo-messaging
Nitpick: You can use python-%{pkg_name}
License: ASL 2.0
Since recently, Fedora migrated to using SPDX expressions for license names, so the "ASL 2.0" isn't valid anymore, see
$ license-validate "ASL 2.0" $ echo $?
The correct license name should be:
$ license-fedora2spdx "ASL 2.0" Apache-2.0
%{py3_install}
Just for the record, the specfile follows the 201x-era guidelines https://docs.fedoraproject.org/en-US/packaging-guidelines/Python_201x/ but there is now more current approach using dynamic BuildRequires and so on https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/
Both approaches are valid, so feel free to continue using this one. I just wanted to let you know in case you were writing a new package in a future.
BuildRequires: python3-pyngus
This works for rawhide which is important. But just mentioning that it fails for F39 because of
No matching package to install: 'python3-pyngus'
The fedora-review tool complains about the provided MD5sum:
- Sources used to build the package match the upstream source, as provided in the spec URL. Note: Upstream MD5sum check error, diff is in /tmp/fedora- rawhide-x86_64/review-python-oslo-messaging/diff.txt See: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/
The mentioned diff is here:
diff -U2 -r /tmp/fedora-rawhide-x86_64/review-python-oslo-messaging/upstream-unpacked/Source102/0x2ef3fe0ec2b075ab7458b5f8b702b20b13df2318.txt /tmp/fedora-rawhide-x86_64/review-python-oslo-messaging/srpm-unpacked/0x2ef3fe0ec2b075ab7458b5f8b702b20b13df2318.txt-extract/0x2ef3fe0ec2b075ab7458b5f8b702b20b13df2318.txt --- /tmp/fedora-rawhide-x86_64/review-python-oslo-messaging/upstream-unpacked/Source102/0x2ef3fe0ec2b075ab7458b5f8b702b20b13df2318.txt 2024-04-30 13:34:18.038159010 +0200 +++ /tmp/fedora-rawhide-x86_64/review-python-oslo-messaging/srpm-unpacked/0x2ef3fe0ec2b075ab7458b5f8b702b20b13df2318.txt-extract/0x2ef3fe0ec2b075ab7458b5f8b702b20b13df2318.txt 2024-04-30 13:34:18.157158924 +0200 @@ -44,2 +44,3 @@ =7Dhm -----END PGP PUBLIC KEY BLOCK----- +
Overall the package looks good to me, basically only the license name and the checksum error needs to be fixed.
https://bugzilla.redhat.com/show_bug.cgi?id=2009155
--- Comment #16 from Hirotaka Wakabayashi hiwkby@yahoo.com --- Hello Jakub, Thanks for your kind review and the advice! I fixed the license name and the checksum error for now.
Spec URL: https://hiwkby.fedorapeople.org/python-oslo-messaging.spec SRPM URL: https://hiwkby.fedorapeople.org/python-oslo-messaging-14.7.0-2.fc41.src.rpm
Here is the diff. ``` $ diff -c python-oslo-messaging.spec.3 python-oslo-messaging.spec *** python-oslo-messaging.spec.3 Fri Apr 19 02:54:30 2024 --- python-oslo-messaging.spec Wed May 1 17:16:59 2024 *************** *** 15,26 **** %global pypi_name oslo.messaging %global pkg_name oslo-messaging
! Name: python-oslo-messaging Version: 14.7.0 ! Release: 1%{?dist} Summary: OpenStack common messaging library
! License: ASL 2.0 URL: https://opendev.org/openstack/oslo.messaging Source0: https://tarballs.openstack.org/%%7Bpypi_name%7D/%%7Bpypi_name%7D-%%7Bupstrea... # Required for tarball sources verification --- 15,26 ---- %global pypi_name oslo.messaging %global pkg_name oslo-messaging
! Name: python-%{pkg_name} Version: 14.7.0 ! Release: 2%{?dist} Summary: OpenStack common messaging library
! License: Apache-2.0 URL: https://opendev.org/openstack/oslo.messaging Source0: https://tarballs.openstack.org/%%7Bpypi_name%7D/%%7Bpypi_name%7D-%%7Bupstrea... # Required for tarball sources verification *************** *** 191,196 **** --- 191,199 ----
%changelog + * Tue Apr 30 2024 Hirotaka Wakabayashi hiwkby@yahoo.com - 14.7.0-2 + - Fixes issues on the packaging guidelines + * Fri Apr 19 2024 Hirotaka Wakabayashi hiwkby@yahoo.com - 14.7.0-1 - Update to 14.7.0
``` Koji Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=117118150
Just to clarify, you tried to trigger the build correctly. There problem why it wasn't triggered was likely this: https://github.com/FrostyX/fedora-review-service/issues/42
Oh... We should manually run fedora-review while the service is unavailable.
Both approaches are valid, so feel free to continue using this one. I just wanted to let you know in case you were writing a new package in a future.
Thank you for the advice, I will follow the new package guidelines when making new packages.:)
This works for rawhide which is important. But just mentioning that it fails for F39 because of
No matching package to install: 'python3-pyngus'
Sorry, I have not created the f39 branch of python3-pyngus yet, I will prepare for it.
Thanks in advance, Hirotaka
https://bugzilla.redhat.com/show_bug.cgi?id=2009155
--- Comment #17 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/7396817 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Found issues:
- License file license.png is not marked as %license Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuideline... - A package with this name already exists. Please check https://src.fedoraproject.org/rpms/python-oslo-messaging Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicti...
Please know that there can be false-positives.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2009155
--- Comment #18 from Jakub Kadlčík jkadlcik@redhat.com --- Both of the issues mentioned by fedora-review are false-positives. +1
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
Issues: ======= - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file license.png is not marked as %license See: https://docs.fedoraproject.org/en-US/packaging- guidelines/LicensingGuidelines/#_license_text - Package does not use a name that already exists. Note: A package with this name already exists. Please check https://src.fedoraproject.org/rpms/python-oslo-messaging See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Naming/#_conflicting_package_names
===== MUST items =====
Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Apache License 2.0", "*No copyright* Apache License", "Apache License 2.0". 119 files have unknown license. Detailed output of licensecheck in /var/lib/copr- rpmbuild/results/python-oslo-messaging/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package requires other packages for directories it uses. Note: No known owner of /usr, /usr/lib/python3.12/site-packages, /usr/share, /usr/share/licenses, /usr/lib, /usr/bin, /usr/lib/python3.12, /usr/share/doc [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/bin, /usr, /usr/lib/python3.12/site-packages, /usr/share, /usr/share/licenses, /usr/lib/python3.12, /usr/share/doc, /usr/lib [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: The License field must be a valid SPDX expression. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 973 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local
Python: [x]: Binary eggs must be removed in %prep Note: Cannot find any build in BUILD directory (--prebuilt option?) [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
===== SHOULD items =====
Generic: [x]: Reviewer should test that the package builds in mock. [?]: Avoid bundling fonts in non-fonts packages. Note: Package contains font files [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-oslo-messaging , python3-oslo-messaging-tests [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages.
Rpmlint ------- Checking: python3-oslo-messaging-14.7.0-2.fc41.noarch.rpm python-oslo-messaging-doc-14.7.0-2.fc41.noarch.rpm python3-oslo-messaging-tests-14.7.0-2.fc41.noarch.rpm python-oslo-messaging-14.7.0-2.fc41.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp09rh12t2')] checks: 32, packages: 4
python-oslo-messaging-doc.noarch: W: python-sphinx-doctrees-leftover /usr/share/doc/python-oslo-messaging-doc/html/.doctrees python3-oslo-messaging.noarch: W: python-leftover-require python3-amqp python3-oslo-messaging.noarch: W: python-leftover-require python3-cachetools python3-oslo-messaging.noarch: W: python-leftover-require python3-debtcollector python3-oslo-messaging.noarch: W: python-leftover-require python3-eventlet python3-oslo-messaging.noarch: W: python-leftover-require python3-futurist python3-oslo-messaging.noarch: W: python-leftover-require python3-kombu python3-oslo-messaging.noarch: W: python-leftover-require python3-oslo-config python3-oslo-messaging.noarch: W: python-leftover-require python3-oslo-log python3-oslo-messaging.noarch: W: python-leftover-require python3-oslo-metrics python3-oslo-messaging.noarch: W: python-leftover-require python3-oslo-middleware python3-oslo-messaging.noarch: W: python-leftover-require python3-oslo-serialization python3-oslo-messaging.noarch: W: python-leftover-require python3-oslo-service python3-oslo-messaging.noarch: W: python-leftover-require python3-oslo-utils python3-oslo-messaging.noarch: W: python-leftover-require python3-pbr python3-oslo-messaging.noarch: W: python-leftover-require python3-pyngus python3-oslo-messaging.noarch: W: python-leftover-require python3-stevedore python3-oslo-messaging.noarch: W: python-leftover-require python3-webob python3-oslo-messaging.noarch: W: python-leftover-require python3-yaml python3-oslo-messaging.noarch: W: no-manual-page-for-binary oslo-messaging-send-notification python3-oslo-messaging.noarch: W: no-manual-page-for-binary oslo-messaging-send-notification-3 python3-oslo-messaging-tests.noarch: W: no-documentation python-oslo-messaging-doc.noarch: W: hidden-file-or-dir /usr/share/doc/python-oslo-messaging-doc/html/.doctrees python-oslo-messaging-doc.noarch: W: hidden-file-or-dir /usr/share/doc/python-oslo-messaging-doc/html/.doctrees python-oslo-messaging-doc.noarch: W: files-duplicate /usr/share/doc/python-oslo-messaging-doc/html/_static/images/openstack-logo-full.png /usr/share/doc/python-oslo-messaging-doc/html/_static/images/logo-full.png python-oslo-messaging-doc.noarch: W: files-duplicate /usr/share/doc/python-oslo-messaging-doc/html/_static/images/openstack-logo-full.svg /usr/share/doc/python-oslo-messaging-doc/html/_static/images/logo-full.svg python-oslo-messaging-doc.noarch: W: files-duplicate /usr/share/doc/python-oslo-messaging-doc/html/_static/images/openstack-logo-vert.png /usr/share/doc/python-oslo-messaging-doc/html/_static/images/logo-vert.png python-oslo-messaging-doc.noarch: W: files-duplicate /usr/share/doc/python-oslo-messaging-doc/html/_static/images/openstack-logo-vert.svg /usr/share/doc/python-oslo-messaging-doc/html/_static/images/logo-vert.svg python-oslo-messaging-doc.noarch: W: description-shorter-than-summary 4 packages and 0 specfiles checked; 0 errors, 29 warnings, 15 filtered, 0 badness; has taken 0.7 s
Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "python-oslo-messaging-doc". (none): E: there is no installed rpm "python3-oslo-messaging-tests". (none): E: there is no installed rpm "python3-oslo-messaging". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3
0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s
Source checksums ---------------- https://releases.openstack.org/_static/0x2ef3fe0ec2b075ab7458b5f8b702b20b13d... : CHECKSUM(SHA256) this package : a4f619daa6f2f0d47c611fabc489cf634e55d2386bb4f92d2929d2c8aafef53e CHECKSUM(SHA256) upstream package : a4f619daa6f2f0d47c611fabc489cf634e55d2386bb4f92d2929d2c8aafef53e https://tarballs.openstack.org/oslo.messaging/oslo.messaging-14.7.0.tar.gz.a... : CHECKSUM(SHA256) this package : f4476aca6ccb49d89fb40dfd099310540c3ec32f0d6f2c9308f8b59d83ae92e2 CHECKSUM(SHA256) upstream package : f4476aca6ccb49d89fb40dfd099310540c3ec32f0d6f2c9308f8b59d83ae92e2 https://tarballs.openstack.org/oslo.messaging/oslo.messaging-14.7.0.tar.gz : CHECKSUM(SHA256) this package : 99bb6178f92370cb5d8d9d71e0ed918bf356e4f1e011abc7e1d7e0ce99cf33ad CHECKSUM(SHA256) upstream package : 99bb6178f92370cb5d8d9d71e0ed918bf356e4f1e011abc7e1d7e0ce99cf33ad
Requires -------- python3-oslo-messaging (rpmlib, GLIBC filtered): /usr/bin/python3 python(abi) python3-amqp python3-cachetools python3-debtcollector python3-eventlet python3-futurist python3-kombu python3-oslo-config python3-oslo-log python3-oslo-metrics python3-oslo-middleware python3-oslo-serialization python3-oslo-service python3-oslo-utils python3-pbr python3-pyngus python3-stevedore python3-webob python3-yaml
python-oslo-messaging-doc (rpmlib, GLIBC filtered):
python3-oslo-messaging-tests (rpmlib, GLIBC filtered): python(abi) python3-oslo-config python3-oslo-messaging python3-oslo-middleware python3-oslo-serialization python3-oslo-service python3-oslo-utils python3-oslotest python3-stestr python3-testscenarios python3-testtools
Provides -------- python3-oslo-messaging: python-oslo-messaging python3-oslo-messaging python3.12-oslo-messaging python3.12dist(oslo-messaging) python3dist(oslo-messaging)
python-oslo-messaging-doc: python-oslo-messaging-doc
python3-oslo-messaging-tests: python-oslo-messaging-tests python3-oslo-messaging-tests python3.12-oslo-messaging-tests
Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name python-oslo-messaging --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic, Python Disabled plugins: C/C++, Ocaml, Java, fonts, Haskell, R, Perl, PHP, SugarActivity Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
https://bugzilla.redhat.com/show_bug.cgi?id=2009155
Jakub Kadlčík jkadlcik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
https://bugzilla.redhat.com/show_bug.cgi?id=2009155
--- Comment #19 from Hirotaka Wakabayashi hiwkby@yahoo.com --- Hi Jakub, Thank you so much! I really appreciate it.
Hirotaka
package-review@lists.fedoraproject.org