https://bugzilla.redhat.com/show_bug.cgi?id=1195255

--- Comment #1 from Martin Preisler mpreisle@redhat.com --- The Source0 URL doesn't work - 404 error. Do we have any working source for these tarballs? I tried to google for it for a while with no success.

The %define macro should be changed to %global.

There are a bunch of trivial things in the spec file, like mixing tabs and spaces. These could be fixed but I don't insist on it.

===== MUST items =====

C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs.

Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 32 files have unknown license. Detailed output of licensecheck in /home/mpreisle/fedora-review/review-compat- tolua++/licensecheck.txt [ ]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [!]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. Note: Test run failed [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Test run failed [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8.

===== SHOULD items =====

Generic:

!!! [!]: Sources can be downloaded from URI in Source: tag Note: Could not download Source0: http://www.codenix.com/~tolua/tolua++-1.0.93.tar.bz2 See: http://fedoraproject.org/wiki/Packaging:Guidelines#Tags !!!

[ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [-]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Scriptlets must be sane, if used. [!]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [!]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define solib tolua++-5.1 [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: SourceX is a working URL.

===== EXTRA items =====

Generic: [-]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.

Rpmlint ------- Checking: compat-tolua++-1.0.93-1.fc21.x86_64.rpm compat-tolua++-devel-1.0.93-1.fc21.x86_64.rpm compat-tolua++-1.0.93-1.fc21.src.rpm compat-tolua++.x86_64: W: spelling-error Summary(en_US) lua -> la, luau, lea compat-tolua++.x86_64: W: spelling-error Summary(en_US) tolua -> toluene compat-tolua++.x86_64: W: summary-not-capitalized C lua-5.1 compatible version of tolua++ (C++ Lua integration) compat-tolua++.x86_64: W: spelling-error %description -l en_US lua -> la, luau, lea compat-tolua++.x86_64: W: spelling-error %description -l en_US tolua -> toluene compat-tolua++.x86_64: W: invalid-url URL: http://www.codenix.com/~tolua/ HTTP Error 404: Not Found compat-tolua++-devel.x86_64: W: spelling-error Summary(en_US) tolua -> toluene compat-tolua++-devel.x86_64: W: spelling-error %description -l en_US tolua -> toluene compat-tolua++-devel.x86_64: W: invalid-url URL: http://www.codenix.com/~tolua/ HTTP Error 404: Not Found compat-tolua++-devel.x86_64: W: only-non-binary-in-usr-lib compat-tolua++-devel.x86_64: W: no-documentation compat-tolua++-devel.x86_64: W: no-manual-page-for-binary tolua++ compat-tolua++.src: W: spelling-error Summary(en_US) lua -> la, luau, lea compat-tolua++.src: W: spelling-error Summary(en_US) tolua -> toluene compat-tolua++.src: W: summary-not-capitalized C lua-5.1 compatible version of tolua++ (C++ Lua integration) compat-tolua++.src: W: spelling-error %description -l en_US lua -> la, luau, lea compat-tolua++.src: W: spelling-error %description -l en_US tolua -> toluene compat-tolua++.src: W: invalid-url URL: http://www.codenix.com/~tolua/ HTTP Error 404: Not Found compat-tolua++.src:29: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 29) compat-tolua++.src: W: invalid-url Source0: http://www.codenix.com/~tolua/tolua++-1.0.93.tar.bz2 HTTP Error 404: Not Found 3 packages and 0 specfiles checked; 0 errors, 20 warnings.

Provides -------- compat-tolua++-devel: compat-tolua++-devel compat-tolua++-devel(x86-64)

compat-tolua++: compat-tolua++ compat-tolua++(x86-64) libtolua++-5.1.so()(64bit)

https://bugzilla.redhat.com/show_bug.cgi?id=1195255

Martin Preisler mpreisle@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+

--- Comment #3 from Martin Preisler mpreisle@redhat.com --- Looks reasonably good now. Accepted.

https://bugzilla.redhat.com/show_bug.cgi?id=1195255

Jon Ciesla limburgher@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+

https://bugzilla.redhat.com/show_bug.cgi?id=1195255

PnT Account Manager pnt-expunge@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Assignee|mpreisle@redhat.com |nobody@fedoraproject.org