[Bug 2292550] New: Review Request: <main package name here> - Rust library for accessing USB devices
https://bugzilla.redhat.com/show_bug.cgi?id=2292550
Bug ID: 2292550 Summary: Review Request: <main package name here> - Rust library for accessing USB devices Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: jonathansteffan@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://jsteffan.fedorapeople.org/envision/rust-rusb.spec SRPM URL: https://jsteffan.fedorapeople.org/envision/rust-rusb-0.9.4-1.fc39/rust-rusb-... Description: Rust library for accessing USB devices Fedora Account System Username: jsteffan
https://bugzilla.redhat.com/show_bug.cgi?id=2292550
--- Comment #1 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Cannot find any valid SRPM URL for this ticket. Common causes are:
- You didn't specify `SRPM URL: ...` in the ticket description or any of your comments - The URL schema isn't HTTP or HTTPS - The SRPM package linked in your URL doesn't match the package name specified in the ticket summary
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2292550
Jonathan Steffan jonathansteffan@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: <main |Review Request: rust-rusb - |package name here> - Rust |Rust library for accessing |library for accessing USB |USB devices |devices | Doc Type|--- |If docs needed, set a value
https://bugzilla.redhat.com/show_bug.cgi?id=2292550
Jonathan Steffan jonathansteffan@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2292541
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2292541 [Bug 2292541] Review Request: envision - UI for building, configuring, and running Monado/WiVRn
https://bugzilla.redhat.com/show_bug.cgi?id=2292550
Jonathan Steffan jonathansteffan@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |2292553, 2292544
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2292544 [Bug 2292544] Review Request: rust-libusb1-sys - FFI bindings for libusb https://bugzilla.redhat.com/show_bug.cgi?id=2292553 [Bug 2292553] Review Request: rust-usb-ids - Rust wrappers for the USB ID Repository
https://bugzilla.redhat.com/show_bug.cgi?id=2292550 Bug 2292550 depends on bug 2292553, which changed state.
Bug 2292553 Summary: Review Request: rust-usb-ids - Rust wrappers for the USB ID Repository https://bugzilla.redhat.com/show_bug.cgi?id=2292553
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=2292550
--- Comment #2 from Jonathan Steffan jonathansteffan@gmail.com --- [fedora-review-service-build]
https://bugzilla.redhat.com/show_bug.cgi?id=2292550
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://crates.io/crates/ru | |sb
--- Comment #3 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/7662186 (failed)
Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please make sure the package builds successfully at least for Fedora Rawhide.
- If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2292550 Bug 2292550 depends on bug 2292544, which changed state.
Bug 2292544 Summary: Review Request: rust-libusb1-sys - FFI bindings for libusb https://bugzilla.redhat.com/show_bug.cgi?id=2292544
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=2292550
Peter Hutterer peter.hutterer@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |peter.hutterer@redhat.com
--- Comment #4 from Peter Hutterer peter.hutterer@redhat.com --- I think the comments from #2292544 regarding the vendored-devel package apply here too?
https://bugzilla.redhat.com/show_bug.cgi?id=2292550
--- Comment #5 from Jonathan Steffan jonathansteffan@gmail.com --- I've removed the vendored and added the needed BR.
Spec URL: https://jsteffan.fedorapeople.org/envision/rust-rusb.spec SRPM URL: https://jsteffan.fedorapeople.org/envision/rust-rusb-0.9.4-1.fc39/rust-rusb-...
https://bugzilla.redhat.com/show_bug.cgi?id=2292550
--- Comment #6 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 2038397 --> https://bugzilla.redhat.com/attachment.cgi?id=2038397&action=edit The .spec file difference from Copr build 7662186 to 7677645
https://bugzilla.redhat.com/show_bug.cgi?id=2292550
--- Comment #7 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/7677645 (failed)
Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please make sure the package builds successfully at least for Fedora Rawhide.
- If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2292550
--- Comment #8 from Jonathan Steffan jonathansteffan@gmail.com --- [fedora-review-service-build]
https://bugzilla.redhat.com/show_bug.cgi?id=2292550
--- Comment #9 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/7690098 (failed)
Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please make sure the package builds successfully at least for Fedora Rawhide.
- If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2292550
--- Comment #10 from Jonathan Steffan jonathansteffan@gmail.com --- We are now waiting for `crate(libusb1-sys/default)` to hit the rawhide repo. It was included in the latest compose but is not yet in the repos (or the cache for fedora-review-service hasn't expired or sync'd yet).
https://bugzilla.redhat.com/show_bug.cgi?id=2292550
--- Comment #11 from Jonathan Steffan jonathansteffan@gmail.com --- [fedora-review-service-build]
https://bugzilla.redhat.com/show_bug.cgi?id=2292550
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |AutomationTriaged
--- Comment #12 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/7694647 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2292550
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? CC| |decathorpe@gmail.com Assignee|nobody@fedoraproject.org |decathorpe@gmail.com Status|NEW |ASSIGNED
--- Comment #13 from Fabio Valentini decathorpe@gmail.com ---
BuildRequires: pkgconfig(libusb-1.0)
This should not be necessary if the correct Requires are present in rust-libusb1-sys. And indeed, the Requires is missing there.
You can add a rust2rpm.toml config file to rust-libusb1-sys like this one:
``` [requires] build = ["pkgconfig(libusb-1.0"] lib = ["pkgconfig(libusb-1.0"] ```
This will add the dependency on pkgconfig(libusb-1.0) as both BuildRequires and Requires in the -devel subpackage.
https://bugzilla.redhat.com/show_bug.cgi?id=2292550
--- Comment #15 from Jonathan Steffan jonathansteffan@gmail.com --- https://bodhi.fedoraproject.org/updates/FEDORA-2024-404cce887d
https://bugzilla.redhat.com/show_bug.cgi?id=2292550
--- Comment #16 from Jonathan Steffan jonathansteffan@gmail.com --- Spec URL: https://jsteffan.fedorapeople.org/envision/rust-rusb.spec SRPM URL: https://jsteffan.fedorapeople.org/envision/rust-rusb-0.9.4-1.fc39/rust-rusb-...
https://bugzilla.redhat.com/show_bug.cgi?id=2292550
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #17 from Fabio Valentini decathorpe@gmail.com --- Perfect. Looks good to me!
===
Package was generated with rust2rpm, simplifying the review.
✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license file is included with %license in %files ✅ package complies with Rust Packaging Guidelines
Package APPROVED.
===
Recommended post-import rust-sig tasks:
- set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate
- add @rust-sig with "commit" access as package co-maintainer (should happen automatically)
- set bugzilla assignee overrides to @rust-sig (optional)
- track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer)
https://bugzilla.redhat.com/show_bug.cgi?id=2292550
Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST
--- Comment #18 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-rusb
https://bugzilla.redhat.com/show_bug.cgi?id=2292550
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #19 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-033f6bd2dd (rust-rusb-0.9.4-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-033f6bd2dd
https://bugzilla.redhat.com/show_bug.cgi?id=2292550
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |ERRATA Status|MODIFIED |CLOSED Last Closed| |2024-07-11 15:51:27
--- Comment #20 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-033f6bd2dd (rust-rusb-0.9.4-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2292550
--- Comment #21 from Jonathan Steffan jonathansteffan@gmail.com --- I used fedora-sig-onboard, very convenient.
https://bugzilla.redhat.com/show_bug.cgi?id=2292550
--- Comment #22 from Jonathan Steffan jonathansteffan@gmail.com --- Need karma on the following so I can build for f40 and f39.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-9759a91403 https://bodhi.fedoraproject.org/updates/FEDORA-2024-da1c65b4b2
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com