https://bugzilla.redhat.com/show_bug.cgi?id=2075949

Benson Muite benson_muite@emailplus.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Blocks| |177841 (FE-NEEDSPONSOR) CC| |benson_muite@emailplus.org

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor

https://bugzilla.redhat.com/show_bug.cgi?id=2075949

--- Comment #1 from Parag AN(पराग) panemade@gmail.com --- Do read new fonts packaging guidelines https://docs.fedoraproject.org/en-US/packaging-guidelines/FontsPolicy and write SPEC file according to it. You can take examples like https://src.fedoraproject.org/rpms/aajohan-comfortaa-fonts/blob/rawhide/f/aa... https://src.fedoraproject.org/rpms/astigmatic-grand-hotel-fonts/blob/rawhide...

https://bugzilla.redhat.com/show_bug.cgi?id=2075949

--- Comment #6 from Parag AN(पराग) panemade@gmail.com --- When you write font family you need to write only family name and not with its style name.

This packaging looks complex to me. If you only want to package "Bungee_Desktop" fonts then there should be 13 subpackages to be created. See Bungee/Bungee-Hairline.otf:Family: Bungee Hairline Bungee/Bungee-Inline.otf:Family: Bungee Inline Bungee/Bungee-Outline.otf:Family: Bungee Outline Bungee/Bungee-Regular.otf:Family: Bungee Regular Bungee/Bungee-Shade.otf:Family: Bungee Shade BungeeLayers/BungeeLayers-Inline.otf:Family: Bungee Layers Inline BungeeLayers/BungeeLayers-Outline.otf:Family: Bungee Layers Outline BungeeLayers/BungeeLayers-Regular.otf:Family: Bungee Layers Regular BungeeLayers/BungeeLayers-Shade.otf:Family: Bungee Layers Shade BungeeLayersRotated/BungeeLayersRotated-Inline.otf:Family: Bungee Layers Rotated Inline BungeeLayersRotated/BungeeLayersRotated-Outline.otf:Family: Bungee Layers Rotated Outline BungeeLayersRotated/BungeeLayersRotated-Regular.otf:Family: Bungee Layers Rotated Regular BungeeLayersRotated/BungeeLayersRotated-Shade.otf:Family: Bungee Layers Rotated Shade

as seen above, use family name as shown above for those 13 sub-packages. Then you can also add 3 more meta subpackages like djr-bungee-fonts-all, djr-bungee-layers-fonts-all and djr-bungee-layers-rotated-fonts-all. Then one final subpackage called djr-bungee-desktop-fonts-all that installs djr-bungee-fonts-all, djr-bungee-layers-fonts-all and djr-bungee-layers-rotated-fonts-all. The final specfile should generate 17 binary rpms. I suggest name this package as djr-bungee-desktop-fonts. These are just my suggestions, need to check if it can be implemented.

I saw you need sponsorship in Fedora packager group. Have you submitted anymore packages or you already tried reviewing other contributor's packages? ------------------------------------------------------------------------------ If you are new RPM packager and want to package some software in Fedora then you will need Sponsorship for your package. To get sponsor for your package in packager group, please follow these things.

Make sure you have followed steps given on https://docs.fedoraproject.org/en-US/package-maintainers/Joining_the_Package...

We have this process, https://docs.fedoraproject.org/en-US/package-maintainers/How_to_Get_Sponsore... to get sponsored into the packager group. When you submit your first submission, it will be good if you either submit few more packages and/or do some full detailed package reviews. This is needed to make sure package submitter understands the rpm packaging well and follows the fedora packaging guidelines. Check more on this at https://docs.fedoraproject.org/en-US/package-maintainers/How_to_Get_Sponsore...

Please go through the following links 1) https://docs.fedoraproject.org/en-US/package-maintainers/Package_Review_Proc...

2) https://docs.fedoraproject.org/en-US/packaging-guidelines/

3) To find the packages already submitted for review, check http://fedoraproject.org/PackageReviewStatus/

4) https://docs.fedoraproject.org/en-US/packaging-guidelines/ReviewGuidelines/ and

https://docs.fedoraproject.org/en-US/package-maintainers/Package_Review_Proc... is useful while doing package reviews.

5) https://pagure.io/FedoraReview this is fedora-review tool to help review packages in fedora. You need to use this and do un-official package reviews of packages submitted by other contributors. While doing so mention "This is un-official review of the package." at top of your review comment. You can install this tool on your Fedora system by running command "sudo dnf install fedora-review"

Good to review packages listed in https://fedoraproject.org/PackageReviewStatus/reviewable.html or https://fedoraproject.org/PackageReviewStatus/needsponsor.html

When you do full package review of some packages, provide that review comment link here so that I can look how you have reviewed those packages. An example command to run fedora-review on any package review bugzilla is

fedora-review -b <bugid> -m fedora-rawhide-x86_64

If you got any questions please do ask here. ---------------------------------------------------------------------------------------------------------

https://bugzilla.redhat.com/show_bug.cgi?id=2075949

--- Comment #9 from Parag AN(पराग) panemade@gmail.com --- Thanks. I will sponsor you once this package gets approved.

https://bugzilla.redhat.com/show_bug.cgi?id=2075949

--- Comment #12 from Benson Muite benson_muite@emailplus.org --- OTF files can be generated from sources using https://github.com/googlefonts/ufo2ft but this is not yet packaged, and it seems to be developing relatively quickly. Related upstream discussion at https://github.com/djrrb/Bungee/issues/76

https://bugzilla.redhat.com/show_bug.cgi?id=2075949

Petr Pisar ppisar@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review?

https://bugzilla.redhat.com/show_bug.cgi?id=2075949

--- Comment #16 from Benson Muite benson_muite@emailplus.org --- ufo2ft has a dependency on skia-pathops which would also be useful for fonttools https://src.fedoraproject.org/rpms/fonttools/blob/rawhide/f/fonttools.spec

skia-pathops is not used by default: https://github.com/googlefonts/ufo2ft/blob/main/Lib/ufo2ft/filters/removeOve... https://github.com/googlefonts/ufo2ft/blob/main/Lib/ufo2ft/preProcessor.py#L...

and is required as an extra: https://github.com/googlefonts/ufo2ft/blob/main/setup.py#L37

Initial rebuild of ufo2ft does not include skia-pathops: https://copr.fedorainfracloud.org/coprs/fed500/python3-ufo2ft/

https://bugzilla.redhat.com/show_bug.cgi?id=2075949

--- Comment #38 from Benson Muite benson_muite@emailplus.org --- Many thanks for sponsorship. Did not want to clutter inboxes.

https://bugzilla.redhat.com/show_bug.cgi?id=2075949

Parag AN(पराग) panemade@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(panemade@gmail.co | |m) |

--- Comment #40 from Parag AN(पराग) panemade@gmail.com --- (In reply to Package Review from comment #39)

This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time, but it seems that the review is still being working out by you. If this is right, please respond to this comment clearing the NEEDINFO flag and try to reach out the submitter to proceed with the review.

If you're not interested in reviewing this ticket anymore, please clear the fedora-review flag and reset the assignee, so that a new reviewer can take this ticket.

Without any reply, this request will shortly be resetted.

Hey you seems really funny. I know you are a bot but you should needinfo both the parties here.

https://bugzilla.redhat.com/show_bug.cgi?id=2075949

Parag AN(पराग) panemade@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Assignee|panemade@gmail.com |nobody@fedoraproject.org Status|ASSIGNED |NEW Flags|fedora-review? |

https://bugzilla.redhat.com/show_bug.cgi?id=2075949

Benson Muite benson_muite@emailplus.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(benson_muite@emai | |lplus.org) |

--- Comment #43 from Benson Muite benson_muite@emailplus.org --- Will update this.