https://bugzilla.redhat.com/show_bug.cgi?id=1270630
gil cattaneo <puntogil(a)libero.it> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Assignee|nobody(a)fedoraproject.org |puntogil(a)libero.it
Flags| |fedora-review?
--- Comment #5 from gil cattaneo <puntogil(a)libero.it> ---
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
=======
- Package does not use a name that already exists.
Note: A package with this name already exists. Please check
https://admin.fedoraproject.org/pkgdb/acls/name/valabind
See:
https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Conflicting_Pac...
IGNORE
===== MUST items =====
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[ ]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated". 23 files have unknown license. Detailed
output of licensecheck in /home/gil/1270630-valabind/licensecheck.txt
Unknown or generated
--------------------
valabind-cd4051f6a7f63b297f3950c11a30f468351cbd69/foo.vapi
valabind-cd4051f6a7f63b297f3950c11a30f468351cbd69/t/java/AsmExample.java
valabind-cd4051f6a7f63b297f3950c11a30f468351cbd69/t/java/RAsm.java
valabind-cd4051f6a7f63b297f3950c11a30f468351cbd69/t/java/RAsmCode.java
valabind-cd4051f6a7f63b297f3950c11a30f468351cbd69/t/python/example.py
valabind-cd4051f6a7f63b297f3950c11a30f468351cbd69/t/r2/test.cs
valabind-cd4051f6a7f63b297f3950c11a30f468351cbd69/t/r2/test.java
valabind-cd4051f6a7f63b297f3950c11a30f468351cbd69/t/r2/test.pl
valabind-cd4051f6a7f63b297f3950c11a30f468351cbd69/t/r2/test.py
valabind-cd4051f6a7f63b297f3950c11a30f468351cbd69/t/r2/test.rb
valabind-cd4051f6a7f63b297f3950c11a30f468351cbd69/t/vala/test.cxx
valabind-cd4051f6a7f63b297f3950c11a30f468351cbd69/t/vala/test.py
valabind-cd4051f6a7f63b297f3950c11a30f468351cbd69/t/vala/vstest.vala
Copyleft 2009-2012 -- pancake //
nopcode.org
valabind-cd4051f6a7f63b297f3950c11a30f468351cbd69/cxxwriter.vala
valabind-cd4051f6a7f63b297f3950c11a30f468351cbd69/girwriter.vala
valabind-cd4051f6a7f63b297f3950c11a30f468351cbd69/valabindwriter.vala
Copyleft 2014 -- williballenthin
valabind-cd4051f6a7f63b297f3950c11a30f468351cbd69/gowriter.vala
Copyleft 2012-2014 -- pancake, eddyb, ritesh
valabind-cd4051f6a7f63b297f3950c11a30f468351cbd69/nodeffiwriter.vala
Copyleft 2009-2015 -- pancake, ritesh
valabind-cd4051f6a7f63b297f3950c11a30f468351cbd69/utils.vala
Copyleft 2015 -- pancake
valabind-cd4051f6a7f63b297f3950c11a30f468351cbd69/windows.c
[x]: %build honors applicable compiler flags or justifies otherwise.
[?]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[-]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 5 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[?]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Uses parallel make %{?_smp_mflags} macro.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on debuginfo package(s).
Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
Note: No rpmlint messages.
[x]: Large data in /usr/share should live in a noarch subpackage if package
is arched.
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
-------
Checking: valabind-0.9.2-2.fc24.i686.rpm
valabind-0.9.2-2.fc24.src.rpm
valabind.i686: W: spelling-error Summary(en_US) vala -> lava, val, vale
valabind.i686: W: spelling-error Summary(en_US) vapi -> vapid
valabind.i686: W: spelling-error %description -l en_US vala -> lava, val, vale
valabind.i686: W: spelling-error %description -l en_US vapi -> vapid
valabind.src: W: spelling-error Summary(en_US) vala -> lava, val, vale
valabind.src: W: spelling-error Summary(en_US) vapi -> vapid
valabind.src: W: spelling-error %description -l en_US vala -> lava, val, vale
valabind.src: W: spelling-error %description -l en_US vapi -> vapid
2 packages and 0 specfiles checked; 0 errors, 8 warnings.
Rpmlint (debuginfo)
-------------------
Checking: valabind-debuginfo-0.9.2-2.fc24.i686.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
Rpmlint (installed packages)
----------------------------
sh: /usr/bin/python: File o directory non esistente
2 packages and 0 specfiles checked; 0 errors, 0 warnings.
Requires
--------
valabind (rpmlib, GLIBC filtered):
/bin/sh
libc.so.6
libglib-2.0.so.0
libgobject-2.0.so.0
libvala-0.30.so.0
rtld(GNU_HASH)
Provides
--------
valabind:
valabind
valabind(x86-32)
Source checksums
----------------
https://github.com/radare/valabind/archive/cd4051f6a7f63b297f3950c11a30f4...
:
CHECKSUM(SHA256) this package :
b98700c32ede43a6fdb72319402ba530b24d5e1cfa299f25c6547a5706689481
CHECKSUM(SHA256) upstream package :
b98700c32ede43a6fdb72319402ba530b24d5e1cfa299f25c6547a5706689481
Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20
Command line :/bin/fedora-review -b 1270630 -m fedora-rawhide-i386
Buildroot used: fedora-rawhide-i386
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R,
PHP, Ruby
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component