[Bug 2071547] New: Review Request: obs-service-cargo_vendor - An OBS source service: Download, verify and vendor Rust crates (libraries)
https://bugzilla.redhat.com/show_bug.cgi?id=2071547
Bug ID: 2071547 Summary: Review Request: obs-service-cargo_vendor - An OBS source service: Download, verify and vendor Rust crates (libraries) Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: dan.cermak@cgc-instruments.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://defolos.fedorapeople.org/obs-service-cargo_vendor.spec SRPM URL: https://defolos.fedorapeople.org/obs-service-cargo_vendor-0.4.3-1.fc35.src.r... Description: An OBS Source Service that will download, verify and vendor Rust crates (libraries) Fedora Account System Username: defolos
Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=85142840
https://bugzilla.redhat.com/show_bug.cgi?id=2071547
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? Doc Type|--- |If docs needed, set a value Assignee|nobody@fedoraproject.org |ngompa13@gmail.com CC| |ngompa13@gmail.com
--- Comment #1 from Neal Gompa ngompa13@gmail.com --- Taking this review.
https://bugzilla.redhat.com/show_bug.cgi?id=2071547
--- Comment #2 from Neal Gompa ngompa13@gmail.com ---
Requires: (cargo or rustup)
Please drop the dependency on rustup. It doesn't exist and package dependencies need to exist in the distribution.
https://bugzilla.redhat.com/show_bug.cgi?id=2071547
--- Comment #3 from Neal Gompa ngompa13@gmail.com ---
Source: %{URL}/archive/refs/tags/v%{version}.tar.gz#./%{name}-%{version}.tar.gz
Please fix to the correct SourceURL format. "%{url}/archive/v%{version}/%{name}-%{version}.tar.gz"
https://bugzilla.redhat.com/show_bug.cgi?id=2071547
--- Comment #4 from Dan Čermák dan.cermak@cgc-instruments.com --- I have addressed both issues.
https://bugzilla.redhat.com/show_bug.cgi?id=2071547
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED
https://bugzilla.redhat.com/show_bug.cgi?id=2071547
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ Status|ASSIGNED |POST
--- Comment #5 from Neal Gompa ngompa13@gmail.com --- Review notes:
* Package builds and installs * Package naming complies with the guidelines * Package licensing is correct and license file is installed
There is one minor issue: I'd advise you fix the file list so that you correctly own your OBS service content:
Either: %dir %{_prefix}/lib/obs/service %{_prefix}/lib/obs/service/*
Or: %{_prefix}/lib/obs/service/
It's trivial to fix on import, so I'll let you do that then.
PACKAGE APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=2071547
--- Comment #6 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/obs-service-cargo_vendor
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com