https://bugzilla.redhat.com/show_bug.cgi?id=2188329
Bug ID: 2188329 Summary: Review Request: php-phpstan-phpdoc-parser - PHPDoc parser with support for nullable, intersection and generic types Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: fedora@famillecollet.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://git.remirepo.net/cgit/rpms/php/phpstan/php-phpstan-phpdoc-parser.git... SRPM URL: https://rpms.remirepo.net/SRPMS/php-phpstan-phpdoc-parser-1.20.0-1.remi.src.... Description: Next generation phpDoc parser with support for intersection types and generics.
Fedora Account System Username: remi
----
New dependency of php-phpdocumentor-type-resolver1, used in PHPUnit stack
https://bugzilla.redhat.com/show_bug.cgi?id=2188329
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://github.com/%%7Bgh_own | |er}/%{gh_project}
--- Comment #1 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5809291 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2188329
Remi Collet fedora@famillecollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value
--- Comment #2 from Remi Collet fedora@famillecollet.com --- Updated to 1.20.2
Spec URL: https://git.remirepo.net/cgit/rpms/php/phpstan/php-phpstan-phpdoc-parser.git... SRPM URL: https://rpms.remirepo.net/SRPMS/php-phpstan-phpdoc-parser-1.20.2-1.remi.src....
https://bugzilla.redhat.com/show_bug.cgi?id=2188329
--- Comment #3 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 1959732 --> https://bugzilla.redhat.com/attachment.cgi?id=1959732&action=edit The .spec file difference from Copr build 5809291 to 5847609
https://bugzilla.redhat.com/show_bug.cgi?id=2188329
--- Comment #4 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5847609 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2188329
--- Comment #5 from Remi Collet fedora@famillecollet.com --- Updated to 1.20.3
Spec URL: https://git.remirepo.net/cgit/rpms/php/phpstan/php-phpstan-phpdoc-parser.git... SRPM URL: https://rpms.remirepo.net/SRPMS/php-phpstan-phpdoc-parser-1.20.3-1.remi.src....
https://bugzilla.redhat.com/show_bug.cgi?id=2188329
--- Comment #6 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 1959763 --> https://bugzilla.redhat.com/attachment.cgi?id=1959763&action=edit The .spec file difference from Copr build 5847609 to 5847927
https://bugzilla.redhat.com/show_bug.cgi?id=2188329
--- Comment #7 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5847927 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2188329
--- Comment #8 from Remi Collet fedora@famillecollet.com --- Updated to 1.20.4
Spec URL: https://git.remirepo.net/cgit/rpms/php/phpstan/php-phpstan-phpdoc-parser.git... SRPM URL: https://rpms.remirepo.net/SRPMS/php-phpstan-phpdoc-parser-1.20.4-1.remi.src....
https://bugzilla.redhat.com/show_bug.cgi?id=2188329
--- Comment #9 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 1961876 --> https://bugzilla.redhat.com/attachment.cgi?id=1961876&action=edit The .spec file difference from Copr build 5847927 to 5869163
https://bugzilla.redhat.com/show_bug.cgi?id=2188329
--- Comment #10 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5869163 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2188329
--- Comment #11 from Remi Collet fedora@famillecollet.com --- Updated to 1.21.0
Spec URL: https://git.remirepo.net/cgit/rpms/php/phpstan/php-phpstan-phpdoc-parser.git... SRPM URL: https://rpms.remirepo.net/SRPMS/php-phpstan-phpdoc-parser-1.21.0-1.remi.src....
https://bugzilla.redhat.com/show_bug.cgi?id=2188329
--- Comment #12 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 1965075 --> https://bugzilla.redhat.com/attachment.cgi?id=1965075&action=edit The .spec file difference from Copr build 5869163 to 5928337
https://bugzilla.redhat.com/show_bug.cgi?id=2188329
--- Comment #13 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5928337 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2188329
--- Comment #14 from Remi Collet fedora@famillecollet.com --- Updated to 1.21.3
Spec URL: https://git.remirepo.net/cgit/rpms/php/phpstan/php-phpstan-phpdoc-parser.git... SRPM URL: https://rpms.remirepo.net/SRPMS/php-phpstan-phpdoc-parser-1.21.3-1.remi.src....
https://bugzilla.redhat.com/show_bug.cgi?id=2188329
--- Comment #15 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 1967850 --> https://bugzilla.redhat.com/attachment.cgi?id=1967850&action=edit The .spec file difference from Copr build 5928337 to 5984924
https://bugzilla.redhat.com/show_bug.cgi?id=2188329
--- Comment #16 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5984924 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2188329
--- Comment #17 from Remi Collet fedora@famillecollet.com --- Updated to 1.22.0
Spec URL: https://git.remirepo.net/cgit/rpms/php/phpstan/php-phpstan-phpdoc-parser.git... SRPM URL: https://rpms.remirepo.net/SRPMS/php-phpstan-phpdoc-parser-1.22.0-1.remi.src....
https://bugzilla.redhat.com/show_bug.cgi?id=2188329
--- Comment #18 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 1968463 --> https://bugzilla.redhat.com/attachment.cgi?id=1968463&action=edit The .spec file difference from Copr build 5984924 to 5996514
https://bugzilla.redhat.com/show_bug.cgi?id=2188329
--- Comment #19 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5996514 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2188329
--- Comment #20 from Remi Collet fedora@famillecollet.com --- Updated to 1.22.1
Spec URL: https://git.remirepo.net/cgit/rpms/php/phpstan/php-phpstan-phpdoc-parser.git... SRPM URL: https://rpms.remirepo.net/SRPMS/php-phpstan-phpdoc-parser-1.22.1-1.remi.src....
https://bugzilla.redhat.com/show_bug.cgi?id=2188329
--- Comment #21 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 1973841 --> https://bugzilla.redhat.com/attachment.cgi?id=1973841&action=edit The .spec file difference from Copr build 5996514 to 6135931
https://bugzilla.redhat.com/show_bug.cgi?id=2188329
--- Comment #22 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6135931 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2188329
--- Comment #23 from Remi Collet fedora@famillecollet.com --- Updated to 1.22.1
Spec URL: https://git.remirepo.net/cgit/rpms/php/phpstan/php-phpstan-phpdoc-parser.git... SRPM URL: https://rpms.remirepo.net/SRPMS/php-phpstan-phpdoc-parser-1.23.0-1.remi.src....
https://bugzilla.redhat.com/show_bug.cgi?id=2188329
--- Comment #24 from Remi Collet fedora@famillecollet.com --- Updated to 1.23.1
Spec URL: https://git.remirepo.net/cgit/rpms/php/phpstan/php-phpstan-phpdoc-parser.git... SRPM URL: https://rpms.remirepo.net/SRPMS/php-phpstan-phpdoc-parser-1.23.1-1.remi.src....
https://bugzilla.redhat.com/show_bug.cgi?id=2188329
--- Comment #25 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 1981605 --> https://bugzilla.redhat.com/attachment.cgi?id=1981605&action=edit The .spec file difference from Copr build 6135931 to 6240383
https://bugzilla.redhat.com/show_bug.cgi?id=2188329
--- Comment #26 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6240383 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2188329
--- Comment #27 from Remi Collet fedora@famillecollet.com --- Updated to 1.24.0
Spec URL: https://git.remirepo.net/cgit/rpms/php/phpstan/php-phpstan-phpdoc-parser.git... SRPM URL: https://rpms.remirepo.net/SRPMS/php-phpstan-phpdoc-parser-1.24.0-1.remi.src....
https://bugzilla.redhat.com/show_bug.cgi?id=2188329
--- Comment #28 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 1987680 --> https://bugzilla.redhat.com/attachment.cgi?id=1987680&action=edit The .spec file difference from Copr build 6240383 to 6384496
https://bugzilla.redhat.com/show_bug.cgi?id=2188329
--- Comment #29 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6384496 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2188329
--- Comment #30 from Remi Collet fedora@famillecollet.com --- Updated to 1.24.1
Spec URL: https://git.remirepo.net/cgit/rpms/php/phpstan/php-phpstan-phpdoc-parser.git... SRPM URL: https://rpms.remirepo.net/SRPMS/php-phpstan-phpdoc-parser-1.24.1-1.remi.src....
https://bugzilla.redhat.com/show_bug.cgi?id=2188329
--- Comment #31 from Remi Collet fedora@famillecollet.com --- Updated to 1.24.3
Spec URL: https://git.remirepo.net/cgit/rpms/php/phpstan/php-phpstan-phpdoc-parser.git... SRPM URL: https://rpms.remirepo.net/SRPMS/php-phpstan-phpdoc-parser-1.24.3-1.remi.src....
https://bugzilla.redhat.com/show_bug.cgi?id=2188329
--- Comment #32 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 2000524 --> https://bugzilla.redhat.com/attachment.cgi?id=2000524&action=edit The .spec file difference from Copr build 6384496 to 6670544
https://bugzilla.redhat.com/show_bug.cgi?id=2188329
--- Comment #33 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6670544 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2188329
--- Comment #34 from Remi Collet fedora@famillecollet.com --- Updated to 1.24.3
Spec URL: https://git.remirepo.net/cgit/rpms/php/phpstan/php-phpstan-phpdoc-parser.git...
SRPM URL: https://rpms.remirepo.net/SRPMS/php-phpstan-phpdoc-parser-1.24.4-1.remi.src....
https://bugzilla.redhat.com/show_bug.cgi?id=2188329
--- Comment #35 from Remi Collet fedora@famillecollet.com --- Updated to 1.24.5
Spec URL: https://git.remirepo.net/cgit/rpms/php/phpstan/php-phpstan-phpdoc-parser.git... SRPM URL: https://rpms.remirepo.net/SRPMS/php-phpstan-phpdoc-parser-1.24.5-1.remi.src....
https://bugzilla.redhat.com/show_bug.cgi?id=2188329
--- Comment #36 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 2004829 --> https://bugzilla.redhat.com/attachment.cgi?id=2004829&action=edit The .spec file difference from Copr build 6670544 to 6766549
https://bugzilla.redhat.com/show_bug.cgi?id=2188329
--- Comment #37 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6766549 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2188329
--- Comment #38 from Remi Collet fedora@famillecollet.com --- Updated to 1.24.5
Spec URL: https://git.remirepo.net/cgit/rpms/php/phpstan/php-phpstan-phpdoc-parser.git... SRPM URL: https://rpms.remirepo.net/SRPMS/php-phpstan-phpdoc-parser-1.25.0-1.remi.src....
https://bugzilla.redhat.com/show_bug.cgi?id=2188329
--- Comment #39 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 2007326 --> https://bugzilla.redhat.com/attachment.cgi?id=2007326&action=edit The .spec file difference from Copr build 6766549 to 6865550
https://bugzilla.redhat.com/show_bug.cgi?id=2188329
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |AutomationTriaged
--- Comment #40 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6865550 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2188329
--- Comment #41 from Remi Collet fedora@famillecollet.com --- Updated to 1.26.0
Spec URL: https://git.remirepo.net/cgit/rpms/php/phpstan/php-phpstan-phpdoc-parser.git... SRPM URL: https://rpms.remirepo.net/SRPMS/php-phpstan-phpdoc-parser-1.26.0-1.remi.src....
https://bugzilla.redhat.com/show_bug.cgi?id=2188329
--- Comment #42 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 2018868 --> https://bugzilla.redhat.com/attachment.cgi?id=2018868&action=edit The .spec file difference from Copr build 6865550 to 7060913
https://bugzilla.redhat.com/show_bug.cgi?id=2188329
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords|AutomationTriaged |
--- Comment #43 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/7060913 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2188329
--- Comment #44 from Remi Collet fedora@famillecollet.com --- Updated to 1.27.0
Spec URL: https://git.remirepo.net/cgit/rpms/php/phpstan/php-phpstan-phpdoc-parser.git... SRPM URL: https://rpms.remirepo.net/SRPMS/php-phpstan-phpdoc-parser-1.27.0-1.remi.src....
https://bugzilla.redhat.com/show_bug.cgi?id=2188329
--- Comment #45 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 2022936 --> https://bugzilla.redhat.com/attachment.cgi?id=2022936&action=edit The .spec file difference from Copr build 7060913 to 7193233
https://bugzilla.redhat.com/show_bug.cgi?id=2188329
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |AutomationTriaged
--- Comment #46 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/7193233 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2188329
--- Comment #47 from Remi Collet fedora@famillecollet.com --- Updated to 1.28.0
Spec URL: https://git.remirepo.net/cgit/rpms/php/phpstan/php-phpstan-phpdoc-parser.git... SRPM URL: https://rpms.remirepo.net/SRPMS/php-phpstan-phpdoc-parser-1.28.0-1.remi.src....
https://bugzilla.redhat.com/show_bug.cgi?id=2188329
--- Comment #48 from Remi Collet fedora@famillecollet.com --- Updated to 1.29.0
Spec URL: https://git.remirepo.net/cgit/rpms/php/phpstan/php-phpstan-phpdoc-parser.git... SRPM URL: https://rpms.remirepo.net/SRPMS/php-phpstan-phpdoc-parser-1.29.0-1.remi.src....
https://bugzilla.redhat.com/show_bug.cgi?id=2188329
--- Comment #49 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 2032893 --> https://bugzilla.redhat.com/attachment.cgi?id=2032893&action=edit The .spec file difference from Copr build 7193233 to 7437656
https://bugzilla.redhat.com/show_bug.cgi?id=2188329
--- Comment #50 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/7437656 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2188329
--- Comment #51 from Remi Collet fedora@famillecollet.com --- Updated to 1.29.1
Spec URL: https://git.remirepo.net/cgit/rpms/php/phpstan/php-phpstan-phpdoc-parser.git... SRPM URL: https://rpms.remirepo.net/SRPMS/php-phpstan-phpdoc-parser-1.29.1-1.remi.src....
https://bugzilla.redhat.com/show_bug.cgi?id=2188329
--- Comment #52 from Remi Collet fedora@famillecollet.com --- Updated to 1.30.1
Spec URL: https://git.remirepo.net/cgit/rpms/php/phpstan/php-phpstan-phpdoc-parser.git... SRPM URL: https://rpms.remirepo.net/SRPMS/php-phpstan-phpdoc-parser-1.30.0-1.remi.src....
https://bugzilla.redhat.com/show_bug.cgi?id=2188329
--- Comment #53 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 2045034 --> https://bugzilla.redhat.com/attachment.cgi?id=2045034&action=edit The .spec file difference from Copr build 7437656 to 7953290
https://bugzilla.redhat.com/show_bug.cgi?id=2188329
--- Comment #54 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/7953290 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2188329
--- Comment #55 from Remi Collet fedora@famillecollet.com --- Updated to 1.30.1
Spec URL: https://git.remirepo.net/cgit/rpms/php/phpstan/php-phpstan-phpdoc-parser.git... SRPM URL: https://rpms.remirepo.net/SRPMS/php-phpstan-phpdoc-parser-1.30.1-1.remi.src....
https://bugzilla.redhat.com/show_bug.cgi?id=2188329
--- Comment #56 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 2046432 --> https://bugzilla.redhat.com/attachment.cgi?id=2046432&action=edit The .spec file difference from Copr build 7953290 to 8010356
https://bugzilla.redhat.com/show_bug.cgi?id=2188329
--- Comment #57 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/8010356 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2188329
--- Comment #58 from Remi Collet fedora@famillecollet.com --- Updated to 1.31.0
Spec URL: https://git.remirepo.net/cgit/rpms/php/phpstan/php-phpstan-phpdoc-parser.git... SRPM URL: https://rpms.remirepo.net/SRPMS/php-phpstan-phpdoc-parser-1.31.0-1.remi.src....
https://bugzilla.redhat.com/show_bug.cgi?id=2188329
--- Comment #59 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 2048253 --> https://bugzilla.redhat.com/attachment.cgi?id=2048253&action=edit The .spec file difference from Copr build 8010356 to 8060894
https://bugzilla.redhat.com/show_bug.cgi?id=2188329
--- Comment #60 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/8060894 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2188329
--- Comment #61 from Remi Collet fedora@famillecollet.com --- Updated to 1.32.0
Spec URL: https://git.remirepo.net/cgit/rpms/php/phpstan/php-phpstan-phpdoc-parser.git... SRPM URL: https://rpms.remirepo.net/SRPMS/php-phpstan-phpdoc-parser-1.32.0-1.remi.src....
https://bugzilla.redhat.com/show_bug.cgi?id=2188329
--- Comment #62 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 2048789 --> https://bugzilla.redhat.com/attachment.cgi?id=2048789&action=edit The .spec file difference from Copr build 8060894 to 8073102
https://bugzilla.redhat.com/show_bug.cgi?id=2188329
--- Comment #63 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/8073102 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2188329
--- Comment #64 from Remi Collet fedora@famillecollet.com --- Updated to 1.33.0
Spec URL: https://git.remirepo.net/cgit/rpms/php/phpstan/php-phpstan-phpdoc-parser.git... SRPM URL: https://rpms.remirepo.net/SRPMS/php-phpstan-phpdoc-parser-1.33.0-1.remi.src....
https://bugzilla.redhat.com/show_bug.cgi?id=2188329
Hirotaka Wakabayashi hiwkby@yahoo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |hiwkby@yahoo.com Status|NEW |ASSIGNED CC| |hiwkby@yahoo.com
https://bugzilla.redhat.com/show_bug.cgi?id=2188329
Hirotaka Wakabayashi hiwkby@yahoo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review?
--- Comment #65 from Hirotaka Wakabayashi hiwkby@yahoo.com --- Hello Remi, please check my review.
Issues: - Source package contains another software, abnfgen-0.20 in "tests" directory. The abnfgen-0.20's license is unclear for me. - Invalid-url Source0: 82a311fd3690fb2bf7b64d5c98f912b3dd746140/php-phpstan-phpdoc-parser-1.33.0-82a311f.tgz The upstream removes the "tests" directory from the release archive file. # md5sum rpmbuild/SOURCES/php-phpstan-phpdoc-parser-1.33.0-82a311f.tgz ad9582b67e3a8b1d96391eadce6bae07 rpmbuild/SOURCES/php-phpstan-phpdoc-parser-1.33.0-82a311f.tgz # wget https://github.com/phpstan/phpdoc-parser/archive/refs/tags/1.33.0.tar.gz && md5sum 1.33.0.tar.gz a58421ab796b7d02f48f61cb7c159b07 1.33.0.tar.gz - Tests are included in php-phpstan-phpdoc-parser-1.33.0-82a311f.tgz but are not run in %check. If you do not think it is practical to run tests, you can use 1.33.0.tar.gz instead.
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [?]: License field in the package spec file matches the actual license. /home/mockbuilder/2188329-php-phpstan-phpdoc-parser/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [?]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 9141 bytes in 3 files. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. 2.0.x exists but is 1.33.x is the latest version of 1.x. [x]: Package does not include license text files separate from upstream. [!]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
PHP: [x]: Run phpci static analyze on all php files. Note: 7.1.4@9875282 static analyze results in /home/mockbuilder/2188329-php-phpstan-phpdoc-parser/phpci.log
Rpmlint ------- Checking: php-phpstan-phpdoc-parser-1.33.0-1.fc42.noarch.rpm php-phpstan-phpdoc-parser-1.33.0-1.fc42.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpno3g6a9m')] checks: 32, packages: 2
php-phpstan-phpdoc-parser.noarch: E: spelling-error ('nullable', 'Summary(en_US) nullable -> null able, null-able, callable') php-phpstan-phpdoc-parser.src: E: spelling-error ('nullable', 'Summary(en_US) nullable -> null able, null-able, callable') php-phpstan-phpdoc-parser.spec: W: invalid-url Source0: 82a311fd3690fb2bf7b64d5c98f912b3dd746140/php-phpstan-phpdoc-parser-1.33.0-82a311f.tgz 2 packages and 0 specfiles checked; 2 errors, 1 warnings, 7 filtered, 2 badness; has taken 0.4 s
Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1
php-phpstan-phpdoc-parser.noarch: E: spelling-error ('nullable', 'Summary(en_US) nullable -> null able, null-able, callable') 1 packages and 0 specfiles checked; 1 errors, 0 warnings, 3 filtered, 1 badness; has taken 0.1 s
Requires -------- php-phpstan-phpdoc-parser (rpmlib, GLIBC filtered): php(language) php-composer(fedora/autoloader) php-json php-pcre
Provides -------- php-phpstan-phpdoc-parser: php-composer(phpstan/phpdoc-parser) php-phpstan-phpdoc-parser
Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2188329 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, PHP Disabled plugins: Haskell, Python, Ocaml, R, SugarActivity, Java, Perl, C/C++, fonts Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
https://bugzilla.redhat.com/show_bug.cgi?id=2188329
--- Comment #66 from Remi Collet fedora@famillecollet.com --- Thanks for the review
Tests are included in php-phpstan-phpdoc-parser-1.33.0-82a311f.tgz but are not run in %check. If you do not think it is practical to run tests, you can use 1.33.0.tar.gz instead.
Test are run in %check
So I choose to remove abnfgen from generated archive https://git.remirepo.net/cgit/rpms/php/phpstan/php-phpstan-phpdoc-parser.git...
I also switched spec license from CC-BY-SA-4.0 (only allowed for content in new Guidelines), by CECILL-1.2 (allowed for code), which is a global change in progress for all my packages.
Spec URL: https://git.remirepo.net/cgit/rpms/php/phpstan/php-phpstan-phpdoc-parser.git... SRPM URL: https://rpms.remirepo.net/SRPMS/php-phpstan-phpdoc-parser-1.33.0-2.remi.src....
https://bugzilla.redhat.com/show_bug.cgi?id=2188329
--- Comment #67 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 2062826 --> https://bugzilla.redhat.com/attachment.cgi?id=2062826&action=edit The .spec file difference from Copr build 8073102 to 8403055
https://bugzilla.redhat.com/show_bug.cgi?id=2188329
--- Comment #68 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/8403055 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2188329
--- Comment #69 from Remi Collet fedora@famillecollet.com --- (In reply to Hirotaka Wakabayashi from comment #65)
Hello Remi, please check my review.
Anything still blocking the review ?
https://bugzilla.redhat.com/show_bug.cgi?id=2188329
Hirotaka Wakabayashi hiwkby@yahoo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #70 from Hirotaka Wakabayashi hiwkby@yahoo.com --- Hello, Remi. Sorry for my late response. Thanks for the update. Package approved.
https://bugzilla.redhat.com/show_bug.cgi?id=2188329
Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RELEASE_PENDING
--- Comment #71 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/php-phpstan-phpdoc-parser
https://bugzilla.redhat.com/show_bug.cgi?id=2188329
--- Comment #72 from Remi Collet fedora@famillecollet.com --- Thanks!
Notice: version 2.0.0 is available, but version 1.x is needed php-phpdocumentor-type-resolver1 new version
SCM Requests: https://pagure.io/releng/fedora-scm-requests/issue/71018 https://pagure.io/releng/fedora-scm-requests/issue/71019
https://bugzilla.redhat.com/show_bug.cgi?id=2188329
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RELEASE_PENDING |MODIFIED
--- Comment #73 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-5f5512c767 (php-phpstan-phpdoc-parser-1.33.0-2.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-5f5512c767
https://bugzilla.redhat.com/show_bug.cgi?id=2188329
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #74 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-5f5512c767 has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-5f5512c767 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-5f5512c767
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2188329
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2025-01-01 01:23:10
--- Comment #75 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-5f5512c767 (php-phpstan-phpdoc-parser-2.0.0-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org