https://bugzilla.redhat.com/show_bug.cgi?id=1548142

Lubomir Rintel lkundrak@v3.sk changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |lkundrak@v3.sk

--- Comment #1 from Lubomir Rintel lkundrak@v3.sk --- 0.) Please remove a useless comment:

# procedure for package renaming is https://fedoraproject.org/wiki/Package_Renaming_Process

1.) Please drop the useless macro:

%global source_name firefox-pkcs11-loader

Use %{name} in place of %{source_name}

2.) Don't mix tabs and spaces:

# old name was firefox-esteidpkcs11loader Obsoletes: firefox-esteidpkcs11loader

^^^^^^^^^^^^^^ Please replace this with spaces.

3.) Please use macros consistentlt:

%dir %{_prefix}/lib/mozilla/pkcs11-modules/ %_prefix/lib/mozilla/pkcs11-modules/onepinopenscpkcs11.json

^^^^^^^^ %{_prefix} here

4.) Missing dependency on firefox-filesystem

You install files into %{_prefix}/lib/mozilla and %{_datadir}/mozilla/extensions that are owned by it

5.) Summary is too long

Summary: Helper script for Firefox that sets up the browser for authentication with Estonian ID-card

And doesn't seem to make sense -- what package ships is not a script. A better choice would be something like: "Estonian ID-card authentication support for Firefox"

https://bugzilla.redhat.com/show_bug.cgi?id=1548142

--- Comment #2 from Germano Massullo germano.massullo@gmail.com --- (In reply to Lubomir Rintel from comment #1)

0.) Please remove a useless comment:

...

# procedure for package renaming is https://fedoraproject.org/wiki/Package_Renaming_Process

Done

1.) Please drop the useless macro:

...

%global source_name firefox-pkcs11-loader

Use %{name} in place of %{source_name}

Done

2.) Don't mix tabs and spaces:

...

# old name was firefox-esteidpkcs11loader Obsoletes: firefox-esteidpkcs11loader

        ^^^^^^^^^^^^^^
        Please replace this with spaces.

Done

3.) Please use macros consistentlt:

...

%dir %{_prefix}/lib/mozilla/pkcs11-modules/ %_prefix/lib/mozilla/pkcs11-modules/onepinopenscpkcs11.json

^^^^^^^^ %{_prefix} here

Done

4.) Missing dependency on firefox-filesystem

You install files into %{_prefix}/lib/mozilla and %{_datadir}/mozilla/extensions that are owned by it

Done

5.) Summary is too long

...

Summary: Helper script for Firefox that sets up the browser for authentication with Estonian ID-card

There is no requirement for 80 char length on summary, there is only on description https://fedoraproject.org/wiki/Packaging:Guidelines#Summary_and_description

And doesn't seem to make sense -- what package ships is not a script. A better choice would be something like: "Estonian ID-card authentication support for Firefox"

it is the same description from upstream https://github.com/open-eid/firefox-pkcs11-loader and it is a package that installs a JSON and an extension that configures Firefox to correctly handle PKCS11. This configuration is required to use correctly the card, but you could also configure manually Firefox instead of installing this package

https://bugzilla.redhat.com/show_bug.cgi?id=1548142

--- Comment #4 from Gwyn Ciesla limburgher@gmail.com --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/firefox-pkcs11-loader

https://bugzilla.redhat.com/show_bug.cgi?id=1548142

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |MODIFIED