[Bug 2314328] New: Review Request: rust-relm4-css - Idiomatic GUI library inspired by Elm and based on gtk4-rs
https://bugzilla.redhat.com/show_bug.cgi?id=2314328
Bug ID: 2314328 Summary: Review Request: rust-relm4-css - Idiomatic GUI library inspired by Elm and based on gtk4-rs Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: jonathansteffan@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://jsteffan.fedorapeople.org/envision/rust-relm4-css.spec SRPM URL: https://jsteffan.fedorapeople.org/envision/rust-relm4-css-0.9.0-1.fc40/rust-... Description: Idiomatic GUI library inspired by Elm and based on gtk4-rs Fedora Account System Username: jsteffan
https://bugzilla.redhat.com/show_bug.cgi?id=2314328
Jonathan Steffan jonathansteffan@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2292541
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2292541 [Bug 2292541] Review Request: envision - UI for building, configuring, and running Monado/WiVRn
https://bugzilla.redhat.com/show_bug.cgi?id=2314328
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://crates.io/crates/re | |lm4-css
--- Comment #1 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/8062791 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Found issues:
- License file LICENSE-APACHE is not marked as %license Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuideline...
Please know that there can be false-positives.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2314328
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value CC| |decathorpe@gmail.com Assignee|nobody@fedoraproject.org |decathorpe@gmail.com Flags| |fedora-review? Status|NEW |ASSIGNED
--- Comment #2 from Fabio Valentini decathorpe@gmail.com --- Looks like you forgot to replace
``` # FIXME: no license files detected %doc %{crate_instdir}/README.md %{crate_instdir}/ ```
with
``` %license %{crate_instdir}/LICENSE-APACHE %license %{crate_instdir}/LICENSE-MIT %doc %{crate_instdir}/README.md %{crate_instdir}/ ```
?
https://bugzilla.redhat.com/show_bug.cgi?id=2314328
--- Comment #3 from Jonathan Steffan jonathansteffan@gmail.com --- Sure did. Updated.
Spec URL: https://jsteffan.fedorapeople.org/envision/rust-relm4-css.spec SRPM URL: https://jsteffan.fedorapeople.org/envision/rust-relm4-css-0.9.0-1.fc40/rust-...
https://bugzilla.redhat.com/show_bug.cgi?id=2314328
--- Comment #4 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 2048378 --> https://bugzilla.redhat.com/attachment.cgi?id=2048378&action=edit The .spec file difference from Copr build 8062791 to 8062985
https://bugzilla.redhat.com/show_bug.cgi?id=2314328
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |AutomationTriaged
--- Comment #5 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/8062985 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2314328
--- Comment #6 from Fabio Valentini decathorpe@gmail.com --- Package was generated with rust2rpm, simplifying the review.
✅ package contains only permissible content ✅ package builds and installs without errors on rawhide 🫤 test suite is run and all unit tests pass (there are no tests) ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora 🫤 license files are included with %license in %files (temporarily manually included from upstream) ✅ package complies with Rust Packaging Guidelines
Package APPROVED.
===
Recommended post-import rust-sig tasks:
- set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version (*NOT* pre-release) filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate
- add @rust-sig with "commit" access as package co-maintainer (should happen automatically)
- set bugzilla assignee overrides to @rust-sig (optional)
- track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer)
https://bugzilla.redhat.com/show_bug.cgi?id=2314328
Jonathan Steffan jonathansteffan@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
https://bugzilla.redhat.com/show_bug.cgi?id=2314328
Jonathan Steffan jonathansteffan@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review+ |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=2314328
Jonathan Steffan jonathansteffan@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(decathorpe@gmail. | |com)
https://bugzilla.redhat.com/show_bug.cgi?id=2314328
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ |needinfo?(decathorpe@gmail. | |com) |
--- Comment #7 from Fabio Valentini decathorpe@gmail.com --- Sorry, forgot to set the fedora-review+ flag.
https://bugzilla.redhat.com/show_bug.cgi?id=2314328
Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RELEASE_PENDING
--- Comment #8 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-relm4-css
https://bugzilla.redhat.com/show_bug.cgi?id=2314328
Jonathan Steffan jonathansteffan@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RELEASE_PENDING |CLOSED Resolution|--- |RAWHIDE Last Closed| |2024-10-05 14:20:21
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com