[Bug 2316689] New: Review Request: rust-actix-cors - Cross-Origin Resource Sharing (CORS) controls for Actix Web
https://bugzilla.redhat.com/show_bug.cgi?id=2316689
Bug ID: 2316689 Summary: Review Request: rust-actix-cors - Cross-Origin Resource Sharing (CORS) controls for Actix Web Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: davide@cavalca.name QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://dcavalca.fedorapeople.org/review/rust-actix-cors/rust-actix-cors.spe... SRPM URL: https://dcavalca.fedorapeople.org/review/rust-actix-cors/rust-actix-cors-0.7...
Description: Cross-Origin Resource Sharing (CORS) controls for Actix Web.
Fedora Account System Username: dcavalca
https://bugzilla.redhat.com/show_bug.cgi?id=2316689
--- Comment #1 from Davide Cavalca davide@cavalca.name --- This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=124420228
https://bugzilla.redhat.com/show_bug.cgi?id=2316689
Davide Cavalca davide@cavalca.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value
--- Comment #2 from Davide Cavalca davide@cavalca.name --- $ cat rust2rpm.toml [scripts] # Fails to build prep.pre = ["rm examples/cors.rs"]
[tests] run = ["none"] comments = ["Tests fail to build"]
https://bugzilla.redhat.com/show_bug.cgi?id=2316689
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://crates.io/crates/ac | |tix-cors Keywords| |AutomationTriaged
--- Comment #3 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/8110341 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2316689
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |decathorpe@gmail.com Assignee|nobody@fedoraproject.org |decathorpe@gmail.com Status|NEW |ASSIGNED Flags| |fedora-review?
--- Comment #4 from Fabio Valentini decathorpe@gmail.com --- The tests are easy to fix, it's just missing dependencies. Not sure how upstream handles this ...
```patch diff --git a/Cargo.toml b/Cargo.toml index b81c8ae..098ce49 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -62,5 +62,16 @@ version = "1" [dependencies.smallvec] version = "1"
+[dev-dependencies.actix-web] +version = "4" +default-features = false +features = ["macros"] + +[dev-dependencies.env_logger] +version = "0.11" + +[dev-dependencies.regex] +version = "1" + [features] draft-private-network-access = [] ```
https://bugzilla.redhat.com/show_bug.cgi?id=2316689
otiscavin otiscavin3@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |otiscavin3@gmail.com
--- Comment #5 from otiscavin otiscavin3@gmail.com --- (In reply to Davide Cavalca from comment #0)
Spec URL: https://dcavalca.fedorapeople.org/review/rust-actix-cors/rust-actix-cors.spe... SRPM URL: https://dcavalca.fedorapeople.org/review/rust-actix-cors/rust-actix-cors-0.7. https://incrediboxsprunki.org/ 0-1.fc42.src.rpm
Description: Cross-Origin Resource Sharing (CORS) controls for Actix Web.
Fedora Account System Username: dcavalca
Below is an example review request you might find useful for submitting feedback or understanding the library’s capabilities.
https://bugzilla.redhat.com/show_bug.cgi?id=2316689
Lore Theofilo ijakoofiromsaa@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |ijakoofiromsaa@gmail.com
--- Comment #6 from Lore Theofilo ijakoofiromsaa@gmail.com --- I receive error [E0599]: no function or associated object named new found for struct Cors in the current scope.
Use Cors::default() and checkout actual docs docs.rs/actix-cors/0.5.4/actix_cors/struct.Cors.htm
add origins multiple times: https://copr.fedorainfracloud.org/coprs/build/8110341 https://retrobowlonline.co
https://bugzilla.redhat.com/show_bug.cgi?id=2316689
Jack hughjac1991@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |hughjac1991@gmail.com
--- Comment #8 from Jack hughjac1991@gmail.com --- https://flappybirdgame.org ’s simple yet attractive gameplay challenges your reflexes and concentration. Let's play and see how high you can score! The more you play, the better you’ll master those tricky pipes.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com