https://bugzilla.redhat.com/show_bug.cgi?id=2031583

Fabio Alessandro Locati me@fale.io changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |me@fale.io

--- Comment #1 from Fabio Alessandro Locati me@fale.io --- I do not see version 2.1.3 from upstream, the latest I see is 2.1.2.

I would suggest basing this package on the latest commit, since the tagged version is of the previous path

https://bugzilla.redhat.com/show_bug.cgi?id=2031583

Robert-André Mauchin 🐧 zebob.m@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Status|NEW |ASSIGNED Flags| |fedora-review? | |needinfo?(mike@flyn.org) CC| |zebob.m@gmail.com

--- Comment #3 from Robert-André Mauchin 🐧 zebob.m@gmail.com --- - Version 2.1.3 doesn't exist anymore, just go with 2.1.2

- the patch is not needed, just fix the import path of the fork:

sed -i "s|github.com/nicksnyder/go-i18n|github.com/gohugoio/go-i18n|" $(find . -iname "*.go" -type f)

- a test fails with a recent version of Go, it has been fixed upstream, let's backport the patch :

# https://github.com/gohugoio/hugo/issues/11336 Patch: https://github.com/nicksnyder/go-i18n/commit/dadad2bdb2a713748df0717eddd5449...

I sent a bug report upstream for them to backport the upstream changes.

- update the spec with latest go2rpm + fix some stuff:

# Generated by go2rpm 1.9.0 %bcond_without check %global debug_package %{nil}

# https://github.com/gohugoio/go-i18n %global goipath github.com/gohugoio/go-i18n Version: 2.1.2

%gometa -f

%global common_description %{expand: A Go package and a command that helps you translate Go programs into multiple languages.}

%global golicenses LICENSE

Name: %{goname} Release: %autorelease Summary: Go tools for translating Go programs into multiple languages

License: MIT URL: %{gourl} Source0: %{gosource} # https://github.com/gohugoio/hugo/issues/11336 Patch: https://github.com/nicksnyder/go-i18n/commit/dadad2bdb2a713748df0717eddd5449...

%description %{common_description}

%gopkg

%prep %goprep %autopatch -p1 sed -i "s|github.com/nicksnyder/go-i18n|github.com/gohugoio/go-i18n|" $(find . -iname "*.go" -type f)

%generate_buildrequires %go_generate_buildrequires

%install %gopkginstall

%check %gocheck

%gopkgfiles

%changelog %autochangelog

The following review was conducted on my update:

- License ok - Latest version packaged - Builds in mock - Checks pass - No rpmlint errors - Conforms to Go Packaging Guidelines

Please check what I said above and I'll approve.

Product: Fedora Version: rawhide Component: Package Review

W. Michael Petullo mike@flyn.org has canceled Package Review package-review@lists.fedoraproject.org's request for W. Michael Petullo mike@flyn.org's needinfo: Bug 2031583: Review Request: golang-github-gohugoio-go-i18n - Go tools for translating Go programs into multiple languages https://bugzilla.redhat.com/show_bug.cgi?id=2031583

--- Comment #5 from W. Michael Petullo mike@flyn.org --- Spec URL: https://www.flyn.org/SRPMS/golang-github-gohugoio-i18n.spec SRPM URL: https://www.flyn.org/SRPMS/golang-github-gohugoio-i18n-2.1.2-1.fc38.src.rpm Description: A Go package and a command that helps you translate Go programs into multiple languages.

This package is required to build the recent releases of Hugo.

Fedora Account System Username: mikep

This revision uses the specification file from comment #4, except I dropped the commit definition to use the tag tarball.

https://bugzilla.redhat.com/show_bug.cgi?id=2031583

W. Michael Petullo mike@flyn.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|ASSIGNED |CLOSED Last Closed| |2024-08-11 20:24:32

--- Comment #7 from W. Michael Petullo mike@flyn.org --- I have been patching Hugo to use github.com/nicksnyder/go-i18n instead of using the version I proposed here. I have not seen a reunification of the gohugoio and nicksnyder versions. See https://github.com/nicksnyder/go-i18n/pull/253.