Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=814804
--- Comment #3 from Richard Shaw <hobbes1069(a)gmail.com> 2012-04-25 09:03:05 EDT ---
(In reply to comment #2)
It doesn't seem to build in koji. Scratch builds for both F17 and
rawhide fail
with a self test error:
> The following tests FAILED:
> 1 - ocio_core_tests (Failed)
http://koji.fedoraproject.org/koji/taskinfo?taskID=4020499
I'll have to take a look. I'm not sure if all tests are expected to pass yet
for all platforms...
> Patch0: OpenColorIO-1.0.7-pylib_no_soname.patch
> Patch1: OpenColorIO-1.0.7-docfix.patch
Have you sent these changes upstream?
Yes. I've been pretty active with upstream.
The first patch rips out the code that sets the SOVERSION for the
shared
object; why is such a change needed? Would be great to have a comment
explaining this in the spec file.
I can add a comment but basically since it's a python module it should not have
a soanme. I'm not sure where or if that's stated in the guidelines. I based
this on the fact that none of the other python modules in site-packages seem to
have a soname.
We decided on a different approach for a permanent fix. In the commit I sent
upstream, there's a cmake option to either set or not set the soname for the
python module.
Patch1 has already been accepted upstream.
> %files
> [...]
> %{_datadir}/ocio/setup_ocio.sh
Should own the directory as well, to avoid leaving behind unowned directories
when uninstalling the package.
Whoops! Good catch.
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.