Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=506581

Christian Krause chkr@plauener.de changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |chkr@plauener.de AssignedTo|nobody@fedoraproject.org |chkr@plauener.de Flag| |fedora-review?

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=506581

--- Comment #2 from Yanko Kaneti yaneti@declera.com 2009-06-27 06:41:07 EDT --- (In reply to comment #1)

I've reviewed the package and it looks quite good. There are only minor TODOs:

• clarification about the license (I've sent a mail to fedora-legal.)

• License: TODO

• Although the meaning of the license seems to match the BSD license, I'm not

100% sure its a real BSD license since the wording is different. Just to confirm I've asked on the fedora-legal list for confirmation.

Thanks. I've only looked cursory on the licence because frankly licenses make me queasy. If its not really an acceptable BSD like license then so be it.

• description formatting

• %description: TODO (minor)

• I would reformat the last sentence in the %description section to use up the

available space of 80 charaters.

done that

• functional test

• functional test: TODO

• running it on the same machine as the X server did not work well:
  • started "xscope -v1"
  • started "DISPLAY=:1 gedit" in another console
  • xscope displays some X11 protocol communication
  • but gedit doesn't start up completly, X server + xscope + gedit hangs, it

is necessary to kill xscope by logging in via ssh...

• probably it is just wrong usage - any hints welcome ;-)

Indeed the lockup you describe happens here too. In fact every time when the output of xscope itself is running over a terminal on the same server. Don't really know what to make of it. :/ . The program itslef is in a half baked state, and I am not sure it even understands the whole range of todays X server traffic but at least I've managed to succesfully use the package by redirecting the output to file or running vie another machine. It was all an attempt to debug some X slownes over ssh links. I've got the needed capture, don't know enough of X to say if its useful or not.

• package builds correctly in koji for F12 and F11, but failed for F10

I've added a patch to lower the xorg-macros requirement a bit, I don't think it has any detrimental effect on the F10 build. This fixes the build on F10.

* Sun Jun 27 2009 Yanko Kaneti yaneti@declera.com 1.1-2.gitfccbbd6 - Implement review feedback - Patch to build on Fedora 10

SPEC: http://www.declera.com/~yaneti/xscope/xscope.spec SRPM: http://www.declera.com/~yaneti/xscope/xscope-1.1-2.gitfccbbd6.fc12.src.rpm

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=506581

Christian Krause chkr@plauener.de changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+

--- Comment #4 from Christian Krause chkr@plauener.de 2009-06-29 19:21:30 EDT --- (In reply to comment #3)

• Sun Jun 28 2009 Yanko Kaneti yaneti@declera.com 1.1-3.gitfccbbd6

• The software has a MIT not BSD license

SPEC: http://www.declera.com/~yaneti/xscope/xscope.spec SRPM: http://www.declera.com/~yaneti/xscope/xscope-1.1-3.gitfccbbd6.fc12.src.rpm

Thank you very much for the update.

All mentioned issues were addressed:

* License: OK - got clarification from the fedora-legal mailing list: https://www.redhat.com/archives/fedora-legal-list/2009-June/msg00045.html - License is MIT according to the COPYING file - License of source files matches actual license (I've roughly scanned over the sources...) - MIT acceptable for Fedora - COPYING file packaged

* %description: OK

* compilation: OK - package builds now fine in F10

The small problem that it is not possible let the program put its output in an xterm running on the same X-server which is used to connect the clients I would not consider as a major problem. This tool is for debugging anyway and since e.g. logging into a file works fine on the same machine this issue will not hold back the approval.

-> APPROVED

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=506581

Jason Tibbitts tibbs@math.uh.edu changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+

--- Comment #6 from Jason Tibbitts tibbs@math.uh.edu 2009-06-30 22:36:18 EDT --- CVS done.