Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=502689
--- Comment #6 from Kalev Lember <kalev(a)smartlink.ee> 2009-08-19 09:53:53 EDT ---
Fedora review mingw32-cppunit-1.12.1-2.fc11.src.rpm 2009-08-19
+ OK
! needs attention
+ rpmlint is quiet
+ Package is named according to Fedora MinGW packaging guidelines
+ Specfile name matches the package base name
+ Package follows the Fedora MinGW packaging guidelines
+ The stated license (LGPLv2+) is a Fedora approved license
+ The stated license is the same as the one for the corresponding
Fedora package
+ The package contains the license file (COPYING)
+ Spec file is written in American English
+ Spec file is legible
+ Upstream sources match sources in the srpm
bd30e9cf5523cdfc019b94f5e1d7fd19 cppunit-1.12.1.tar.gz
bd30e9cf5523cdfc019b94f5e1d7fd19 Download/cppunit-1.12.1.tar.gz
+ Package builds in mock (Fedora Rawhide i386)
n/a ExcludeArch bugs filed
+ BuildRequires look sane
n/a The spec file MUST handle locales properly
n/a binary RPM with shared library files must call ldconfig in %post and
%postun
+ Does not use Prefix: /usr
+ Package owns all directories it creates
+ No duplicate files in %files
+ %files has %defattr
+ %clean contains rm -rf $RPM_BUILD_ROOT
+ Consistent use of macros
+ Package must contain code or permissible content
n/a Large documentation files should go in -doc subpackage
+ Files marked %doc should not affect package
n/a Header files should be in -devel
Fedora MinGW guidelines allow headers in main package
n/a Static libraries should be in -static
! Packages containing pkgconfig (.pc) files need 'Requires: pkgconfig'
n/a Library files that end in .so must go in a -devel package
n/a -devel must require the fully versioned base
n/a Packages should not contain libtool .la files
Fedora MinGW guidelines allow .la files
n/a Packages containing GUI apps must include %{name}.desktop file
+ Packages must not own files or directories owned by other packages
+ %install begins with rm -rf $RPM_BUILD_ROOT
+ Filenames must be valid UTF-8
! According to
http://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs
packages must use one of the changelog formats defined in there.
1) Use your real name in the changelog;
2) fix the date of latest entry (it reads Jan 5 right now);
3) remove spaces around your email address.
It should read something like this:
* Mon Jan 5 2009 Nicolas Chauvet <kwizart(a)gmail.com> - 1.12.1-1
Besides the missing Requires: pkgconfig and the problem with changelog entries
the spec file looks good.
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.