Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Module-ExtractUse - Find out what modules are used

https://bugzilla.redhat.com/show_bug.cgi?id=426530

berrange@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO| |426542 nThis| |

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Module-ExtractUse - Find out what modules are used

https://bugzilla.redhat.com/show_bug.cgi?id=426530

------- Additional Comments From berrange@redhat.com 2007-12-21 23:02 EST ------- The test in question has been explicitly disabled by the upstream author:

#!/usr/bin/perl -w use strict; use Test::More skip_all=>'parser is known to not catch those';

So, this skip is expected

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Module-ExtractUse - Find out what modules are used

https://bugzilla.redhat.com/show_bug.cgi?id=426530

panemade@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+

------- Additional Comments From panemade@gmail.com 2007-12-21 23:18 EST ------- Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url afbabdb638d6c37b8dd31adb6544fee4 Module-ExtractUse-0.22.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test outputs t/01_load.................ok t/10_basic................ok t/20_parse_self...........ok t/21_comment..............ok t/22_eval.................ok t/23_universal_require....ok t/80_failing..............skipped all skipped: parser is known to not catch those t/99_pod..................ok t/99_pod_coverage.........ok All tests successful, 1 test skipped. Files=9, Tests=84, 2 wallclock secs ( 1.79 cusr + 0.10 csys = 1.89 CPU)

+ Package perl-Module-ExtractUse-0.22-1.fc9 -> Provides: perl(Module::ExtractUse) perl(Module::ExtractUse::Grammar) perl(Parse::RecDescent::Module::ExtractUse::Grammar) Requires: perl(:MODULE_COMPAT_5.8.8) perl(Carp) perl(Module::ExtractUse::Grammar) perl(Parse::RecDescent) perl(Pod::Strip) perl(strict) perl(vars) perl(version) perl(warnings)

APPROVED.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Module-ExtractUse - Find out what modules are used

https://bugzilla.redhat.com/show_bug.cgi?id=426530

tcallawa@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+

------- Additional Comments From tcallawa@redhat.com 2007-12-22 10:55 EST ------- cvs done.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Module-ExtractUse - Find out what modules are used

https://bugzilla.redhat.com/show_bug.cgi?id=426530

------- Additional Comments From ville.skytta@iki.fi 2007-12-22 16:05 EST ------- FYI, there was already an ongoing (well, kind of stalled I guess) review of this in bug 239193.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Module-ExtractUse - Find out what modules are used

https://bugzilla.redhat.com/show_bug.cgi?id=426530

------- Additional Comments From berrange@redhat.com 2007-12-23 13:24 EST ------- WRT to comment #8, if the original submittor wants to be a co-maintainer they are welcome to add themselves via pkgdb and I will approve it. I have already got the module set to allow cvsextras commit.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=426530

Jason Tibbitts tibbs@math.uh.edu changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+

--- Comment #12 from Jason Tibbitts tibbs@math.uh.edu 2010-06-25 14:35:10 EDT --- CVS done.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=426530

Daniel Berrange berrange@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs+ |fedora-cvs?

--- Comment #14 from Daniel Berrange berrange@redhat.com 2012-03-06 06:44:14 EST --- Package Change Request ====================== Package Name: perl-Module-ExtractUse New Branches: EL-5 Owners: berrange

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=426530

--- Comment #16 from Fedora Update System updates@fedoraproject.org 2012-03-07 09:08:35 EST --- perl-Module-ExtractUse-0.23-4.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/perl-Module-ExtractUse-0.23-4.el5