Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=694568
Toshio Ernie Kuratomi <a.badger(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |a.badger(a)gmail.com
AssignedTo|nobody(a)fedoraproject.org |a.badger(a)gmail.com
Flag| |fedora-review+
--- Comment #1 from Toshio Ernie Kuratomi <a.badger(a)gmail.com> 2011-04-07 12:48:53
EDT ---
* rpmlint:
python-testtools.noarch: W: non-standard-group Unspecified
python-testtools.src: W: non-standard-group Unspecified
python-testtools.src:35: E: files-attr-not-set
python-testtools.src:36: E: files-attr-not-set
These are all from the same source: we need a %defattr(-, root, root, -) line
in %files.
* Name follows Guidelines
* License is good and included
* Spec is legible
* Source matches upstream
* Package builds in koji
* No locale files
* No bundled system libraries
* Not relocatable
* All files and directories are owned
* Macros used consistently
* Code not content
* No large doc
* documentation doesn't affect runtime
* Not a dynamic library
* Not a GUI app
Nit:
It's better to BuildRequires: python2-devel rather than python-devel
As long as you add the %defattr before importing, this is APPROVED.
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.