https://bugzilla.redhat.com/show_bug.cgi?id=2043940
Justin Zobel <justin.zobel(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags| |fedora-review?
--- Comment #4 from Justin Zobel <justin.zobel(a)gmail.com> ---
- Update to the latest version and ensure SRPM is rebuilt, this one has
different spec inside srpm to the one linked
- Release: 1%{dist} should be Release: 1%{?dist}
- Use desktop-file-install to install the .desktop file or
desktop-file-validate to ensure it's validity
- Check with upstream if
/usr/lib64/qt5/qml/org/kde/plasma/private/nanoshell/libplasmananoshellprivateplugin.so
belongs in the main or devel package as it is in the main package currently and
unversioned.
- SRPM/spec file differences:
--- /tmp/8493/2043940-plasma-nano/srpm/plasma-nano.spec 2022-04-15
22:08:58.915203826 +0930
+++ /tmp/8493/2043940-plasma-nano/srpm-unpacked/plasma-nano.spec
2022-01-23 03:24:42.000000000 +1030
@@ -1,5 +1,5 @@
%global kf5_min_version 5.88.0
-%global orig_name org.kde.plasma.nano
+%global kde_name org.kde.plasma.nano
Name: plasma-nano
@@ -58,40 +58,40 @@
# remove unknown tag "stock"
# Issue track :
https://invent.kde.org/plasma/plasma-nano/-/issues/4
-sed -i 's,<icon type="stock">plasma</icon>, ,g'
%{buildroot}%{_kf5_metainfodir}/%{orig_name}.desktoptoolbox.appdata.xml
-%find_lang plasma_shell_%{orig_name} --all-name
+sed -i 's,<icon type="stock">plasma</icon>, ,g'
%{buildroot}%{_kf5_metainfodir}/%{kde_name}.desktoptoolbox.appdata.xml
+%find_lang plasma_shell_%{kde_name} --all-name
%check
-appstream-util validate-relax --nonet
%{buildroot}%{_kf5_metainfodir}/%{orig_name}.desktoptoolbox.appdata.xml
+appstream-util validate-relax --nonet
%{buildroot}%{_kf5_metainfodir}/%{kde_name}.desktoptoolbox.appdata.xml
-%files -f plasma_shell_%{orig_name}.lang
-%{_kf5_metainfodir}/%{orig_name}.desktoptoolbox.appdata.xml
+%files -f plasma_shell_%{kde_name}.lang
+%{_kf5_metainfodir}/%{kde_name}.desktoptoolbox.appdata.xml
%{_kf5_qmldir}/org/kde/plasma/private/nanoshell/libplasmananoshellprivateplugin.so
%{_kf5_qmldir}/org/kde/plasma/private/nanoshell/qml/StartupFeedback.qml
%{_kf5_qmldir}/org/kde/plasma/private/nanoshell/qmldir
-%{_kf5_datadir}/kservices5/plasma-applet-%{orig_name}.desktop
-%{_kf5_datadir}/kservices5/plasma-package-%{orig_name}.desktoptoolbox.desktop
+%{_kf5_datadir}/kservices5/plasma-applet-%{kde_name}.desktop
+%{_kf5_datadir}/kservices5/plasma-package-%{kde_name}.desktoptoolbox.desktop
-%{_kf5_datadir}/plasma/packages/%{orig_name}.desktoptoolbox/contents/ui/DesktopConfigButtons.qml
-%{_kf5_datadir}/plasma/packages/%{orig_name}.desktoptoolbox/contents/ui/ToolBoxRoot.qml
-%{_kf5_datadir}/plasma/packages/%{orig_name}.desktoptoolbox/metadata.desktop
-%{_kf5_datadir}/plasma/packages/%{orig_name}.desktoptoolbox/metadata.json
-%{_kf5_datadir}/plasma/shells/%{orig_name}/contents/applet/AppletError.qml
-%{_kf5_datadir}/plasma/shells/%{orig_name}/contents/applet/CompactApplet.qml
-%{_kf5_datadir}/plasma/shells/%{orig_name}/contents/applet/DefaultCompactRepresentation.qml
-%{_kf5_datadir}/plasma/shells/%{orig_name}/contents/configuration/AppletConfiguration.qml
-%{_kf5_datadir}/plasma/shells/%{orig_name}/contents/configuration/ConfigCategoryDelegate.qml
-%{_kf5_datadir}/plasma/shells/%{orig_name}/contents/configuration/ConfigurationContainmentAppearance.qml
-%{_kf5_datadir}/plasma/shells/%{orig_name}/contents/configuration/ContainmentConfiguration.qml
-%{_kf5_datadir}/plasma/shells/%{orig_name}/contents/defaults
-%{_kf5_datadir}/plasma/shells/%{orig_name}/contents/explorer/AppletDelegate.qml
-%{_kf5_datadir}/plasma/shells/%{orig_name}/contents/explorer/WidgetExplorer.qml
-%{_kf5_datadir}/plasma/shells/%{orig_name}/contents/layout.js
-%{_kf5_datadir}/plasma/shells/%{orig_name}/contents/loader.qml
-%{_kf5_datadir}/plasma/shells/%{orig_name}/contents/views/Desktop.qml
-%{_kf5_datadir}/plasma/shells/%{orig_name}/contents/views/Panel.qml
+%{_kf5_datadir}/plasma/packages/%{kde_name}.desktoptoolbox/contents/ui/DesktopConfigButtons.qml
+%{_kf5_datadir}/plasma/packages/%{kde_name}.desktoptoolbox/contents/ui/ToolBoxRoot.qml
+%{_kf5_datadir}/plasma/packages/%{kde_name}.desktoptoolbox/metadata.desktop
+%{_kf5_datadir}/plasma/packages/%{kde_name}.desktoptoolbox/metadata.json
+%{_kf5_datadir}/plasma/shells/%{kde_name}/contents/applet/AppletError.qml
+%{_kf5_datadir}/plasma/shells/%{kde_name}/contents/applet/CompactApplet.qml
+%{_kf5_datadir}/plasma/shells/%{kde_name}/contents/applet/DefaultCompactRepresentation.qml
+%{_kf5_datadir}/plasma/shells/%{kde_name}/contents/configuration/AppletConfiguration.qml
+%{_kf5_datadir}/plasma/shells/%{kde_name}/contents/configuration/ConfigCategoryDelegate.qml
+%{_kf5_datadir}/plasma/shells/%{kde_name}/contents/configuration/ConfigurationContainmentAppearance.qml
+%{_kf5_datadir}/plasma/shells/%{kde_name}/contents/configuration/ContainmentConfiguration.qml
+%{_kf5_datadir}/plasma/shells/%{kde_name}/contents/defaults
+%{_kf5_datadir}/plasma/shells/%{kde_name}/contents/explorer/AppletDelegate.qml
+%{_kf5_datadir}/plasma/shells/%{kde_name}/contents/explorer/WidgetExplorer.qml
+%{_kf5_datadir}/plasma/shells/%{kde_name}/contents/layout.js
+%{_kf5_datadir}/plasma/shells/%{kde_name}/contents/loader.qml
+%{_kf5_datadir}/plasma/shells/%{kde_name}/contents/views/Desktop.qml
+%{_kf5_datadir}/plasma/shells/%{kde_name}/contents/views/Panel.qml
-%{_kf5_datadir}/plasma/shells/%{orig_name}/metadata.desktop
-%{_kf5_datadir}/plasma/shells/%{orig_name}/metadata.json
+%{_kf5_datadir}/plasma/shells/%{kde_name}/metadata.desktop
+%{_kf5_datadir}/plasma/shells/%{kde_name}/metadata.json
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2043940