[Bug 1913661] New: Review Request: ansible-collection-ktdreyer-koji_ansible - Ansible modules to manage Koji resources
https://bugzilla.redhat.com/show_bug.cgi?id=1913661
Bug ID: 1913661 Summary: Review Request: ansible-collection-ktdreyer-koji_ansible - Ansible modules to manage Koji resources Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: igor.raits@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/ansible-collection-ktdrey... SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/ansible-collection-ktdrey... Description: Ansible modules to manage Koji resources. Fedora Account System Username: ignatenkobrain
https://bugzilla.redhat.com/show_bug.cgi?id=1913661
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |ngompa13@gmail.com Assignee|nobody@fedoraproject.org |ngompa13@gmail.com Doc Type|--- |If docs needed, set a value Flags| |fedora-review?
--- Comment #1 from Neal Gompa ngompa13@gmail.com --- Taking this review.
https://bugzilla.redhat.com/show_bug.cgi?id=1913661
--- Comment #2 from Neal Gompa ngompa13@gmail.com --- The packaging is mostly fine, except for some rpmlint issues, according to fedora-review:
Rpmlint ------- Checking: ansible-collection-ktdreyer-koji_ansible-0.0.389-1.fc34.noarch.rpm ansible-collection-ktdreyer-koji_ansible-0.0.389-1.fc34.src.rpm ansible-collection-ktdreyer-koji_ansible.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/ktdreyer/koji_ansible/plugins/modules/koji_archivetype.py 644 /usr/bin/python ansible-collection-ktdreyer-koji_ansible.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/ktdreyer/koji_ansible/plugins/modules/koji_btype.py 644 /usr/bin/python ansible-collection-ktdreyer-koji_ansible.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/ktdreyer/koji_ansible/plugins/modules/koji_call.py 644 /usr/bin/python ansible-collection-ktdreyer-koji_ansible.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/ktdreyer/koji_ansible/plugins/modules/koji_cg.py 644 /usr/bin/python ansible-collection-ktdreyer-koji_ansible.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/ktdreyer/koji_ansible/plugins/modules/koji_external_repo.py 644 /usr/bin/python ansible-collection-ktdreyer-koji_ansible.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/ktdreyer/koji_ansible/plugins/modules/koji_host.py 644 /usr/bin/python ansible-collection-ktdreyer-koji_ansible.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/ktdreyer/koji_ansible/plugins/modules/koji_tag.py 644 /usr/bin/python ansible-collection-ktdreyer-koji_ansible.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/ktdreyer/koji_ansible/plugins/modules/koji_tag_inheritance.py 644 /usr/bin/python ansible-collection-ktdreyer-koji_ansible.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/ktdreyer/koji_ansible/plugins/modules/koji_tag_packages.py 644 /usr/bin/python ansible-collection-ktdreyer-koji_ansible.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/ktdreyer/koji_ansible/plugins/modules/koji_target.py 644 /usr/bin/python ansible-collection-ktdreyer-koji_ansible.noarch: E: non-executable-script /usr/share/ansible/collections/ansible_collections/ktdreyer/koji_ansible/plugins/modules/koji_user.py 644 /usr/bin/python ansible-collection-ktdreyer-koji_ansible.src: W: unexpanded-macro URL %{ansible_collection_url} ansible-collection-ktdreyer-koji_ansible.src: W: invalid-url URL %{ansible_collection_url} 2 packages and 0 specfiles checked; 11 errors, 2 warnings.
https://bugzilla.redhat.com/show_bug.cgi?id=1913661
--- Comment #3 from Igor Raits igor.raits@gmail.com --- New Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/ansible-collection-ktdrey... New SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/ansible-collection-ktdrey...
https://bugzilla.redhat.com/show_bug.cgi?id=1913661
--- Comment #4 from Igor Raits igor.raits@gmail.com ---
ansible-collection-ktdreyer-koji_ansible.src: W: unexpanded-macro URL %{ansible_collection_url} ansible-collection-ktdreyer-koji_ansible.src: W: invalid-url URL %{ansible_collection_url}
Not something I can fix :) They are part of the ansible.
---
I've fixed others.
https://bugzilla.redhat.com/show_bug.cgi?id=1913661
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED
https://bugzilla.redhat.com/show_bug.cgi?id=1913661
--- Comment #5 from Neal Gompa ngompa13@gmail.com --- (In reply to Igor Raits from comment #4)
ansible-collection-ktdreyer-koji_ansible.src: W: unexpanded-macro URL %{ansible_collection_url} ansible-collection-ktdreyer-koji_ansible.src: W: invalid-url URL %{ansible_collection_url}
Not something I can fix :) They are part of the ansible.
Then don't use that macro and put something useful. File a bug upstream about the broken metadata if that's the cause.
https://bugzilla.redhat.com/show_bug.cgi?id=1913661
--- Comment #6 from Igor Raits igor.raits@gmail.com ---
Then don't use that macro and put something useful. File a bug upstream about the broken metadata if that's the cause.
There is no broken metadata. This macro is defined in Ansible and it works fine as long as you have Ansible installed.
Product: Fedora Version: rawhide Component: Package Review
Neal Gompa ngompa13@gmail.com has canceled Package Review package-review@lists.fedoraproject.org's request for Neal Gompa ngompa13@gmail.com's needinfo: Bug 1913661: Review Request: ansible-collection-ktdreyer-koji_ansible - Ansible modules to manage Koji resources https://bugzilla.redhat.com/show_bug.cgi?id=1913661
--- Comment #8 from Neal Gompa ngompa13@gmail.com ---
BuildRequires: ansible
This needs to be "BuildRequires: ansible-packaging" now.
https://bugzilla.redhat.com/show_bug.cgi?id=1913661
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(ngompa13@gmail.co | |m) |
--- Comment #8 from Neal Gompa ngompa13@gmail.com ---
BuildRequires: ansible
This needs to be "BuildRequires: ansible-packaging" now.
Product: Fedora Version: rawhide Component: Package Review
Neal Gompa ngompa13@gmail.com has canceled Package Review package-review@lists.fedoraproject.org's request for Neal Gompa ngompa13@gmail.com's needinfo: Bug 1913661: Review Request: ansible-collection-ktdreyer-koji_ansible - Ansible modules to manage Koji resources https://bugzilla.redhat.com/show_bug.cgi?id=1913661
--- Comment #10 from Neal Gompa ngompa13@gmail.com --- I'm waiting on the packager...
https://bugzilla.redhat.com/show_bug.cgi?id=1913661
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(ngompa13@gmail.co | |m) |
--- Comment #10 from Neal Gompa ngompa13@gmail.com --- I'm waiting on the packager...
https://bugzilla.redhat.com/show_bug.cgi?id=1913661
--- Comment #11 from Igor Raits igor.raits@gmail.com --- New SPEC: https://ignatenkobrain.fedorapeople.org/for-review/ansible-collection-ktdrey... New SRPM: https://ignatenkobrain.fedorapeople.org/for-review/ansible-collection-ktdrey...
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com