https://bugzilla.redhat.com/show_bug.cgi?id=1245604
Zbigniew Jędrzejewski-Szmek <zbyszek(a)in.waw.pl> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #6 from Zbigniew Jędrzejewski-Szmek <zbyszek(a)in.waw.pl> ---
(In reply to Nikola Forró from comment #4)
(In reply to Zbigniew Jędrzejewski-Szmek from comment #3)
> License file is not installed. Add %license LICENSE
> [
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text].
>
There is no license file in the tarball. It was added to upstream master
branch later, so it will probably be included in the next release.
OK.
> I'm not a vim expert, but comparing the scriptlets with
vim-taglist I see
> that vim-taglist removes the file, but you truncate it... Is this
> intentional?
With rm, rpmlint complains about dangerous command in %postun section.
rpmlint is
quite often wrong. But if your version works, that is fine.
> Who owns %{vimfiles_root}/autoload, %{vimfiles_root}/compiler,
> %{vimfiles_root}/ftdetect, etc? Most likely your package should (co-)own
> those directories.
Those directories are owned by vim-filesystem package, which is "artificial
filesystem" package and it also exists in vim-go's dependency chain, so
vim-go shouldn't co-own them.
Pff, I checked that with repoquery but must have
messed something up.
It is as you say.
(In reply to Vít Ondruch from comment #5)
I would suggest to add .metainfo.xml for Gnome Software [1]. You can
find
inspiration in my vim-command-t package.
Good point, please add the metadata file.
I now filed bugs against other vim plugins to do the same:
https://bugzilla.redhat.com/buglist.cgi?quicksearch=vim%20%22please%20add...
.
- license is
OK
- name is OK
- description is OK
- license file is not present but will be added in next release
- layout is good and all directories have ownership
- spec file is good
- scriptlets are present
- rpmlint only false positive typos
- requires and provides look OK
Package is APPROVED. Please add the metadata file.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component