https://bugzilla.redhat.com/show_bug.cgi?id=2317263
Bug ID: 2317263 Summary: Review Request: rust-proc-macro-error2 - Almost drop-in replacement to panics in proc-macros Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: decathorpe@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://decathorpe.fedorapeople.org/rust-proc-macro-error2.spec SRPM URL: https://decathorpe.fedorapeople.org/rust-proc-macro-error2-2.0.1-1.fc41.src....
Description: Almost drop-in replacement to panics in proc-macros.
Fedora Account System Username: decathorpe
https://bugzilla.redhat.com/show_bug.cgi?id=2317263
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://crates.io/crates/pr | |oc-macro-error2
--- Comment #1 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/8119082 (failed)
Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please make sure the package builds successfully at least for Fedora Rawhide.
- If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2317263 Bug 2317263 depends on bug 2317261, which changed state.
Bug 2317261 Summary: Review Request: rust-proc-macro-error-attr2 - Attribute macro for the proc-macro-error2 crate https://bugzilla.redhat.com/show_bug.cgi?id=2317261
What |Removed |Added ---------------------------------------------------------------------------- Status|RELEASE_PENDING |CLOSED Resolution|--- |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=2317263
wojnilowicz lukasz.wojnilowicz@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |lukasz.wojnilowicz@gmail.co | |m CC| |lukasz.wojnilowicz@gmail.co | |m
--- Comment #2 from wojnilowicz lukasz.wojnilowicz@gmail.com --- ===
Package was generated with rust2rpm, simplifying the review.
✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass (justified not running ok.rs with unavailable test_crate) ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license file is included with %license in %files ✅ package complies with Rust Packaging Guidelines
Package APPROVED.
===
Recommended post-import rust-sig tasks:
- set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate
- add rust-sig with "commit" access as package co-maintainer (should happen automatically)
- set bugzilla assignee overrides to @rust-sig (optional)
- track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer)
===
BTW, if you have time, then please review https://bugzilla.redhat.com/show_bug.cgi?id=2327650
https://bugzilla.redhat.com/show_bug.cgi?id=2317263
--- Comment #3 from Fabio Valentini decathorpe@gmail.com --- Thank you for the review!
https://bugzilla.redhat.com/show_bug.cgi?id=2317263
Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RELEASE_PENDING
--- Comment #4 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-proc-macro-error2
https://bugzilla.redhat.com/show_bug.cgi?id=2317263
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RELEASE_PENDING |MODIFIED
--- Comment #5 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-2f883cf793 (rust-getset-0.1.3-1.fc42 and rust-proc-macro-error2-2.0.1-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2024-2f883cf793
https://bugzilla.redhat.com/show_bug.cgi?id=2317263
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |ERRATA Status|MODIFIED |CLOSED Last Closed| |2024-12-06 13:03:25
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-2f883cf793 (rust-getset-0.1.3-1.fc42 and rust-proc-macro-error2-2.0.1-1.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org