Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: libp11 - a small library for dealing with PKCS#11 tokens
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=245081
------- Additional Comments From bugs.michael(a)gmx.net 2007-06-27 07:52 EST -------
Summary: LibP11 is a library for using PKCS#11 modules
Better is
Summary: Library for using PKCS#11 modules
Repeating the package/software name in the summary is considered
bad taste often, since in many package database interfaces it
usually results in displaying the package %{name} multiple times, e.g.:
libp11 - LibP11 is a library for using PKCS#11 modules
BuildRequires: openssl pkgconfig libtool-ltdl-devel
openssl-devel not openssl
Requires: openssl pkgconfig
A dependency on the openssl shared libs is automatically added by
rpmbuild. If not, then your package doesn't link against openssl
actually, and in that case you should add a comment in the spec file
as why it requires openssl.
The main package does NOT require pkgconfig. The -devel packages should.
%package devel
Summary: LibP11-devel contains the static libraries
and header files for libp11
Better is something like
Summary: Files for developing with %{name}
since -devel packages usually contain files other than
"static libs and headers".
%description devel
Development libraries and header files for libp11.
The summary could be the same. ;)
%configure --prefix=/usr --disable-static
--prefix=/usr is default. See: rpm --eval %configure
%files devel
[...]
%{_libdir}/libp11.la
Better delete the libtool archive or %exclude it. It is not
needed at build/link-time.
%{_libdir}/pkgconfig/*
The -devel package should add "Requires: pkgconfig"
--
Configure bugmail:
https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.