https://bugzilla.redhat.com/show_bug.cgi?id=1974358
Mikel Olasagasti Uranga <mikel(a)olasagasti.info> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
--- Comment #2 from Mikel Olasagasti Uranga <mikel(a)olasagasti.info> ---
Hi Steve,
I took this review, but if David wants to take it, please, feel free.
About the .spec, there are some changes that would be required. This is a fast
diff:
$ diff -u fdr-orig.spec fdr.spec
--- fdr-orig.spec 2021-06-21 21:44:36.065398518 +0200
+++ fdr.spec 2021-06-21 21:42:26.503454084 +0200
@@ -2,19 +2,27 @@
Name: fdr
URL:
https://github.com/oracle/fdr.git
Version: 1.3
-Release: 0%{?dist}
+Release: 1%{?dist}
License: UPL
Source0:
http://people.redhat.com/steved/fdr/%{name}-%{version}.tar.xz
+BuildRequires: gcc
+BuildRequires: make
+BuildRequires: sed
+BuildRequires: systemd-rpm-macros
+Requires: systemd
+
%description
The flight data recorder, a daemon which enables ftrace probes
and harvests the data
%prep
-%setup -q
+%autosetup
%build
-%make_build all
+sed -i -e "s:^CFLAGS.*:CFLAGS = %{optflags}:" Makefile
+%make_build
%install
mkdir -p %{buildroot}/%{_sbindir}
@@ -26,11 +34,20 @@
install -m 644 samples/nfs.logrotate %{buildroot}/%{_datadir}/fdr/samples
mkdir -p %{buildroot}/%{_unitdir}
-install -m 644 fdr.service %{buildroot}/%{_unitdir}
+install -m 644 %{name}.service %{buildroot}/%{_unitdir}/%{name}.service
mkdir -p %{buildroot}/%{_mandir}/man8
install -m 644 fdrd.man %{buildroot}/%{_mandir}/man8
+%post
+%systemd_post %{name}.service
+
+%preun
+%systemd_preun %{name}.service
+
+%postun
+%systemd_postun_with_restart %{name}.service
+
%files
%{_sbindir}/fdrd
%{_unitdir}/fdr.service
@@ -39,10 +56,6 @@
%{_datadir}/fdr/samples/nfs.logrotate
%{_mandir}/man8/*
-%preun
-systemctl stop fdr
-systemctl disable fdr
-
%changelog
* Thu Jun 17 2021 Steve Dickson <steved(a)redhat.com> 1.3-0
- Initial commit
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component