https://bugzilla.redhat.com/show_bug.cgi?id=2318468
Bug ID: 2318468 Summary: Review Request: umu-launcher - Unified launcher for Windows games on Linux Product: Fedora Version: rawhide URL: https://github.com/Open-Wine-Components/umu-launcher Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: farchord@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://farchord.fedorapeople.org/reviews/umu-launcher/umu-launcher.spec SRPM URL: https://farchord.fedorapeople.org/reviews/umu-launcher/umu-launcher-1.1.2-1....
Description: This is a unified launcher for Windows games on Linux. It is essentially a copy of the Steam Runtime Tools and Steam Linux Runtime that Valve uses for Proton, with some modifications made so that it can be used outside of Steam.
https://bugzilla.redhat.com/show_bug.cgi?id=2318468
Steve Cossette farchord@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Comment|0 |updated
--- Comment #0 has been edited ---
Spec URL: https://farchord.fedorapeople.org/reviews/umu-launcher/umu-launcher.spec SRPM URL: https://farchord.fedorapeople.org/reviews/umu-launcher/umu-launcher-1.1.2-1....
Description: This is a unified launcher for Windows games on Linux. It is essentially a copy of the Steam Runtime Tools and Steam Linux Runtime that Valve uses for Proton, with some modifications made so that it can be used outside of Steam.
Fedora Account System Username: farchord
https://bugzilla.redhat.com/show_bug.cgi?id=2318468
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |ngompa13@gmail.com Doc Type|--- |If docs needed, set a value Assignee|nobody@fedoraproject.org |ngompa13@gmail.com Status|NEW |ASSIGNED Flags| |fedora-review?
--- Comment #1 from Neal Gompa ngompa13@gmail.com --- Taking this review.
https://bugzilla.redhat.com/show_bug.cgi?id=2318468
Steve Cossette farchord@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(ngompa13@gmail.co | |m)
https://bugzilla.redhat.com/show_bug.cgi?id=2318468
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |decathorpe@gmail.com
--- Comment #2 from Neal Gompa ngompa13@gmail.com --- Initial spec review:
%define debug_package %{nil}
What's this for? This is an archful package, so it should be able to generate debuginfo properly.
./configure.sh --prefix=/usr
This should be set to "--prefix=%{_prefix}" instead.
There's also weirdness with how this package is built, and I think our build flags aren't making it into the package, particularly with the Rust part.
@Fabio, do you have any idea how to make this work right?
https://bugzilla.redhat.com/show_bug.cgi?id=2318468
--- Comment #3 from Fabio Valentini decathorpe@gmail.com --- - Version 1.1.2 doesn't contain Rust code yet. - The Rust code was added later. - 1.1.4 is the latest version. - The native module written in Rust was added *after* that.
https://bugzilla.redhat.com/show_bug.cgi?id=2318468
--- Comment #4 from Fabio Valentini decathorpe@gmail.com ---
%define debug_package %{nil}
So, yes, this should probably be replaced with "BuildArch: noarch" for now.
https://bugzilla.redhat.com/show_bug.cgi?id=2318468
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(ngompa13@gmail.co | |m) |
https://bugzilla.redhat.com/show_bug.cgi?id=2318468
--- Comment #5 from Steve Cossette farchord@gmail.com --- Spec URL: https://farchord.fedorapeople.org/reviews/umu-launcher/umu-launcher.spec SRPM URL: https://farchord.fedorapeople.org/reviews/umu-launcher/umu-launcher-1.1.4-1....
Updated to 1.1.4, Removed debug packages global var, Set buildarch to noarch
https://bugzilla.redhat.com/show_bug.cgi?id=2318468
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |AutomationTriaged
--- Comment #6 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/8551634 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2318468
--- Comment #7 from Fabio Valentini decathorpe@gmail.com --- I took another look, I hope Neal doesn't mind :)
It looks like making this "noarch" doesn't quite work, likely due to a bug in the upstream Makefiles:
There's a file getting installed to /usr/lib64/python3.13/site-packages/umu (umu_version.json).
%{python3_sitelib}/umu/ %{python3_sitearch}/umu/
This looks like a mistake, that umu_version.json file should probably be in python3_sitelib, not in python3_sitearch.
%{_mandir}/man1/umu.1.gz %{_mandir}/man5/umu.5.gz
Don't list .gz explicitly, use .*
%{_datadir}/steam/compatibilitytools.d/umu-launcher/
Either this package needs to (co?)-own steam/ and steam/compatibilitytools.d/ folders too, or it needs to "Require" the package that contains these. Probably the former, since steam isn't in the main Fedora repos.
https://bugzilla.redhat.com/show_bug.cgi?id=2318468
--- Comment #9 from Steve Cossette farchord@gmail.com --- Spec URL: https://farchord.fedorapeople.org/reviews/umu-launcher/umu-launcher.spec SRPM URL: https://farchord.fedorapeople.org/reviews/umu-launcher/umu-launcher-1.1.4-1....
Cleaned the BRs, removed package's noarch, cleaned up %files a bit
https://bugzilla.redhat.com/show_bug.cgi?id=2318468
--- Comment #11 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 2073739 --> https://bugzilla.redhat.com/attachment.cgi?id=2073739&action=edit The .spec file difference from Copr build 8551634 to 8568357
https://bugzilla.redhat.com/show_bug.cgi?id=2318468
--- Comment #12 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/8568357 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2318468
--- Comment #13 from Steve Cossette farchord@gmail.com --- Spec URL: https://farchord.fedorapeople.org/reviews/umu-launcher/umu-launcher.spec SRPM URL: https://farchord.fedorapeople.org/reviews/umu-launcher/umu-launcher-1.1.4-1....
Put the package back to noarch, waiting for an upstream fix to fix the dangling json file
https://bugzilla.redhat.com/show_bug.cgi?id=2318468
--- Comment #14 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 2073740 --> https://bugzilla.redhat.com/attachment.cgi?id=2073740&action=edit The .spec file difference from Copr build 8568357 to 8568381
https://bugzilla.redhat.com/show_bug.cgi?id=2318468
--- Comment #15 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/8568381 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
package-review@lists.fedoraproject.org