Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=230892
Summary: Review Request: gtk-recordmydesktop - GUI Desktop session recorder with audio and video Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: foolish@guezz.net QAContact: fedora-package-review@redhat.com
Spec URL: http://folk.ntnu.no/sindrb/packages/gtk-recordmydesktop.spec SRPM URL: http://folk.ntnu.no/sindrb/packages/gtk-recordmydesktop-0.3.3.1-1.src.rpm
Description:
Graphical frontend for the recordmydesktop desktop session recorder.
recordMyDesktop is a desktop session recorder for linux that attempts to be easy to use, yet also effective at it's primary task.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gtk-recordmydesktop - GUI Desktop session recorder with audio and video
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=230892
foolish@guezz.net changed:
What |Removed |Added ---------------------------------------------------------------------------- BugsThisDependsOn| |230891
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gtk-recordmydesktop - GUI Desktop session recorder with audio and video
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=230892
wolfy@nobugconsulting.ro changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |wolfy@nobugconsulting.ro Flag| |fedora-review?
------- Additional Comments From wolfy@nobugconsulting.ro 2007-03-05 07:10 EST ------- MUSTFIXes: missing BR gettext,desktop-file-utils
GOOD
- package meets naming guidelines - package meets packaging guidelines - license (GPL ) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream, is latest available version, sha1sum d1ba549ebff68157912b41e332941d84836d1fbb gtk-recordmydesktop-0.3.3.1.tar.g - package compiles on devel (x86_64) [*] - no unnecessary BR - locales properly handled [*] - not relocatable - owns all files/directories that it creates, does not take ownership of foreign files/directories - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for separate -docs - nothing in %doc affects runtime - there are no scriptlets, no static code, no libtool/pkgconfig files
SHOULD: - the package compiles and builds into binary rpms on FC6 and rawhide (tested only on x86_64); generated binary is a noarch so no issues should exist for x86 [*] - the package runs as advertised [*]
[*] after adding the missing BRs
Sindre, please fix the spec adding the missing BRs and I'll reverify/approve the package. As a sidenote, in the future I think it would be a good ideaif you would test your packages using rpmlint and by bulding in mock before submitting them.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gtk-recordmydesktop - GUI Desktop session recorder with audio and video
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=230892
------- Additional Comments From foolish@guezz.net 2007-03-05 17:50 EST ------- Updated
SPEC: http://folk.ntnu.no/sindrb/packages/gtk-recordmydesktop.spec SRPM: http://folk.ntnu.no/sindrb/packages/gtk-recordmydesktop-0.3.3.1-2.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gtk-recordmydesktop - GUI Desktop session recorder with audio and video
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=230892
wolfy@nobugconsulting.ro changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
------- Additional Comments From wolfy@nobugconsulting.ro 2007-03-05 19:24 EST ------- Good, we are almost done. All problems mentioned have been solved. There is one more left: please preserve the timestamps when installing. This can be done by adding INSTALL="{__install} -c -p" either to the %configure line or to the "make install" line.
Additional review bits not touched before - python libs are properly installed (package follows the guidelines from http://fedoraproject.org/wiki/Packaging/Python) - program is a GUI; a desktop file is properly installed for it - the desktop file respects packaging guidelines (no output from desktop-file-validate fedora-gtk-recordmydesktop.desktop)
As I see no further blockers, the package is APPROVED. I'll trust you to fix preserving of timestamps before importing into CVS.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gtk-recordmydesktop - GUI Desktop session recorder with audio and video
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=230892
foolish@guezz.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
------- Additional Comments From foolish@guezz.net 2007-03-06 02:42 EST ------- New Package CVS Request ======================= Package Name: gtk-recordmydesktop Short Description: GUI Desktop session recorder with audio and video Owners: foolish@guezz.net Branches: FC-5 FC-6 InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gtk-recordmydesktop - GUI Desktop session recorder with audio and video
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=230892
wtogami@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gtk-recordmydesktop - GUI Desktop session recorder with audio and video
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=230892
Bug 230892 depends on bug 230891, which changed state.
Bug 230891 Summary: Review Request: recordmydesktop - Desktop session recorder with audio and video https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=230891
What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |NEXTRELEASE Status|ASSIGNED |CLOSED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gtk-recordmydesktop - GUI Desktop session recorder with audio and video
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=230892
foolish@guezz.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=230892
Andy Grover agrover@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |agrover@redhat.com Flag|fedora-cvs+ |fedora-cvs?
--- Comment #5 from Andy Grover agrover@redhat.com 2012-02-07 20:21:26 EST --- Package Change Request ====================== Package Name: gtk-recordmydesktop New Branches: el5 el6 Owners: mbooth narasim grover
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=230892
--- Comment #6 from Jon Ciesla limburgher@gmail.com 2012-02-08 08:04:16 EST --- Git done (by process-git-requests).
package-review@lists.fedoraproject.org