https://bugzilla.redhat.com/show_bug.cgi?id=2174145

Jakub Kadlčík jkadlcik@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- URL| |https://crates.io/crates/bu | |ild-fs-tree

--- Comment #1 from Jakub Kadlčík jkadlcik@redhat.com --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5580129 (failed)

Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field

--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.

https://bugzilla.redhat.com/show_bug.cgi?id=2174145

Michel Alexandre Salim michel@michel-slm.name changed:

What |Removed |Added ---------------------------------------------------------------------------- Depends On| |2174143, 2174144 Doc Type|--- |If docs needed, set a value

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=2174143 [Bug 2174143] Review Request: rust-pipe-trait - Make it possible to chain regular functions https://bugzilla.redhat.com/show_bug.cgi?id=2174144 [Bug 2174144] Review Request: rust-text-block-macros - Create a multiline string literal

https://bugzilla.redhat.com/show_bug.cgi?id=2174145 Bug 2174145 depends on bug 2174144, which changed state.

Bug 2174144 Summary: Review Request: rust-text-block-macros - Create a multiline string literal https://bugzilla.redhat.com/show_bug.cgi?id=2174144

What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |RAWHIDE

https://bugzilla.redhat.com/show_bug.cgi?id=2174145

Fabio Valentini decathorpe@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(michel@michel-slm | |.name)

https://bugzilla.redhat.com/show_bug.cgi?id=2174145

Fabio Valentini decathorpe@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ Status|ASSIGNED |POST

--- Comment #5 from Fabio Valentini decathorpe@gmail.com --- Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide - test suite is run and all unit tests pass ! latest version of the crate is packaged (wax depends on ^0.3) - license matches upstream specification (MIT) and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate

- track package in koschei for all built branches

===

Two comments:

- It would be great if you could poke the project for the "wax" crate to update their dependency, v0.3.1 is quite old. - Please make sure that the removed feature subpackages are correct. For example, I think you could remove the "structopt" subpackage as well.

https://bugzilla.redhat.com/show_bug.cgi?id=2174145

--- Comment #7 from Michel Alexandre Salim michel@michel-slm.name --- Thanks! Filed https://github.com/olson-sean-k/wax/issues/43 asking the wax developer to update. Unfortunately build-fs-tree does not include any changelog so... I'll let them figure it out. There's also been no commit to wax since last August...

https://bugzilla.redhat.com/show_bug.cgi?id=2174145

--- Comment #8 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-43512b4d4f has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-43512b4d4f

https://bugzilla.redhat.com/show_bug.cgi?id=2174145

--- Comment #10 from Fedora Update System updates@fedoraproject.org --- FEDORA-EPEL-2023-49aa6f1164 has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-49aa6f1164

https://bugzilla.redhat.com/show_bug.cgi?id=2174145

--- Comment #12 from Fedora Update System updates@fedoraproject.org --- FEDORA-EPEL-2023-49aa6f1164 has been pushed to the Fedora EPEL 9 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-49aa6f1164

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

https://bugzilla.redhat.com/show_bug.cgi?id=2174145

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Resolution|RAWHIDE |ERRATA

--- Comment #14 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-43512b4d4f has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report.

https://bugzilla.redhat.com/show_bug.cgi?id=2174145

--- Comment #16 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-5187dc9252 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report.