https://bugzilla.redhat.com/show_bug.cgi?id=2237335

Davide Cavalca davide@cavalca.name changed:

What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value Blocks| |2218117 (MultimediaSIG)

--- Comment #2 from Davide Cavalca davide@cavalca.name --- This is based on the rpmfusion package: https://admin.rpmfusion.org/pkgdb/package/free/m2vrequantiser/

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=2218117 [Bug 2218117] Tracker for multimedia-sig

https://bugzilla.redhat.com/show_bug.cgi?id=2237335

Davide Cavalca davide@cavalca.name changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(davide@cavalca.na | |me) |

https://bugzilla.redhat.com/show_bug.cgi?id=2237335

Dominik 'Rathann' Mierzejewski dominik@greysector.net changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+

--- Comment #5 from Dominik 'Rathann' Mierzejewski dominik@greysector.net --- Looks good, APPROVED. Sorry for the delay.

Package Review ==============

Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed

===== MUST items =====

C/C++: [x]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs.

Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GNU General Public License, Version 2", "Unknown or generated", "GNU General Public License v2.0 or later". 11 files have unknown license. Detailed output of licensecheck in /home/rathann/build/review/2237335-m2vrequantiser/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 3234 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM.

Rpmlint ------- Checking: m2vrequantiser-1.1-8.fc42.x86_64.rpm m2vrequantiser-debuginfo-1.1-8.fc42.x86_64.rpm m2vrequantiser-debugsource-1.1-8.fc42.x86_64.rpm m2vrequantiser-1.1-8.fc42.src.rpm ================================================ rpmlint session starts ================================================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp7po5h39l')] checks: 32, packages: 4

m2vrequantiser.src: E: spelling-error ('requantizer', 'Summary(en_US) requantizer -> quantifier, quantize') m2vrequantiser.src: E: spelling-error ('requantize', '%description -l en_US requantize -> re quantize, re-quantize, quantize') m2vrequantiser.src: E: spelling-error ('recompressing', '%description -l en_US recompressing -> decompressing, re compressing, re-compressing') m2vrequantiser.x86_64: E: spelling-error ('requantizer', 'Summary(en_US) requantizer -> quantifier, quantize') m2vrequantiser.x86_64: E: spelling-error ('requantize', '%description -l en_US requantize -> re quantize, re-quantize, quantize') m2vrequantiser.x86_64: E: spelling-error ('recompressing', '%description -l en_US recompressing -> decompressing, re compressing, re-compressing') m2vrequantiser.x86_64: W: no-manual-page-for-binary M2VRequantiser ========== 4 packages and 0 specfiles checked; 6 errors, 1 warnings, 16 filtered, 6 badness; has taken 0.5 s ===========

Rpmlint (debuginfo) ------------------- Checking: m2vrequantiser-debuginfo-1.1-8.fc42.x86_64.rpm ================================================ rpmlint session starts ================================================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp4h_n6ln7')] checks: 32, packages: 1

=========== 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 5 filtered, 0 badness; has taken 0.1 s ===========

Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3

m2vrequantiser.x86_64: E: spelling-error ('requantizer', 'Summary(en_US) requantizer -> quantifier, quantize') m2vrequantiser.x86_64: E: spelling-error ('requantize', '%description -l en_US requantize -> re quantize, re-quantize, quantize') m2vrequantiser.x86_64: E: spelling-error ('recompressing', '%description -l en_US recompressing -> decompressing, re compressing, re-compressing') m2vrequantiser.x86_64: W: no-manual-page-for-binary M2VRequantiser 3 packages and 0 specfiles checked; 3 errors, 1 warnings, 13 filtered, 3 badness; has taken 0.4 s

Source checksums ---------------- https://launchpad.net/m2vrequantiser/trunk/1.1/+download/M2VRequantiser-v1.1... : CHECKSUM(SHA256) this package : e537c7894edc4ae446d71e8f597aa1fcec85c3e76748ba0aaa289cc667c94209 CHECKSUM(SHA256) upstream package : e537c7894edc4ae446d71e8f597aa1fcec85c3e76748ba0aaa289cc667c94209

Requires -------- m2vrequantiser (rpmlib, GLIBC filtered): libc.so.6()(64bit) rtld(GNU_HASH)

m2vrequantiser-debuginfo (rpmlib, GLIBC filtered):

m2vrequantiser-debugsource (rpmlib, GLIBC filtered):

Provides -------- m2vrequantiser: m2vrequantiser m2vrequantiser(x86-64)

m2vrequantiser-debuginfo: debuginfo(build-id) m2vrequantiser-debuginfo m2vrequantiser-debuginfo(x86-64)

m2vrequantiser-debugsource: m2vrequantiser-debugsource m2vrequantiser-debugsource(x86-64)

Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2237335 Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Generic, Shell-api Disabled plugins: Haskell, PHP, Python, SugarActivity, fonts, Ocaml, Perl, Java, R Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH

https://bugzilla.redhat.com/show_bug.cgi?id=2237335

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|RELEASE_PENDING |MODIFIED

--- Comment #7 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-a5683d617b (m2vrequantiser-1.1-10.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-a5683d617b

https://bugzilla.redhat.com/show_bug.cgi?id=2237335

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |ERRATA Status|ON_QA |CLOSED Last Closed| |2024-12-02 07:06:49

--- Comment #9 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-a5683d617b (m2vrequantiser-1.1-10.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.