Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=539387
--- Comment #11 from Peter Lemenkov <lemenkov(a)gmail.com> 2009-12-27 13:27:23 EDT
---
(In reply to comment #8)
* Source0 url should be corrected. See Source1 for example
I'm not quite sure if I get this. Do you want me to remove %name and %version
from Source0 and write directly
http://voxel.dl.sourceforge.net/sourceforge/itk/InsightToolkit-3.16.0.tar.gz ?
For files, stored at SF, you should use something like this:
Source0:
http://downloads.sourceforge.net/itk/%{name}-%{version}.tar.gz
Note, that this URL doesn't have pre-defined mirror site (like yours one have).
* %{_libdir}/%{name}/*.cmake should be placed in devel rather than in
main
package, I believe. Also, I'm not sure this is a correct place to put CMake
files in.
Moved to the devel section. Neither I am sure about their correct position.
Maybe they should be put in cmake config dir?
I suppose so.
* Source1 should be added as %doc in devel-subpackage
First copied to builddir in %prep and then added as %doc. Not sure if this is
the correct way
Not so correct. You should simply copy %{SOURCE1} instead of using full path:
- cp %{_builddir}/../SOURCES/ItkSoftwareGuide-2.4.0.pdf .
+ cp %{SOURCE1} .
* I just found, that ITK contains numerous bundled libraries, many of
them are
duplication Fedora's system ones - see 'Utilities' directory. This should be
fixed (and necessary BuildRequires should be added).
Fixed adding -DUSE_SYSTEM_* to cmake flags. Anyway I didn't find any package
for niether GDCM nor VXL.
To be really sure, you need to remove these directories with duplicated system
libraries, at a %prep stage. And properly patch the rest of the code, if
something will go wrong.
Should I package them as well or can I leave the itk versions for
now?
Ideally, yes. But it's not *MUST*, it's a *SHOULD* rule. So we may simply use
them as-is for now.
I'm looking at at your new spec right now, so more notes to come.
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.