https://bugzilla.redhat.com/show_bug.cgi?id=2107888
Bug ID: 2107888 Summary: Review Request: vale - A syntax-aware, command-line linter for prose Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: mczernek@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://github.com/m-czernek/vale-spec/releases/download/v2.20.0/vale.spec SRPM URL: https://github.com/m-czernek/vale-spec/releases/download/v2.20.0/vale-2.20.0...
Description: I want to package the errata-ai/vale package (https://github.com/errata-ai/vale). Currently, Fedora users can download the RPM from my COPR repository (see official Vale documentation at https://vale.sh/docs/vale-cli/installation/) but I would love to provide this package as part of the standard Fedora repositories
Fedora Account System Username: mczernek
https://bugzilla.redhat.com/show_bug.cgi?id=2107888
Mikel Olasagasti Uranga mikel@olasagasti.info changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mikel@olasagasti.info Assignee|nobody@fedoraproject.org |mikel@olasagasti.info
--- Comment #1 from Mikel Olasagasti Uranga mikel@olasagasti.info --- Hi Marek,
Fedora builds don't have access to Internet, so all the required libraries need to be part of Fedora.
For golang packages this means that the package is unbundled:
"At the moment golang projects packaged in Fedora SHOULD be unbundled by default. It means projects are built from dependencies packaged in Fedora."
https://docs.fedoraproject.org/en-US/packaging-guidelines/Golang/#_bundled_o...
I'll recommend you to use `go2rpm` to create a package and then work on top of that.
$ go2rpm -r github.com/errata-ai/vale
or in case you want to have static BuildRequires:
$ go2rpm -r --no-dynamic-buildrequires github.com/errata-ai/vale
Trying to build the spec generated by go2rpm, the build process reports the following dependencies missing:
No matching package to install: 'golang(github.com/errata-ai/ini)' No matching package to install: 'golang(github.com/errata-ai/regexp2)' No matching package to install: 'golang(github.com/jdkato/regexp)' No matching package to install: 'golang(github.com/jdkato/titlecase)' No matching package to install: 'golang(github.com/pterm/pterm)'
Those should be imported first to Fedora and then go with vale.
The spec generated by go2rpm will need some tweaking, but it's a good start to detect missing dependencies.
https://bugzilla.redhat.com/show_bug.cgi?id=2107888
--- Comment #2 from Marek Czernek mczernek@redhat.com --- Thank you, for the detailed review,
I didn't realize that the COPR and the official Fedora build process are different (makes sense in retrospect).
I'll see what I can do with the missing dependencies.
M.
https://bugzilla.redhat.com/show_bug.cgi?id=2107888
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flags| |fedora-review?
Product: Fedora Version: rawhide Component: Package Review
Mikel Olasagasti Uranga mikel@olasagasti.info has canceled Package Review package-review@lists.fedoraproject.org's request for Mikel Olasagasti Uranga mikel@olasagasti.info's needinfo: Bug 2107888: Review Request: vale - A syntax-aware, command-line linter for prose https://bugzilla.redhat.com/show_bug.cgi?id=2107888
https://bugzilla.redhat.com/show_bug.cgi?id=2107888
Mikel Olasagasti Uranga mikel@olasagasti.info changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(mikel@olasagasti. | |info) |
https://bugzilla.redhat.com/show_bug.cgi?id=2107888
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |ppisar@redhat.com Resolution|--- |WONTFIX Status|NEW |CLOSED Last Closed| |2024-10-24 08:12:09
--- Comment #6 from Petr Pisar ppisar@redhat.com --- An account of the review submitter was close.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com