[Bug 1592426] New: Review Request: perl-Crypt-OpenSSL-Guess - Guess OpenSSL include path
https://bugzilla.redhat.com/show_bug.cgi?id=1592426
Bug ID: 1592426 Summary: Review Request: perl-Crypt-OpenSSL-Guess - Guess OpenSSL include path Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: jplesnik@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://jplesnik.fedorapeople.org/perl-Crypt-OpenSSL-Guess/perl-Crypt-OpenSS... SRPM URL: https://jplesnik.fedorapeople.org/perl-Crypt-OpenSSL-Guess/perl-Crypt-OpenSS...
Description: Crypt::OpenSSL::Guess provides helpers to guess OpenSSL include path on any platforms.
Fedora Account System Username: jplesnik@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=1592426
Jitka Plesnikova jplesnik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1567450
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1567450 [Bug 1567450] perl-Crypt-OpenSSL-Random-0.15 is available
https://bugzilla.redhat.com/show_bug.cgi?id=1592426
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |ppisar@redhat.com Assignee|nobody@fedoraproject.org |ppisar@redhat.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1592426
--- Comment #1 from Petr Pisar ppisar@redhat.com --- Spec files differ. I will use a standalone one for this review.
URL and Source0 addresses are Ok. Source archive (SHA-256: aa6b18e38cb852cbad80a58cd90c395b40819d4d01e0ab37e7703149094d7167) is original. Ok. Summary is Ok. Description is Ok. License verified from lib/Crypt/OpenSSL/Guess.pm, README.md and LICENSE. Ok. No XS code, noarch BuildArch is Ok.
TODO: Recommend or suggest `openssl'. The Perl code executes "openssl" program and without it it's pointless.
All tests pass. Ok.
$ rpmlint perl-Crypt-OpenSSL-Guess.spec ../SRPMS/perl-Crypt-OpenSSL-Guess-0.11-1.fc29.src.rpm ../RPMS/noarch/perl-Crypt-OpenSSL-Guess-0.11-1.fc29.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok.
$ rpm -q -lv -p ../RPMS/noarch/perl-Crypt-OpenSSL-Guess-0.11-1.fc29.noarch.rpm drwxr-xr-x 2 root root 0 Jun 18 17:28 /usr/share/doc/perl-Crypt-OpenSSL-Guess -rw-r--r-- 1 root root 434 Apr 16 05:16 /usr/share/doc/perl-Crypt-OpenSSL-Guess/Changes -rw-r--r-- 1 root root 2557 Apr 16 05:16 /usr/share/doc/perl-Crypt-OpenSSL-Guess/README.md drwxr-xr-x 2 root root 0 Jun 18 17:28 /usr/share/licenses/perl-Crypt-OpenSSL-Guess -rw-r--r-- 1 root root 18412 Apr 16 05:16 /usr/share/licenses/perl-Crypt-OpenSSL-Guess/LICENSE -rw-r--r-- 1 root root 2100 Jun 18 17:28 /usr/share/man/man3/Crypt::OpenSSL::Guess.3pm.gz drwxr-xr-x 2 root root 0 Jun 18 17:28 /usr/share/perl5/vendor_perl/Crypt drwxr-xr-x 2 root root 0 Jun 18 17:28 /usr/share/perl5/vendor_perl/Crypt/OpenSSL -rw-r--r-- 1 root root 7804 Apr 16 05:16 /usr/share/perl5/vendor_perl/Crypt/OpenSSL/Guess.pm File permissions and layout are Ok.
$ rpm -q --requires -p ../RPMS/noarch/perl-Crypt-OpenSSL-Guess-0.11-1.fc29.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.26.2) 1 perl(Exporter) >= 5.57 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 FIX: A typo in __requires_exclude definition (a pipe character out of condition) erroneously filters all autogenerated dependencies.
$ rpm -q --provides -p ../RPMS/noarch/perl-Crypt-OpenSSL-Guess-0.11-1.fc29.noarch.rpm | sort -f | uniq -c 1 perl(Crypt::OpenSSL::Guess) = 0.11 1 perl-Crypt-OpenSSL-Guess = 0.11-1.fc29 Binary provides are Ok.
The package builds in F29 (https://koji.fedoraproject.org/koji/taskinfo?taskID=27704623). Ok.
Otherwise the package is in line with Fedira and Perl packaging guidelines.
Please correct all `FIX' items, consider fixing `TODO' items and provide a new spec file. Resolution: Package NOT approved.
https://bugzilla.redhat.com/show_bug.cgi?id=1592426
--- Comment #2 from Jitka Plesnikova jplesnik@redhat.com --- Updated files are on the same links.
https://bugzilla.redhat.com/show_bug.cgi?id=1592426
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #3 from Petr Pisar ppisar@redhat.com --- Difference in the spec file:
--- perl-Crypt-OpenSSL-Guess.spec.old 2018-06-18 15:55:31.000000000 +0200 +++ perl-Crypt-OpenSSL-Guess.spec 2018-06-19 09:46:46.000000000 +0200 @@ -23,8 +23,9 @@ BuildRequires: perl(Test::More) >= 0.98 Requires: perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version)) Requires: perl(Exporter) >= 5.57 +Recommends: openssl
-%global __requires_exclude %{?__requires_exclude}|perl\(Exporter\)\s*$ +%global __requires_exclude %{?__requires_exclude:%__requires_exclude|}perl\(Exporter\)\s*$
%description Crypt::OpenSSL::Guess provides helpers to guess OpenSSL include path on any
TODO: Recommend or suggest `openssl'. The Perl code executes "openssl" program and without it it's pointless.
Ok.
$ rpmlint perl-Crypt-OpenSSL-Guess.spec ../SRPMS/perl-Crypt-OpenSSL-Guess-0.11-1.fc29.src.rpm ../RPMS/noarch/perl-Crypt-OpenSSL-Guess-0.11-1.fc29.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok.
FIX: A typo in __requires_exclude definition (a pipe character out of condition) erroneously filters all autogenerated dependencies.
$ rpm -q --requires -p ../RPMS/noarch/perl-Crypt-OpenSSL-Guess-0.11-1.fc29.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.26.2) 1 perl(:VERSION) >= 5.8.1 1 perl(Config) 1 perl(Exporter) >= 5.57 1 perl(ExtUtils::MM) 1 perl(File::Spec) 1 perl(strict) 1 perl(Symbol) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok.
$ resolvedeps rawhide ../RPMS/noarch/perl-Crypt-OpenSSL-Guess-0.11-1.fc29.noarch.rpm Binary dependencies resolvable. Ok.
Resolution: Package APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=1592426
--- Comment #4 from Gwyn Ciesla limburgher@gmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Crypt-OpenSSL-Guess
https://bugzilla.redhat.com/show_bug.cgi?id=1592426
Jitka Plesnikova jplesnik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Fixed In Version| |perl-Crypt-OpenSSL-Guess-0. | |11-1.fc29 Resolution|--- |RAWHIDE Last Closed| |2018-06-19 09:24:21
--- Comment #5 from Jitka Plesnikova jplesnik@redhat.com --- Thank you for the review and the repository.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com