https://bugzilla.redhat.com/show_bug.cgi?id=2314532

--- Comment #1 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/8067764 (succeeded)

Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Found issues:

- No gcc, gcc-c++ or clang found in BuildRequires Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/

Please know that there can be false-positives.

--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.

https://bugzilla.redhat.com/show_bug.cgi?id=2314532

--- Comment #3 from Debarshi Ray debarshir@redhat.com --- Updated with virtual Provides.

https://bugzilla.redhat.com/show_bug.cgi?id=2314532

Mikel Olasagasti Uranga mikel@olasagasti.info changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |mikel@olasagasti.info Status|NEW |ASSIGNED Flags| |fedora-review+ Assignee|nobody@fedoraproject.org |mikel@olasagasti.info

--- Comment #5 from Mikel Olasagasti Uranga mikel@olasagasti.info --- Thanks for adding all the comments in the spec, it makes much easier to understand why those extra things are required.

Golang Package Review ==============

This package was generated using go2rpm, which simplifies the review.

Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

- [x] The latest version is packaged or packaging an earlier version is justified. - [x] The License tag reflects the package contents and uses the correct identifiers. - [x] The package builds successfully in mock. - [x] Package is installable (checked by fedora-review). - [x] There are no relevant rpmlint errors. - [x] The package runs tests in %check. - [x] `%goipath` is set correctly. - [x] The package's binaries don't conflict with binaries already in the distribution. (Some Go projects include utility binaries with very generic names) - [x] There are no `%{_bindir}/*` wildcards in %files. (go2rpm includes these by default) - [x] The package does not use `%gometa -f` if it has dependents that still build for %ix86. - [x] The package complies with the Golang and general Packaging Guidelines.

Package approved! On import, don't forget to do the following:

- [ ] Add the package to release-monitoring.org - [ ] Give go-sig privileges (at least commit) on the package - [ ] Close the review bug by referencing its ID in the rpm changelog and the Bodhi ticket. - [ ] Consider configuring Packit service to help with maintenance

Thanks!

https://bugzilla.redhat.com/show_bug.cgi?id=2314532

--- Comment #7 from Debarshi Ray debarshir@redhat.com --- Requested Git repository: https://pagure.io/releng/fedora-scm-requests/issue/68186

Requested Git branches for f41, f40 and f39: https://pagure.io/releng/fedora-scm-requests/issue/68187 https://pagure.io/releng/fedora-scm-requests/issue/68188 https://pagure.io/releng/fedora-scm-requests/issue/68189

https://bugzilla.redhat.com/show_bug.cgi?id=2314532

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|RELEASE_PENDING |MODIFIED

--- Comment #9 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-f8053e1ea4 (golang-github-nvidia-container-toolkit-1.16.1-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-f8053e1ea4

https://bugzilla.redhat.com/show_bug.cgi?id=2314532

--- Comment #11 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-a884b1b0ce (golang-github-nvidia-container-toolkit-1.16.1-1.fc39) has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-a884b1b0ce

https://bugzilla.redhat.com/show_bug.cgi?id=2314532

--- Comment #13 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-f8053e1ea4 has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-f8053e1ea4 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-f8053e1ea4

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

https://bugzilla.redhat.com/show_bug.cgi?id=2314532

--- Comment #15 from Debarshi Ray debarshir@redhat.com --- Added https://github.com/NVIDIA/nvidia-container-toolkit to Anitya: https://release-monitoring.org/project/234913/

... and enabled monitoring in Fedora: https://src.fedoraproject.org/rpms/golang-github-nvidia-container-toolkit

https://bugzilla.redhat.com/show_bug.cgi?id=2314532

--- Comment #17 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-a884b1b0ce (golang-github-nvidia-container-toolkit-1.16.1-1.fc39) has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.