https://bugzilla.redhat.com/show_bug.cgi?id=1576792 Bug 1576792 depends on bug 1576779, which changed state.

Bug 1576779 Summary: Review Request: python3-eventemitter - Tools for working with async events https://bugzilla.redhat.com/show_bug.cgi?id=1576779

What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |WONTFIX

https://bugzilla.redhat.com/show_bug.cgi?id=1576792

--- Comment #1 from Peter Robinson pbrobinson@gmail.com --- Updated:

SPEC: https://pbrobinson.fedorapeople.org/webthing.spec SRPM: https://pbrobinson.fedorapeople.org/webthing-0.5.3-2.fc28.src.rpm

koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=26877182

https://bugzilla.redhat.com/show_bug.cgi?id=1576792

--- Comment #3 from Peter Robinson pbrobinson@gmail.com --- (In reply to Robert-André Mauchin from comment #2)

• Use a more meaningful archive name with:

Source0: https://github.com/mozilla-iot/webthing-python/archive/v%%7Bversion%7D/%%7Bn... %{version}.tar.gz

When I packaged this they weren't there, it was from my request they happened: https://github.com/mozilla-iot/webthing-python/issues/13

• If you only plan to support Fedora >= 28, you could use the new

"%?python_enable_dependency_generator" instead of specifying the Requires manually. See https://fedoraproject.org/wiki/Changes/EnablingPythonGenerators

• Generally we start numbering patch at 0

Actually there's no policy about that, it's up to the packager.

• I think you should name this package python-webthing and provide a Python

3 subpackage. You could use pyp2rpm to help with that: pyp2rpm -b3 webthing

...

python-webthing.spec and then adjust the patch, license, description.

I'm considering that, although I'd use python3-webthing naming because I have no intention of supporting py2

https://bugzilla.redhat.com/show_bug.cgi?id=1576792

Peter Robinson pbrobinson@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: webthing - |Review Request: |HTTP Web Thing |python3-webthing - HTTP Web |implementation |Thing implementation Flags|needinfo?(pbrobinson@gmail. | |com) |

--- Comment #5 from Peter Robinson pbrobinson@gmail.com --- SPEC: https://pbrobinson.fedorapeople.org/python3-webthing.spec SRPM: https://pbrobinson.fedorapeople.org/python3-webthing-0.7.0-1.fc28.src.rpm

Description: A server implementing the HTTP Web Thing implementation.

koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=28921784

https://bugzilla.redhat.com/show_bug.cgi?id=1576792

--- Comment #7 from Robert-André Mauchin zebob.m@gmail.com --- (In reply to Peter Robinson from comment #3)

(In reply to Robert-André Mauchin from comment #2)

...

• Use a more meaningful archive name with:

Source0: https://github.com/mozilla-iot/webthing-python/archive/v%%7Bversion%7D/%%7Bn... %{version}.tar.gz

When I packaged this they weren't there, it was from my request they happened: https://github.com/mozilla-iot/webthing-python/issues/13

You misunderstood me maybe, my advice is to change the Source0 to have an archive name with both name and version instead of only the version:

Source0: https://github.com/mozilla-iot/webthing-python/archive/v%%7Bversion%7D/%%7Bn...

...

• I think you should name this package python-webthing and provide a Python

3 subpackage. You could use pyp2rpm to help with that: pyp2rpm -b3 webthing

...

python-webthing.spec and then adjust the patch, license, description.

I'm considering that, although I'd use python3-webthing naming because I have no intention of supporting py2

The policy is still to make a subpackage even if you only make a python3 version. I asked about this a few moths back on IRC.

https://bugzilla.redhat.com/show_bug.cgi?id=1576792

--- Comment #9 from Robert-André Mauchin zebob.m@gmail.com --- (In reply to Peter Robinson from comment #8)

...

You misunderstood me maybe, my advice is to change the Source0 to have an archive name with both name and version instead of only the version:

Source0: https://github.com/mozilla-iot/webthing-python/archive/v%%7Bversion%7D/%%7Bn... %{version}.tar.gz

Personally I don't overly care about this, I have updated it locally, but AFAICT there's no packaging policy either way about this so it should not block the review.

...

The policy is still to make a subpackage even if you only make a python3 version. I asked about this a few moths back on IRC.

Can you please provide the reference to this in the guidelines.

If I asked on IRC, it's because I didn't find it in the guidelines:

2018-02-26 18:25:47 eclipseo If a python package only supports Python 3, should the package be named python-module with a python3-module provide, or should it be named python3-module? 2018-02-26 18:30:07 tibbs eclipseo: Assuming it's a module and not an application, name the SRPM and git repository python-foo and have that produce the python3-foo subpackage. 2018-02-26 18:30:27 tibbs If it's an application, just name it "foo". 2018-02-26 18:30:28 eclipseo ok thx 2018-02-26 18:30:51 tibbs The only real exception is if python-foo already exists as a python2-only thing and the python3 version is a separate upstream.