https://bugzilla.redhat.com/show_bug.cgi?id=2264552

Steve Cossette farchord@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value

--- Comment #1 from Steve Cossette farchord@gmail.com --- The contents of the files in the package can be found here: https://pagure.io/fedora-kde/plasma-welcome-fedora/

https://bugzilla.redhat.com/show_bug.cgi?id=2264552

Neal Gompa ngompa13@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? CC| |ngompa13@gmail.com Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |ngompa13@gmail.com

--- Comment #2 from Neal Gompa ngompa13@gmail.com --- Taking this review.

https://bugzilla.redhat.com/show_bug.cgi?id=2264552

--- Comment #4 from Neal Gompa ngompa13@gmail.com --- Initial spec review:

Source0: intro-customization.desktop Source1: 01-EnableExtraRepos.qml

Instead, we should do the following:

URL: https://pagure.io/fedora-kde/plasma-welcome-fedora Source0: %{url}/archive/%{version}/%{name}-%{version}.tar.gz

And release this as 6.0.0

install -Dpm644 %{_sourcedir}/intro-customization.desktop %{buildroot}%{_kf6_datadir}/plasma/plasma-welcome/intro-customization.desktop

For now, let's not ship this, because we don't know yet how to handle the branding configuration stuff yet.

I also noticed a lack of license files being captured.

https://bugzilla.redhat.com/show_bug.cgi?id=2264552

--- Comment #6 from Steve Cossette farchord@gmail.com --- Spec URL: https://farchord.fedorapeople.org/reviews/plasma-welcome-fedora/plasma-welco... SRPM URL: https://farchord.fedorapeople.org/reviews/plasma-welcome-fedora/plasma-welco...

Fixed a slew of things. One suggestion could not be implemented as it's not accepted by rpm.

https://bugzilla.redhat.com/show_bug.cgi?id=2264552

--- Comment #8 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 2038762 --> https://bugzilla.redhat.com/attachment.cgi?id=2038762&action=edit The .spec file difference from Copr build 7027754 to 7700366

https://bugzilla.redhat.com/show_bug.cgi?id=2264552

--- Comment #10 from Steve Cossette farchord@gmail.com --- Spec URL: https://farchord.fedorapeople.org/reviews/plasma-welcome-fedora/plasma-welco... SRPM URL: https://farchord.fedorapeople.org/reviews/plasma-welcome-fedora/plasma-welco...

Added buildarch

https://bugzilla.redhat.com/show_bug.cgi?id=2264552

--- Comment #12 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/7700412 (succeeded)

Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please take a look if any issues were found.

--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.

https://bugzilla.redhat.com/show_bug.cgi?id=2264552

--- Comment #14 from Steve Cossette farchord@gmail.com --- Thank you for the review, Neal

https://bugzilla.redhat.com/show_bug.cgi?id=2264552

Steve Cossette farchord@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |RAWHIDE Last Closed| |2024-07-22 17:41:24