[Bug 234331] New: Review Request: linuxdcpp - Direct Connect client - package-review

List overview All Threads
Download

newer

[Bug 234331] New: Review Request: linuxdcpp - Direct Connect client

older

[Bug 785946] New: Review Request:...

[Bug 392271] New: Review Request:...

Red Hat Bugzilla

28 Mar 2007 28 Mar '07

10:03 a.m.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234331

Summary: Review Request: linuxdcpp - Direct Connect client Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: normal Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: mgarski@post.pl QAContact: fedora-package-review@redhat.com

Spec URL: http://manta.univ.gda.pl/~mgarski/fe/linuxdcpp.spec SRPM URL: http://manta.univ.gda.pl/~mgarski/fe/linuxdcpp-0-0.1.20070326cvs.src.rpm Description: LinuxDC++ is a Linux port of DC++, a popular client for Direct Connect network.

Two questions: - What path should I use for Icon in linuxdcpp.desktop, the one from my .desktop "Icon=/usr/share/linuxdcpp/pixmaps/linuxdcpp.png" or maybe create /usr/share/pixmaps/, copy linuxdcpp.png to it and change Icon to "Icon=linuxdcpp.png"?

- Which icon should I use in .desktop linuxdcpp-icon.png (20 x 20), or linuxdcpp.png (96 x 96)?

-- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Show replies by thread

Red Hat Bugzilla

28 Mar 28 Mar

10:53 a.m.

New subject: [Bug 234331] Review Request: linuxdcpp - Direct Connect client

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: linuxdcpp - Direct Connect client

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234331

Jochen@herr-schmitt.de changed:

------- Additional Comments From Jochen@herr-schmitt.de 2007-03-28 11:53 EST ------- Good: + Rpmlint ok on source rpm. + Local build works fine. + Rpmlint quite on binary rpm. + Rpmlint quite on Debuginfo rpm. + Local install and uninstall works fine. + Local start of application works fine. + License ok. + Naming ok.

Bad: - Build doesn't use $RPM_OPT_FLAGS

Answers to your questions: * Please use /usr/share/pixmaps for the icon

Question from the review: * The software seems to be an cvs snapshot, what is the level of stablity of this application?

Red Hat Bugzilla

11:08 a.m.

New subject: [Bug 234331] Review Request: linuxdcpp - Direct Connect client

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: linuxdcpp - Direct Connect client

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234331

------- Additional Comments From Jochen@herr-schmitt.de 2007-03-28 12:08 EST ------- Additonal Infos:

Good: + Mock build works fine.

Red Hat Bugzilla

1:03 p.m.

New subject: [Bug 234331] Review Request: linuxdcpp - Direct Connect client

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: linuxdcpp - Direct Connect client

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234331

------- Additional Comments From mgarski@post.pl 2007-03-28 14:03 EST ------- Spec URL: http://manta.univ.gda.pl/~mgarski/fe/linuxdcpp.spec SRPM URL: http://manta.univ.gda.pl/~mgarski/fe/linuxdcpp-0-0.2.20070326cvs.src.rpm

- Use CXXFLAGS - Install icon in pixmaps directory

Me and my friend are using LinuxDC++ from time to time, without any major stablity problems.

Red Hat Bugzilla

1:51 p.m.

New subject: [Bug 234331] Review Request: linuxdcpp - Direct Connect client

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: linuxdcpp - Direct Connect client

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234331

Jochen@herr-schmitt.de changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review-

------- Additional Comments From Jochen@herr-schmitt.de 2007-03-28 14:51 EST ------- Hello,

I have done a look on the official project website. On this site I could read, that the first official release may be coming at the end of this way. Becouse this seems to be a developement release I must taged you reveiw request with an '-'.

Of couse I may willing to review your package when a official release of ths software may available.

Red Hat Bugzilla

3:08 p.m.

New subject: [Bug 234331] Review Request: linuxdcpp - Direct Connect client

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: linuxdcpp - Direct Connect client

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234331

------- Additional Comments From mgarski@post.pl 2007-03-28 16:08 EST ------- I don't know have you noticed that the news about official release was writen on 13th Nov 2006, we have now four months later and still no official release. Besides if you look at the changelog you will see that the project is developed at least since 2005-02-16, so two years of developing.

I don't know when there will be official release, but it's core engine are based on latest stable DC++ release, the GUI is pretty usable (IMHO it's the most usuable DC client available in Linux, and I'm not the only person who tell this) and stable.

So I thought that it would be useful to have this package in Fedora repo as many people could you just with "yum install linuxdcpp".

I also suggest you to read: https://forums.gentoo.org/viewtopic-t-226868.html (thread since 2004 to today).

Of course I will follow your decision, but please try to see my point :)

Red Hat Bugzilla

3:19 p.m.

New subject: [Bug 234331] Review Request: linuxdcpp - Direct Connect client

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: linuxdcpp - Direct Connect client

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234331

------- Additional Comments From mgarski@post.pl 2007-03-28 16:19 EST ------- I could add note to description (and/or summary) that this package is still in alpha/beta or whatever stage so it could cause some problems.

Red Hat Bugzilla

3:41 p.m.

New subject: [Bug 234331] Review Request: linuxdcpp - Direct Connect client

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: linuxdcpp - Direct Connect client

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234331

------- Additional Comments From mgarski@post.pl 2007-03-28 16:41 EST ------- Last spam for today ;-)

I could ask LinuxDC++ developers when they are willing to make official release, also package can stay only in devel branch and move to others after stable release.

Red Hat Bugzilla

3 Apr 3 Apr

4:39 a.m.

New subject: [Bug 234331] Review Request: linuxdcpp - Direct Connect client

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: linuxdcpp - Direct Connect client

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234331

------- Additional Comments From mgarski@post.pl 2007-04-03 05:39 EST ------- I have asked LinuxDC++ developer when they plan to make a release: https://lists.berlios.de/pipermail/linuxdcpp-developers/2007-March/000443.ht...

Why there haven't benn official release, because "the only thing holding back a release is the incomplete i18n support", besides "I've been packaging linuxdcpp without any major issue for months now in debian".

Have this convinced you to review? :) Or should I wait until official release?

Red Hat Bugzilla

6 Jun 6 Jun

4:01 p.m.

New subject: [Bug 234331] Review Request: linuxdcpp - Direct Connect client

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: linuxdcpp - Direct Connect client

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234331

bugzilla@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Priority|normal |medium

lukasim@atlas.cz changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |lukasim@atlas.cz

Red Hat Bugzilla

24 Jun 24 Jun

1:08 p.m.

New subject: [Bug 234331] Review Request: linuxdcpp - Direct Connect client

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: linuxdcpp - Direct Connect client

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234331

bugzilla@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Product|Fedora Extras |Fedora

------- Additional Comments From Jochen@herr-schmitt.de 2007-06-24 14:08 EST -------

...

From my point of view, this is not a blocker to build an official release.

Please ask them to release a version like 0.9.0, what indicates, that not all features are implemented. If they will have implemented the i18n support, they can release a 1.0 version.

Red Hat Bugzilla

16 Jul 16 Jul

9:57 a.m.

New subject: [Bug 234331] Review Request: linuxdcpp - Direct Connect client

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: linuxdcpp - Direct Connect client

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234331

------- Additional Comments From jochen@herr-schmitt.de 2007-07-16 10:57 EST ------- Ping Marcin

Can you tell me anything about your current state?

Red Hat Bugzilla

13 Aug 13 Aug

3:41 p.m.

New subject: [Bug 234331] Review Request: linuxdcpp - Direct Connect client

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: linuxdcpp - Direct Connect client

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234331

------- Additional Comments From mgarski@post.pl 2007-08-13 16:41 EST ------- It's the same as it was. Seven months ago you have asked me "* The software seems to be an cvs snapshot, what is the level of stablity of this application?". I'm still using my package (just with newer snapshots) and maybe linuxdcpp crashed to times, but I don't even remember what I was doing.

Red Hat Bugzilla

14 Aug 14 Aug

1:36 p.m.

New subject: [Bug 234331] Review Request: linuxdcpp - Direct Connect client

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: linuxdcpp - Direct Connect client

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234331

------- Additional Comments From jochen@herr-schmitt.de 2007-08-14 14:36 EST ------- Okey, If ther no official version of the software until the end of this month, I will close the review with a minus flag.

Of course you can restart a review, if there an official version.

Best Regards:

Jochen Schmitt

Red Hat Bugzilla

6 Sep 6 Sep

11:57 a.m.

New subject: [Bug 234331] Review Request: linuxdcpp - Direct Connect client

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: linuxdcpp - Direct Connect client

https://bugzilla.redhat.com/show_bug.cgi?id=234331

jochen@herr-schmitt.de changed:

------- Additional Comments From jochen@herr-schmitt.de 2007-09-06 12:57 EST ------- Because there is no official stable distrubtion of the upstream package, I will revoke thsi review.

Please feel free to restart a new review request if a stable version is available.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Red Hat Bugzilla

24 Sep 24 Sep

1:57 p.m.

New subject: [Bug 234331] Review Request: linuxdcpp - Direct Connect client

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: linuxdcpp - Direct Connect client

https://bugzilla.redhat.com/show_bug.cgi?id=234331

mgarski@post.pl changed:

------- Additional Comments From mgarski@post.pl 2007-09-24 14:57 EST ------- http://mgarski.fedorapeople.org/linuxdcpp-1.0.0-1.fc7.src.rpm http://mgarski.fedorapeople.org/linuxdcpp.spec

LinuxDC++ team released 1.0.0 version, so I reopen this bug.

FYI: You have rejected to review my package but in bug #278481 review of cvs snapshot is being done. What do we do in such case, where two same packages are being reviewed?

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Red Hat Bugzilla

25 Sep 25 Sep

2:58 a.m.

New subject: [Bug 234331] Review Request: linuxdcpp - Direct Connect client

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: linuxdcpp - Direct Connect client

https://bugzilla.redhat.com/show_bug.cgi?id=234331

zprikryl@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |zprikryl@redhat.com

------- Additional Comments From zprikryl@redhat.com 2007-09-25 03:57 EST ------- *** Bug 278481 has been marked as a duplicate of this bug. ***

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Red Hat Bugzilla

11 Oct 11 Oct

11:47 a.m.

New subject: [Bug 234331] Review Request: linuxdcpp - Direct Connect client

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: linuxdcpp - Direct Connect client

https://bugzilla.redhat.com/show_bug.cgi?id=234331

jochen@herr-schmitt.de changed:

------- Additional Comments From jochen@herr-schmitt.de 2007-10-11 12:47 EST ------- Good: + Mock build for Devel and F-7 works fine (x86_64, ppc64) + Package meets naming and packaging guideline + Spec file matches with package base name + Spec file have consistant macro ussage + Version is GPLv2 + Spec is in English + Spec is legible + Tarball matches with upstream (md5sum: 33c3b0ae46772dec3142e35c30401a27) + Package has correct buildroot + Package has no redundant BuildRequires + Package has no sub packages + Local build works fine. + Package has %defattr and proper permissions + Package has a proper %clean section + Buildroot will be cleaned on the beginning of the %install section + %doc file don't affect runtime + Package contains no duplicated files + Package doesn't own file from other packages + %changeLog section is correct. + Locdl install and uninstall works fine. + Application has proper menue item + Application started without a crash + Rpmlint don't complaints the binary and debuginfo rpm

Bad: - License Tag says GPLv2+ - Duplicate BuildRequires: pkgconfig (by gtk2-devel), glib2-devel (by gtk2-devel), gtk2-devel (by libglade2-devel), zlib-devel (by openssl-devel) - Rpmlint complaints on source rpm: $ rpmlint linuxdcpp-1.0.0-1.fc7.src.rpm linuxdcpp.src:25: W: rpm-buildroot-usage %build FAKE_ROOT="$RPM_BUILD_ROOT"

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Red Hat Bugzilla

3:15 p.m.

New subject: [Bug 234331] Review Request: linuxdcpp - Direct Connect client

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: linuxdcpp - Direct Connect client

https://bugzilla.redhat.com/show_bug.cgi?id=234331

mgarski@post.pl changed:

------- Additional Comments From mgarski@post.pl 2007-10-11 16:15 EST ------- (In reply to comment #16)

...

Bad:

License Tag says GPLv2+

Yes it's GPLv2+, because if you look at the source files you will notice: "either version 2 of the License, or (at your option) any later version."

...

Duplicate BuildRequires: pkgconfig (by gtk2-devel), glib2-devel (by gtk2-devel), gtk2-devel (by libglade2-devel), zlib-devel (by openssl-devel)

IMHO it's duplicate but correct see bug #178031 comment #7 (this stuff is checked by scons).

...

Rpmlint complaints on source rpm:

$ rpmlint linuxdcpp-1.0.0-1.fc7.src.rpm linuxdcpp.src:25: W: rpm-buildroot-usage %build FAKE_ROOT="$RPM_BUILD_ROOT"

Fixed.

http://mgarski.fedorapeople.org/linuxdcpp-1.0.0-2.fc7.src.rpm http://mgarski.fedorapeople.org/linuxdcpp.spec

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Red Hat Bugzilla

14 Oct 14 Oct

1:24 p.m.

New subject: [Bug 234331] Review Request: linuxdcpp - Direct Connect client

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: linuxdcpp - Direct Connect client

https://bugzilla.redhat.com/show_bug.cgi?id=234331

jochen@herr-schmitt.de changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+

------- Additional Comments From jochen@herr-schmitt.de 2007-10-14 14:24 EST ------- Looks fine, you are APPROVED

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Red Hat Bugzilla

2:06 p.m.

New subject: [Bug 234331] Review Request: linuxdcpp - Direct Connect client

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: linuxdcpp - Direct Connect client

https://bugzilla.redhat.com/show_bug.cgi?id=234331

mgarski@post.pl changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?

------- Additional Comments From mgarski@post.pl 2007-10-14 15:06 EST ------- New Package CVS Request ======================= Package Name: linuxdcpp Short Description: Direct Connect client Owners: mgarski Branches: F-7 InitialCC: Cvsextras Commits: yes

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Red Hat Bugzilla

2:36 p.m.

New subject: [Bug 234331] Review Request: linuxdcpp - Direct Connect client

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: linuxdcpp - Direct Connect client

https://bugzilla.redhat.com/show_bug.cgi?id=234331

kevin@tummy.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+

------- Additional Comments From kevin@tummy.com 2007-10-14 15:36 EST ------- cvs done.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Red Hat Bugzilla

3:48 p.m.

New subject: [Bug 234331] Review Request: linuxdcpp - Direct Connect client

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: linuxdcpp - Direct Connect client

https://bugzilla.redhat.com/show_bug.cgi?id=234331

mgarski@post.pl changed:

------- Additional Comments From mgarski@post.pl 2007-10-14 16:48 EST ------- Thanks. Build in devel and F-7 tree.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Red Hat Bugzilla

4 Apr 4 Apr

4:23 p.m.

New subject: [Bug 234331] Review Request: linuxdcpp - Direct Connect client

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=234331

Peter Hatina phatina@redhat.com changed:

--- Comment #22 from Peter Hatina phatina@redhat.com 2012-04-04 17:23:11 EDT --- Package Change Request ====================== Package Name: linuxdcpp New Branches: f16, f17 Owners: phatina

I want to continue maintaining this package. Please, create necessary branches for me.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.

Red Hat Bugzilla

5 Apr 5 Apr

7:08 a.m.

New subject: [Bug 234331] Review Request: linuxdcpp - Direct Connect client

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=234331

--- Comment #23 from Jon Ciesla limburgher@gmail.com 2012-04-05 08:08:10 EDT --- This has been orphaned more than two weeks and should be re-reviewed, contact me if you need a reviewer. Thanks!

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.

4572

Age (days ago)

6407

Last active (days ago)

package-review@lists.fedoraproject.org

24 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla