https://bugzilla.redhat.com/show_bug.cgi?id=2294765

Fedora Review Service fedora-review-bot@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- URL| |https://github.com/janestre | |et/ocaml_intrinsics_kernel

--- Comment #1 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/7690170 (succeeded)

Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Found issues:

- No gcc, gcc-c++ or clang found in BuildRequires Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/

Please know that there can be false-positives.

--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.

https://bugzilla.redhat.com/show_bug.cgi?id=2294765

Peter Lemenkov lemenkov@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+

--- Comment #3 from Peter Lemenkov lemenkov@gmail.com --- This spec-file looks very clean. I found only one easy-to-fix issue - a wrong Source tag which should be %{url} not %{vcs}. Please fix it before uploading. That's all I could find so here is my formal

Package Review ==============

Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed

===== MUST items =====

C/C++: [x]: Package does not contain kernel modules. [-]: Development (unversioned) .so files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs.

Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license (MIT). [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format (%autochangelog). [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package requires an ExcludeArch tag since it's OCaml application/library. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 474 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic: [!]: Sources can be downloaded from URI in Source: tag Note: Could not download Source0:

git:https://github.com/janestreet/ocaml_intrinsics_kernel.git/archive/v0.17.0/oc... [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: I did not test if the package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: SourceX tarball generation or download is documented. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [?]: I did not test if package compiles and builds into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM.

Rpmlint ------- Checking: ocaml-intrinsics-kernel-0.17.0-1.fc41.x86_64.rpm ocaml-intrinsics-kernel-devel-0.17.0-1.fc41.x86_64.rpm ocaml-intrinsics-kernel-debuginfo-0.17.0-1.fc41.x86_64.rpm ocaml-intrinsics-kernel-debugsource-0.17.0-1.fc41.x86_64.rpm ocaml-intrinsics-kernel-0.17.0-1.fc41.src.rpm ========================================================================================================================================= rpmlint session starts ======================================================================================================================================== rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpgv91qxtf')] checks: 32, packages: 5

ocaml-intrinsics-kernel-devel.x86_64: E: static-library-without-debuginfo /usr/lib64/ocaml/ocaml_intrinsics_kernel/libocaml_intrinsics_kernel_stubs.a ocaml-intrinsics-kernel-devel.x86_64: E: static-library-without-debuginfo /usr/lib64/ocaml/ocaml_intrinsics_kernel/ocaml_intrinsics_kernel.a ocaml-intrinsics-kernel.src: E: spelling-error ('javascript', '%description -l en_US javascript -> java script, java-script, JavaScript') ocaml-intrinsics-kernel.x86_64: E: spelling-error ('javascript', '%description -l en_US javascript -> java script, java-script, JavaScript') ocaml-intrinsics-kernel-devel.x86_64: W: no-documentation ocaml-intrinsics-kernel.spec: W: invalid-url Source0: git:https://github.com/janestreet/ocaml_intrinsics_kernel.git/archive/v0.17.0/oc... ocaml-intrinsics-kernel-devel.x86_64: E: description-line-too-long The ocaml-intrinsics-kernel-devel package contains libraries and signature files for =================================================================================================== 5 packages and 0 specfiles checked; 5 errors, 2 warnings, 27 filtered, 5 badness; has taken 2.6 s ===================================================================================================

Rpmlint (debuginfo) ------------------- Checking: ocaml-intrinsics-kernel-debuginfo-0.17.0-1.fc41.x86_64.rpm ========================================================================================================================================= rpmlint session starts ======================================================================================================================================== rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp6hx3he7y')] checks: 32, packages: 1

=================================================================================================== 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 12 filtered, 0 badness; has taken 0.6 s ===================================================================================================

Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 4

ocaml-intrinsics-kernel-devel.x86_64: E: static-library-without-debuginfo /usr/lib64/ocaml/ocaml_intrinsics_kernel/libocaml_intrinsics_kernel_stubs.a ocaml-intrinsics-kernel-devel.x86_64: E: static-library-without-debuginfo /usr/lib64/ocaml/ocaml_intrinsics_kernel/ocaml_intrinsics_kernel.a ocaml-intrinsics-kernel.x86_64: E: spelling-error ('javascript', '%description -l en_US javascript -> java script, java-script, JavaScript') ocaml-intrinsics-kernel-devel.x86_64: W: no-documentation ocaml-intrinsics-kernel-devel.x86_64: E: description-line-too-long The ocaml-intrinsics-kernel-devel package contains libraries and signature files for 4 packages and 0 specfiles checked; 4 errors, 1 warnings, 25 filtered, 4 badness; has taken 2.2 s

Unversioned so-files -------------------- ocaml-intrinsics-kernel: /usr/lib64/ocaml/stublibs/dllocaml_intrinsics_kernel_stubs.so

Requires -------- ocaml-intrinsics-kernel (rpmlib, GLIBC filtered): ocaml(CamlinternalFormatBasics) ocaml(Ocaml_intrinsics_kernel) ocaml(Ocaml_intrinsics_kernel__Common) ocaml(Ocaml_intrinsics_kernel__Naive_ints) ocaml(Stdlib) ocaml(Stdlib__Int) ocaml(Stdlib__Int32) ocaml(Stdlib__Int64) ocaml(Stdlib__Nativeint) ocaml(Stdlib__Sys) rtld(GNU_HASH)

ocaml-intrinsics-kernel-devel (rpmlib, GLIBC filtered): ocaml(CamlinternalFormatBasics) ocaml(Ocaml_intrinsics_kernel) ocaml(Ocaml_intrinsics_kernel__Common) ocaml(Ocaml_intrinsics_kernel__Naive_ints) ocaml(Stdlib) ocaml(Stdlib__Int) ocaml(Stdlib__Int32) ocaml(Stdlib__Int64) ocaml(Stdlib__Nativeint) ocaml(Stdlib__Sys) ocaml-intrinsics-kernel(x86-64) ocamlx(Ocaml_intrinsics_kernel__Common) ocamlx(Ocaml_intrinsics_kernel__Naive_ints) ocamlx(Stdlib__Int) ocamlx(Stdlib__Int32) ocamlx(Stdlib__Int64) ocamlx(Stdlib__Nativeint) ocamlx(Stdlib__Sys)

ocaml-intrinsics-kernel-debuginfo (rpmlib, GLIBC filtered):

ocaml-intrinsics-kernel-debugsource (rpmlib, GLIBC filtered):

Provides -------- ocaml-intrinsics-kernel: ocaml(Ocaml_intrinsics_kernel) ocaml(Ocaml_intrinsics_kernel__Common) ocaml(Ocaml_intrinsics_kernel__Conditional) ocaml(Ocaml_intrinsics_kernel__Float) ocaml(Ocaml_intrinsics_kernel__Int) ocaml(Ocaml_intrinsics_kernel__Int32) ocaml(Ocaml_intrinsics_kernel__Int64) ocaml(Ocaml_intrinsics_kernel__Naive_ints) ocaml(Ocaml_intrinsics_kernel__Nativeint) ocaml-intrinsics-kernel ocaml-intrinsics-kernel(x86-64)

ocaml-intrinsics-kernel-devel: ocaml(Ocaml_intrinsics_kernel) ocaml(Ocaml_intrinsics_kernel__Common) ocaml(Ocaml_intrinsics_kernel__Conditional) ocaml(Ocaml_intrinsics_kernel__Float) ocaml(Ocaml_intrinsics_kernel__Int) ocaml(Ocaml_intrinsics_kernel__Int32) ocaml(Ocaml_intrinsics_kernel__Int64) ocaml(Ocaml_intrinsics_kernel__Naive_ints) ocaml(Ocaml_intrinsics_kernel__Nativeint) ocaml-intrinsics-kernel-devel ocaml-intrinsics-kernel-devel(x86-64) ocamlx(Ocaml_intrinsics_kernel) ocamlx(Ocaml_intrinsics_kernel__Common) ocamlx(Ocaml_intrinsics_kernel__Conditional) ocamlx(Ocaml_intrinsics_kernel__Float) ocamlx(Ocaml_intrinsics_kernel__Int) ocamlx(Ocaml_intrinsics_kernel__Int32) ocamlx(Ocaml_intrinsics_kernel__Int64) ocamlx(Ocaml_intrinsics_kernel__Naive_ints) ocamlx(Ocaml_intrinsics_kernel__Nativeint)

ocaml-intrinsics-kernel-debuginfo: debuginfo(build-id) ocaml-intrinsics-kernel-debuginfo ocaml-intrinsics-kernel-debuginfo(x86-64)

ocaml-intrinsics-kernel-debugsource: ocaml-intrinsics-kernel-debugsource ocaml-intrinsics-kernel-debugsource(x86-64)

Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2294765 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Ocaml, Generic, C/C++ Disabled plugins: fonts, R, Haskell, PHP, SugarActivity, Perl, Python, Java Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH

This package is

================ === Approved === ================

https://bugzilla.redhat.com/show_bug.cgi?id=2294765

Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST

--- Comment #5 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/ocaml-intrinsics-kernel