Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Fedora Merge Review: sabayon
https://bugzilla.redhat.com/show_bug.cgi?id=557760
Summary: Fedora Merge Review: sabayon Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: tbzatek@redhat.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Target Release: ---
Fedora Merge Review: sabayon
http://cvs.fedoraproject.org/viewvc/devel/sabayon/ Initial Owner: tbzatek@redhat.com
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=557760
Jason Tibbitts tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Fedora Merge Review: |Merge Review: sabayon |sabayon |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=557760
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |limburgher@gmail.com, | |tbzatek@redhat.com AssignedTo|nobody@fedoraproject.org |limburgher@gmail.com Flag| |fedora-review?
--- Comment #1 from Jon Ciesla limburgher@gmail.com 2012-04-05 15:34:59 EDT --- Good:
- rpmlint checks return:
sabayon.spec:98: W: mixed-use-of-spaces-and-tabs (spaces: line 9, tab: line 98) The specfile mixes use of spaces and tabs for indentation, which is a cosmetic annoyance. Use either spaces or tabs for indentation, not both.
Trivial to fix.
sabayon.x86_64: W: private-shared-object-provides /usr/lib64/python2.7/site-packages/sabayon/xlib.so xlib.so()(64bit) A shared object soname provides is provided by a file in a path from which other packages should not directly load shared objects from. Such shared objects should thus not be depended on and they should not result in provides in the containing package. Get rid of the provides if appropriate, for example by filtering it out during build. Note that in some cases this may require disabling rpmbuild's internal dependency generator.
Fix.
sabayon.x86_64: W: dangerous-command-in-%postun userdel
FIX. We don't remove users, ever.
https://fedoraproject.org/wiki/Packaging:UsersAndGroups
sabayon-apply.x86_64: E: executable-marked-as-config-file /etc/X11/xinit/xinitrc.d/sabayon-xinitrc.sh Executables must not be marked as config files because that may prevent upgrades from working correctly. If you need to be able to customize an executable, make it for example read a config file in /etc/sysconfig.
Fix.
sabayon-apply.x86_64: E: script-without-shebang /etc/X11/xinit/xinitrc.d/sabayon-xinitrc.sh This text file has executable bits set or is located in a path dedicated for executables, but lacks a shebang and cannot thus be executed. If the file is meant to be an executable script, add the shebang, otherwise remove the executable bits or move the file elsewhere.
Fix.
sabayon-apply.x86_64: W: no-manual-page-for-binary sabayon-apply Each executable in standard binary directories should have a man page.
Fix if possible.
Lots of wrong fsf address, file upstream.
- package meets naming guidelines - package meets packaging guidelines - license ( GPLv2+ ) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file
So it's just what's from rpmlint, let me know if you want me to commit any fixes.
package-review@lists.fedoraproject.org