https://bugzilla.redhat.com/show_bug.cgi?id=2121585

Benson Muite benson_muite@emailplus.org changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |benson_muite@emailplus.org Doc Type|--- |If docs needed, set a value

--- Comment #1 from Benson Muite benson_muite@emailplus.org --- fedora-review did not complete for me. Got the following error:

RPM build errors: File must begin with "/": %{_unitdir}/janus-gateway.service Child return code was: 1 EXCEPTION: [Error()] Traceback (most recent call last): File "/usr/lib/python3.10/site-packages/mockbuild/trace_decorator.py", line 93 , in trace result = func(*args, **kw) File "/usr/lib/python3.10/site-packages/mockbuild/util.py", line 598, in do_wi th_status raise exception.Error("Command failed: \n # %s\n%s" % (command, output), chi ld.returncode) mockbuild.exception.Error: Command failed:

On Copr build succedded: https://copr.fedorainfracloud.org/coprs/fed500/janus-gateway/build/4767717/

https://bugzilla.redhat.com/show_bug.cgi?id=2121585

--- Comment #3 from Benson Muite benson_muite@emailplus.org --- Thanks. Can probably also remove automake and autoconf, and add gcc see https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/#_packag...

Probably adding systemd to BuildRequires rather than systemd-rpm-macros would also work, but expect systemd-rpm-macros is fine.

Do all the tests need network access? IF not, it would be good to try to run those that do not.

https://bugzilla.redhat.com/show_bug.cgi?id=2121585

--- Comment #5 from Renich Bon Ciric renich@woralelandia.com --- You rock! i definitely owe you one. :D

Fixed most of the issues. Let me address a few, though:

Do all the tests need network access? IF not, it would be good to try to run those that do not.

It seems that the tests deviate from the generally used: make test. Also, they're more of a functionality test than unit or integration tests. It requires pip and it spins up a janus-gateway server and uses python to test it's functionality.

I'm in the process of getting this to work using mock. That said, I dunno if I want to do that in koji's minions... It's OK for local development but not so much for automated testing. My two cents on that...

Licenses used:

*No copyright* GNU General Public License, Version 3

janus-gateway-1.0.4/README.md janus-gateway-1.0.4/bower.json janus-gateway-1.0.4/npm/package.json janus-gateway-1.0.4/package.json

BSD 3-Clause License

janus-gateway-1.0.4/fuzzers/corpora/rtcp_fuzzer/2webrtc/LICENSE

MIT License

janus-gateway-1.0.4/html/janus.js janus-gateway-1.0.4/src/plugins/duktape-deps/LICENSE.txt

The BSD-3-Clause license covers the fuzzers. They do not get packaged, AFAICT. Do we include them and throw in the license anyway?

Also, the MIT license covers one of the plugin's deps. I dunno what to do in this case. Maybe just include the license as well?

What do you think? I appreciate your hard work, btw. :D

New sources at:

Spec URL: https://renich.fedorapeople.org/janus-gateway/janus-gateway.spec SRPM URL: https://renich.fedorapeople.org/janus-gateway/janus-gateway-1.0.4-3.fc36.src...

It was a bad idea to use pagure to publish these (the SRPM at least). Moved to fedorapeople.org.

https://bugzilla.redhat.com/show_bug.cgi?id=2121585

--- Comment #6 from Benson Muite benson_muite@emailplus.org --- Thanks for the update. Fedora Review now runs:

Package Review ==============

Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed

Issues: ======= - Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/share/doc/janus-gateway/janus- gateway-1.0.4/html/COPYING.html See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_duplicate_files

===== MUST items =====

C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [?]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs.

Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [?]: License field in the package spec file matches the actual license. Note: There is no build directory. Running licensecheck on vanilla upstream sources. No licenses found. Please check the source files for licenses manually. [ ]: License file installed when any subpackage combination is installed. [?]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [?]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/janus/demos, /usr/share/janus/javascript, /usr/lib64/janus/events, /usr/include/janus, /usr/share/janus/demos/docs, /usr/include/janus/plugins, /usr/include/janus/events, /usr/share/janus/demos/css, /etc/janus, /usr/share/janus/demos/surround, /usr/share/janus, /usr/include/janus/transports, /usr/include/janus/loggers, /usr/lib64/janus/plugins, /usr/share/janus/demos/background, /usr/share/janus/duktape, /usr/share/janus/streams, /usr/lib64/janus, /usr/share/janus/recordings, /usr/lib64/janus/transports, /usr/share/janus/lua [?]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib64/janus, /usr/include/janus/loggers, /usr/share/janus/demos, /usr/share/janus/javascript, /usr/share/janus/demos/docs, /usr/include/janus/plugins, /usr/lib64/janus/plugins, /usr/share/janus/recordings, /usr/include/janus/events, /usr/lib64/janus/events, /usr/lib64/janus/transports, /usr/share/janus/demos/css, /etc/janus, /usr/share/janus/demos/background, /usr/share/janus/demos/surround, /usr/share/janus, /usr/include/janus, /usr/share/janus/lua, /usr/share/janus/duktape, /usr/share/doc/janus-gateway, /usr/share/janus/streams, /usr/include/janus/transports [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 112640 bytes in 3 files. [?]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: systemd_post is invoked in %post, systemd_preun in %preun, and systemd_postun in %postun for Systemd service files. Note: Systemd service file(s) in janus-gateway [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in janus- gateway-devel [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [?]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic: [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 41953280 bytes in /usr/share janus- gateway-doc-1.0.4-3.fc38.x86_64.rpm:36935680 See:

https://fedoraproject.org/wiki/Packaging:ReviewGuidelines#Package_Review_Gui... [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Package should not use obsolete m4 macros [x]: Spec file according to URL is the same as in SRPM.

Rpmlint ------- Cannot parse rpmlint output:

Rpmlint (debuginfo) ------------------- Cannot parse rpmlint output:

Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output:

Unversioned so-files -------------------- janus-gateway: /usr/lib64/janus/events/libjanus_gelfevh.so janus-gateway: /usr/lib64/janus/events/libjanus_mqttevh.so janus-gateway: /usr/lib64/janus/events/libjanus_nanomsgevh.so janus-gateway: /usr/lib64/janus/events/libjanus_rabbitmqevh.so janus-gateway: /usr/lib64/janus/events/libjanus_sampleevh.so janus-gateway: /usr/lib64/janus/events/libjanus_wsevh.so janus-gateway: /usr/lib64/janus/plugins/libjanus_audiobridge.so janus-gateway: /usr/lib64/janus/plugins/libjanus_duktape.so janus-gateway: /usr/lib64/janus/plugins/libjanus_echotest.so janus-gateway: /usr/lib64/janus/plugins/libjanus_lua.so janus-gateway: /usr/lib64/janus/plugins/libjanus_nosip.so janus-gateway: /usr/lib64/janus/plugins/libjanus_recordplay.so janus-gateway: /usr/lib64/janus/plugins/libjanus_sip.so janus-gateway: /usr/lib64/janus/plugins/libjanus_streaming.so janus-gateway: /usr/lib64/janus/plugins/libjanus_textroom.so janus-gateway: /usr/lib64/janus/plugins/libjanus_videocall.so janus-gateway: /usr/lib64/janus/plugins/libjanus_videoroom.so janus-gateway: /usr/lib64/janus/plugins/libjanus_voicemail.so janus-gateway: /usr/lib64/janus/transports/libjanus_http.so janus-gateway: /usr/lib64/janus/transports/libjanus_mqtt.so janus-gateway: /usr/lib64/janus/transports/libjanus_nanomsg.so janus-gateway: /usr/lib64/janus/transports/libjanus_pfunix.so janus-gateway: /usr/lib64/janus/transports/libjanus_rabbitmq.so janus-gateway: /usr/lib64/janus/transports/libjanus_websockets.so

Source checksums ---------------- https://github.com/meetecho/janus-gateway/archive/refs/tags/v1.0.4.tar.gz : CHECKSUM(SHA256) this package : 7af5b218074666faea85f096e9fae290f455382982b219d2c257cdfce6c 4b8a7 CHECKSUM(SHA256) upstream package : 7af5b218074666faea85f096e9fae290f455382982b219d2c257cdfce6c 4b8a7

Requires -------- janus-gateway (rpmlib, GLIBC filtered): /bin/sh libavcodec.so.59()(64bit) libavcodec.so.59(LIBAVCODEC_59)(64bit) libavformat.so.59()(64bit) libavformat.so.59(LIBAVFORMAT_59)(64bit) libavutil.so.57()(64bit) libavutil.so.57(LIBAVUTIL_57)(64bit) libc.so.6()(64bit) libconfig.so.11()(64bit) libcrypto.so.3()(64bit) libcrypto.so.3(OPENSSL_3.0.0)(64bit) libcurl.so.4()(64bit) libduktape.so.206()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libjansson.so.4()(64bit) libjanus_audiobridge.so.0()(64bit) libjanus_duktape.so.0()(64bit) libjanus_echotest.so.0()(64bit) libjanus_gelfevh.so.0()(64bit) libjanus_http.so.0()(64bit) libjanus_lua.so.0()(64bit) libjanus_mqtt.so.0()(64bit) libjanus_mqttevh.so.0()(64bit) libjanus_nanomsg.so.0()(64bit) libjanus_nanomsgevh.so.0()(64bit) libjanus_nosip.so.0()(64bit) libjanus_pfunix.so.0()(64bit) libjanus_rabbitmq.so.0()(64bit) libjanus_rabbitmqevh.so.0()(64bit) libjanus_recordplay.so.0()(64bit) libjanus_sampleevh.so.0()(64bit) libjanus_sip.so.0()(64bit) libjanus_streaming.so.0()(64bit) libjanus_textroom.so.0()(64bit) libjanus_videocall.so.0()(64bit) libjanus_videoroom.so.0()(64bit) libjanus_voicemail.so.0()(64bit) libjanus_websockets.so.0()(64bit) libjanus_wsevh.so.0()(64bit) liblua-5.4.so()(64bit) libm.so.6()(64bit) libmicrohttpd.so.12()(64bit) libnanomsg.so.5()(64bit) libnice.so.10()(64bit) libogg.so.0()(64bit) libopus.so.0()(64bit) libpaho-mqtt3as.so.1()(64bit) librabbitmq.so.4()(64bit) libsofia-sip-ua.so.0()(64bit) libsrtp2.so.1()(64bit) libssl.so.3()(64bit) libssl.so.3(OPENSSL_3.0.0)(64bit) libusrsctp.so.2()(64bit) libwebsockets.so.19()(64bit) libz.so.1()(64bit) rtld(GNU_HASH)

janus-gateway-devel (rpmlib, GLIBC filtered):

janus-gateway-doc (rpmlib, GLIBC filtered):

janus-gateway-debuginfo (rpmlib, GLIBC filtered):

janus-gateway-debugsource (rpmlib, GLIBC filtered):

Provides -------- janus-gateway: janus-gateway janus-gateway(x86-64) libjanus_audiobridge.so.0()(64bit) libjanus_duktape.so.0()(64bit) libjanus_echotest.so.0()(64bit) libjanus_gelfevh.so.0()(64bit) libjanus_http.so.0()(64bit) libjanus_lua.so.0()(64bit) libjanus_mqtt.so.0()(64bit) libjanus_mqttevh.so.0()(64bit) libjanus_nanomsg.so.0()(64bit) libjanus_nanomsgevh.so.0()(64bit) libjanus_nosip.so.0()(64bit) libjanus_pfunix.so.0()(64bit) libjanus_rabbitmq.so.0()(64bit) libjanus_rabbitmqevh.so.0()(64bit) libjanus_recordplay.so.0()(64bit) libjanus_sampleevh.so.0()(64bit) libjanus_sip.so.0()(64bit) libjanus_streaming.so.0()(64bit) libjanus_textroom.so.0()(64bit) libjanus_videocall.so.0()(64bit) libjanus_videoroom.so.0()(64bit) libjanus_voicemail.so.0()(64bit) libjanus_websockets.so.0()(64bit) libjanus_wsevh.so.0()(64bit)

janus-gateway-devel: janus-gateway-devel janus-gateway-devel(x86-64)

janus-gateway-doc: janus-gateway-doc janus-gateway-doc(x86-64)

janus-gateway-debuginfo: debuginfo(build-id) janus-gateway-debuginfo janus-gateway-debuginfo(x86-64) libjanus_audiobridge.so.0.0.0-1.0.4-3.fc38.x86_64.debug()(64bit) libjanus_duktape.so.0.0.0-1.0.4-3.fc38.x86_64.debug()(64bit) libjanus_echotest.so.0.0.0-1.0.4-3.fc38.x86_64.debug()(64bit) libjanus_gelfevh.so.0.0.0-1.0.4-3.fc38.x86_64.debug()(64bit) libjanus_http.so.0.0.0-1.0.4-3.fc38.x86_64.debug()(64bit) libjanus_lua.so.0.0.0-1.0.4-3.fc38.x86_64.debug()(64bit) libjanus_mqtt.so.0.0.0-1.0.4-3.fc38.x86_64.debug()(64bit) libjanus_mqttevh.so.0.0.0-1.0.4-3.fc38.x86_64.debug()(64bit) libjanus_nanomsg.so.0.0.0-1.0.4-3.fc38.x86_64.debug()(64bit) libjanus_nanomsgevh.so.0.0.0-1.0.4-3.fc38.x86_64.debug()(64bit) libjanus_nosip.so.0.0.0-1.0.4-3.fc38.x86_64.debug()(64bit) libjanus_pfunix.so.0.0.0-1.0.4-3.fc38.x86_64.debug()(64bit) libjanus_rabbitmq.so.0.0.0-1.0.4-3.fc38.x86_64.debug()(64bit) libjanus_rabbitmqevh.so.0.0.0-1.0.4-3.fc38.x86_64.debug()(64bit) libjanus_recordplay.so.0.0.0-1.0.4-3.fc38.x86_64.debug()(64bit) libjanus_sampleevh.so.0.0.0-1.0.4-3.fc38.x86_64.debug()(64bit) libjanus_sip.so.0.0.0-1.0.4-3.fc38.x86_64.debug()(64bit) libjanus_streaming.so.0.0.0-1.0.4-3.fc38.x86_64.debug()(64bit) libjanus_textroom.so.0.0.0-1.0.4-3.fc38.x86_64.debug()(64bit) libjanus_videocall.so.0.0.0-1.0.4-3.fc38.x86_64.debug()(64bit) libjanus_videoroom.so.0.0.0-1.0.4-3.fc38.x86_64.debug()(64bit) libjanus_voicemail.so.0.0.0-1.0.4-3.fc38.x86_64.debug()(64bit) libjanus_websockets.so.0.0.0-1.0.4-3.fc38.x86_64.debug()(64bit) libjanus_wsevh.so.0.0.0-1.0.4-3.fc38.x86_64.debug()(64bit)

janus-gateway-debugsource: janus-gateway-debugsource janus-gateway-debugsource(x86-64)

Generated by fedora-review 0.8.0 (e988316) last change: 2022-04-07 Command line :/usr/bin/fedora-review -b 2121585 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, C/C++, Shell-api Disabled plugins: SugarActivity, PHP, Java, Ocaml, Python, fonts, Perl, Haskell, R Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH

Comments: a) Should the .sample files go in the documentation directory? b) Might consider renaming Source0: https://github.com/meetecho/janus-gateway/archive/refs/tags/v1.0.4.tar.gz to Source0: https://github.com/meetecho/%%7Bname%7D/archive/v%%7Bversion%7D/%%7Bname%7D_... c) May want to check codecs used are freely licensed d) Can one use the libraries independently of the application? If so, they should be in a subpackage: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_library_or_appli...

https://bugzilla.redhat.com/show_bug.cgi?id=2121585

--- Comment #8 from Renich Bon Ciric renich@woralelandia.com --- Forgot to post the files:

Spec URL: https://renich.fedorapeople.org/janus-gateway/janus-gateway.spec SRPM URL: https://renich.fedorapeople.org/janus-gateway/janus-gateway-1.0.4-4.fc36.src...

https://bugzilla.redhat.com/show_bug.cgi?id=2121585

--- Comment #10 from Benson Muite benson_muite@emailplus.org --- Great. Can you subpackage? This is helpful for re-usability.

https://bugzilla.redhat.com/show_bug.cgi?id=2121585

--- Comment #12 from Renich Bon Ciric renich@woralelandia.com --- Hello, Benson.

So, I've had a conversation with upstream and Lorenzo has a few request:

https://groups.google.com/g/meetecho-janus/c/ESCW9mQJpYc/m/ylBv2-_hAgAJ

package rename -------------- He's asking us to use "janus" only. "janus-gateway" is the old name and doesn't reflect janus' funcionality anymore; it's much more than a gateway now.

He suggested a few names but, since Debian is using "janus" as a name, I think we can be consistent with that.

I've just renamed the package and spec files. I dunno if there is any procedure to do this or if it's allowed.

Should I rename the revew request as well? What do you think?

Reorganized some files ---------------------- I've moved files around as per Lorenzo's recommendations.

Build dependencies ------------------ I've added libpcap-devel to the dependencies so that the "tools" sub-package includes pcap2mjr.

Meta-package for plugins ------------------------ Lorenzo suggested the possibility of using "macro packages" as he calls them. It is not uncommon in Fedora to use a meta package to include, say, all plugins. Is it OK to add the meta-package?

In any case, here're the updated spec and SRPM files.

Spec URL: https://renich.fedorapeople.org/janus/janus.spec SRPM URL: https://renich.fedorapeople.org/janus/janus-1.0.4-6.fc36.src.rpm

https://bugzilla.redhat.com/show_bug.cgi?id=2121585

--- Comment #14 from Renich Bon Ciric renich@woralelandia.com --- (In reply to Benson Muite from comment #13)

Renamed since this is used when creating the repository. Thanks for re-packaging and your engagement with upstream.

Happy to do my part. Thank you as well. :D

https://bugzilla.redhat.com/show_bug.cgi?id=2121585

--- Comment #17 from Benson Muite benson_muite@emailplus.org --- The html documentation has javascript and webassets: https://docs.fedoraproject.org/en-US/packaging-guidelines/JavaScript/ https://docs.fedoraproject.org/en-US/packaging-guidelines/Web_Assets/

https://bugzilla.redhat.com/show_bug.cgi?id=2121585

--- Comment #19 from Renich Bon Ciric renich@woralelandia.com --- OK, about the web assets and javascript... the amout of work in order to get the demos and docs sub-packages overwhelmed me for now. I am thinking of removing those in order to push that part of the RPM a bit so I can get some guidance from someone that has done this and maintained this for a while.

I dunno if this applies to the docs subpackage; since it's a doxygen generated documentation website. It's supposed to be useful only internally or offline, if you ask me.

In any case, I think I will be removing those two sub-packages for now, unless you advise differently.

This will leave us only with the plugin/module versioning dilemma.

What do you think?

For now, here's the SRPM and spec file without doc and demos:

Spec URL: https://renich.fedorapeople.org/janus/janus.spec SRPM URL: https://renich.fedorapeople.org/janus/janus-1.0.4-7.fc36.src.rpm

https://bugzilla.redhat.com/show_bug.cgi?id=2121585

--- Comment #21 from Renich Bon Ciric renich@woralelandia.com --- (In reply to Benson Muite from comment #20)

Thanks for this useful package which will make video conferencing easier. Some of these are packaged. See for example: https://packages.fedoraproject.org/pkgs/js-jquery/js-jquery/

Yeah, I took a look at this. The thing is that the jquery version required by the sites is way lower. This is why I don't know if it would be worthwhile to package.

bootswatch, bootstrap are the other javascript libraries needed for the documentation.

I am not reluctant to package those. But, maybe, I can do it iteratively. First, release a version without those (for now) and, eventually, add those sub-packages as I package the dependencies.

I mean, the demo and doc websites live online. They would be useful for offline setups. I think we can live without them for now.

Doxygen also seems like it can generate man pages, https://www.doxygen.nl/manual/starting.html#man_out Would this work here?

This is a good idea. I'll try it out definitely. At least provide the man pages.

The examples have many more javascript dependencies that would need to be packaged. Maybe these can be left out for now, or some exemption sought.

In the case of the demos subpackage, those js files are kind of specific to the demo itself. I don't think they're wirth packaging. Their only value is when used in the demo sites; which resides online as well: https://janus.conf.meetecho.com/demos.html

We don't loose much if we don't package those. We gain the ability to host them offline (for ourselves) if we include them.

Let me try out the doxygen to man thing and I'll get back to you. Let me know what you think in the meantime.

https://bugzilla.redhat.com/show_bug.cgi?id=2121585

--- Comment #23 from Benson Muite benson_muite@emailplus.org --- That is awesome. If only other documentation generation tools could also generate man pages. Upstream seems responsive. Perhaps work with them to have the man pages also generated in the Makefile. Probably an option can be passed on what documentation files to generate.

https://bugzilla.redhat.com/show_bug.cgi?id=2121585

--- Comment #25 from Benson Muite benson_muite@emailplus.org --- Should the spec file have a Requires section? Requires brings in dependent packages needed when using Janus. At the moment, only BuildRequires are listed.

Perhaps consider only adding demo files that have minimal Javascript dependencies, or Javascript dependencies that are already packaged?

https://bugzilla.redhat.com/show_bug.cgi?id=2121585

--- Comment #27 from Renich Bon Ciric renich@woralelandia.com --- (In reply to Benson Muite from comment #25)

Should the spec file have a Requires section? Requires brings in dependent packages needed when using Janus. At the moment, only BuildRequires are listed.

Perhaps consider only adding demo files that have minimal Javascript dependencies, or Javascript dependencies that are already packaged?

Hello, Benson.

Well, the tools package has a requirement. Outside of it, janus, mostly, is standalone, AFAIK. I'll double-check, though.

(In reply to Benson Muite from comment #26)

Typically .so files go in -devel packages and are softlinks to .so.* files, this also is true for subpackages.

In this case, remember that the .so files (the versioned ones) are plugins. Very similar to NginX's modules. These are packaged in their respective sub-packages.

I am hoping to add a meta-package so that all plugins can be installed easily.

Issues when running fedora-review: a) Note: Directories without known owners: /usr/include/janus/events, /usr/share/janus/javascript, /usr/lib64/janus/plugins, /usr/lib64/janus/transports, /usr/lib64/janus/events, /usr/lib64/janus/loggers, /usr/share/janus/duktape, /usr/include/janus, /usr/share/janus, /usr/include/janus/loggers, /usr/include/janus/plugins, /usr/include/janus/transports, /usr/lib64/janus, /usr/share/janus/streams, /usr/share/janus/recordings, /etc/janus, /usr/share/janus/lua

Ah, the directories. I will add them. Thanks for htis.

... /builddir/janus-plugins-textroom-debuginfo-1.1.0-1.fc38.x86_64.rpm ERROR: Command failed: # /usr/bin/systemd-nspawn -q -M d79e9c67ebb847689873e491ada18b81 -D /var/lib/mock/fedora-rawhide-x86_64-bootstrap/root -a --capability=cap_ipc_lock --bind=/tmp/mock-resolv.yfyj9_8u:/etc/resolv.conf --console=pipe --setenv=TERM=vt100 --setenv=SHELL=/bin/bash --setenv=HOME=/var/lib/mock/fedora-rawhide-x86_64/root/installation-homedir --setenv=HOSTNAME=mock --setenv=PATH=/usr/bin:/bin:/usr/sbin:/sbin --setenv=PROMPT_COMMAND=printf "\033]0;<mock-chroot>\007" --setenv=PS1=<mock-chroot> \s-\v$ --setenv=LANG=C.UTF-8 --setenv=LC_MESSAGES=C.UTF-8 --resolv-conf=off /usr/bin/dnf --installroot ...

It's not clear to me which command failed here and what the error was. :s

https://bugzilla.redhat.com/show_bug.cgi?id=2121585

--- Comment #29 from Benson Muite benson_muite@emailplus.org --- Ok. Fedora-review has problems with metapackages, so perhaps do that last.

It may be helpful to see the web assets guidelines: https://docs.fedoraproject.org/en-US/packaging-guidelines/JavaScript/

https://bugzilla.redhat.com/show_bug.cgi?id=2121585

--- Comment #31 from Renich Bon Ciric renich@woralelandia.com --- (In reply to Benson Muite from comment #30)

For pulling in the main package dependency, perhaps use: Requires: %{name}%{?_isa} = %{version}-%{release} instead of Requires: %{name} = %{version}

Understood. I will do that today.

https://bugzilla.redhat.com/show_bug.cgi?id=2121585

--- Comment #33 from Renich Bon Ciric renich@woralelandia.com --- Err, sorry; wrong link for the SRPM:

Spec URL: https://fedorapeople.org/~renich/janus/janus.spec SRPM URL: https://fedorapeople.org/~renich/janus/janus-1.1.0-4.fc36.src.rpm

https://bugzilla.redhat.com/show_bug.cgi?id=2121585

--- Comment #35 from Renich Bon Ciric renich@woralelandia.com --- Ah, sorry for that. Made sure no ducplicate files are present anymore. Took the chance to list all files and stop using whole directories. I, also, built it using the fc37 target:

Spec URL: https://fedorapeople.org/~renich/janus/janus.spec SRPM URL: https://fedorapeople.org/~renich/janus/janus-1.1.0-5.fc37.src.rpm

https://bugzilla.redhat.com/show_bug.cgi?id=2121585

--- Comment #37 from Renich Bon Ciric renich@woralelandia.com --- OK, finally, this should be the version that provides all bundled libraries while using jquery in docs and demos. Phew! That took a while.

I've also added a: make check right after build.

Spec URL: https://renich.fedorapeople.org/janus/janus.spec SRPM URL: https://renich.fedorapeople.org/janus/janus-1.1.1-2.fc37.src.rpm

There were a lot of javascript and css resources being pulled from CDNs. I downloaded them all, put them in place and versioned them (because of name clashes between bootstrap-3.4.1 (bootstrap.min.css) and bootswatch-3.4.0 (bootstrap.min.css).

I'll ask upstream to normalize this in the near future.

In any case. Let me know what you think.

https://bugzilla.redhat.com/show_bug.cgi?id=2121585

--- Comment #39 from Renich Bon Ciric renich@woralelandia.com --- Hey Benson!

a) If you do a build in copr, you can get output of fedora-review, see:

OK, I'll try to do this in order to get the review so I can figure out and fix the issues presented.

b) jquery is packaged: https://packages.fedoraproject.org/pkgs/js-jquery/js-jquery/

The spec file has both: Requires: js-jquery and Provides: bundled(js-jquery) = 1.9.1

Is this reasonable? Could only the packaged js-jquery be used?

I think it is. The docs require this old version of jquery (1.9.1 vs 3.6.0 which is what Fedora packaged). Upstream has a ticket where they upgraded to the newest version that didn't break their demos and documentation. I'll propose to upgrade to v3.6.0 and, when they do, update the packages to use what Fedora provides.

I'll remove the Requires js-jquery for now.

Do you agree?

c) None of the other javascript libraries seem to be packaged. Are any of them likely to be used elsewhere? For example boostrap? In which case, could they be packaged separately?

Well, they could be packaged but, for now, I'd like to go with what Petr Mensik suggested here: https://lists.fedoraproject.org/archives/list/packaging@lists.fedoraproject....

I'd like to do exactly that:

* use the bundled js-query when possible (read above). * use bundled() for now and create bug tickets subsequently to create packages for those.

The bootstrap one is a bit tricky. Janus' docs and demos use the ECMAScript part of bootstrap but not the CSS. The CSS is modified and is provided as a theme. That project is called Bootswatch: https://bootswatch.com/

In order to be consistent, I would have to package bootswatch and all the themes for Fedora. I am not saying no but I want to do this in a later occasion.

IMHO, for now, we're good with the bundled() setup and, later on, I will submit packages for each and every one. Well, probably one exception; they use this node-js library from a different project. I would keep that one as bundled().

d) $ rpmlint -e summary-too-long summary-too-long: The 'Summary:' must not exceed 80 characters.

Right on. Will fix the summaries everywhere.

e) Demo and docs packages should probably be marked as noarch

You're correct. I will mark them as so.

f) The cipher warning seems to come from line 491 in src/dtls.c see https://docs.fedoraproject.org/en-US/packaging-guidelines/CryptoPolicies/#_c... Probably an exemption or some coordination will be required with upstream.

I will take this to upstream and see what they say. If that fails, I'll see what I can do with FESCo... if that's where one gets an exception granted. ;D

g) Maybe consider using this for The creative summit instead of Jitsi:

https://communityblog.fedoraproject.org/youre-invited-to-the-creative-freedo... https://fedoraproject.org/wiki/Creative_Freedom_Summit_2023_Schedule Would be happy to create a custom easily packaged theme.

Err... sure. I wouldn't know where to start, hehe. I use janus as part of the communications stack that NextCloud's Talk requires.

Let me know how can I help to do this.

https://bugzilla.redhat.com/show_bug.cgi?id=2121585

--- Comment #41 from Benson Muite benson_muite@emailplus.org --- f) Perhaps ask on Fedora security list: https://lists.fedoraproject.org/admin/lists/security.lists.fedoraproject.org...

Current version fails to build: In file included from /usr/include/curl/curl.h:3195, from turnrest.c:21: turnrest.c: In function 'janus_turnrest_request': turnrest.c:168:9: error: void value not ignored as it ought to be 168 | curl_easy_setopt(curl, api_http_get ? CURLOPT_HTTPGET : CURLOPT_ POST, 1); |

Reported this https://github.com/meetecho/janus-gateway/issues/3131

g) Browsers such as Firefox and Chrome seem to ship with a configuration specifically for Fedora. Maybe we could do the same for janus, have a Fedora themed demo?

https://bugzilla.redhat.com/show_bug.cgi?id=2121585

--- Comment #43 from Renich Bon Ciric renich@woralelandia.com --- Hey Benson! Happy new year and all that. ;D

(In reply to Benson Muite from comment #41)

f) Perhaps ask on Fedora security list: https://lists.fedoraproject.org/admin/lists/security.lists.fedoraproject.org...

OK. I'll take it into account. I'm waiting on upstream to see if a proposed patch fixes stuff. They're checking. I'll consult with the Fedora Security team afterwards.

Current version fails to build: In file included from /usr/include/curl/curl.h:3195, from turnrest.c:21: turnrest.c: In function 'janus_turnrest_request': turnrest.c:168:9: error: void value not ignored as it ought to be 168 | curl_easy_setopt(curl, api_http_get ? CURLOPT_HTTPGET : CURLOPT_ POST, 1); |

Reported this https://github.com/meetecho/janus-gateway/issues/3131

Thank you, so much, for reporting this. I see they've fixed it and I've taken the patch and applied it. Thanks for the help.

g) Browsers such as Firefox and Chrome seem to ship with a configuration specifically for Fedora. Maybe we could do the same for janus, have a Fedora themed demo?

I dunno how this will sit with upstream. They seem interested in their industrial design (or whatever that is called). My take would be to focus on packaging as is and, later on, we could ask upstream about this and see what they think. I'm all for it, though.

So, spec and SRPM:

SPEC: https://renich.fedorapeople.org/janus/janus.spec SRPM: https://renich.fedorapeople.org/janus/janus-1.1.1-4.fc37.src.rpm

I've tested the build with mock; using F37 and F36 profiles. The F37 build finished successfully. The F36 didn't. It reported some "files not found" which is kind of odd since I am using the same SRPM for both (same spec and all).

I get this when trying to build on Fedora 36:

# mock -r fedora-36-x86_64 ... ...

Processing files: janus-doc-1.1.1-4.fc36.noarch error: File not found: /builddir/build/BUILDROOT/janus-1.1.1-4.fc36.x86_64/usr/share/doc/janus/html/bc_sd.png error: File not found: /builddir/build/BUILDROOT/janus-1.1.1-4.fc36.x86_64/usr/share/doc/janus/html/dir_000004_000000.html error: File not found: /builddir/build/BUILDROOT/janus-1.1.1-4.fc36.x86_64/usr/share/doc/janus/html/dir_000004_000001.html error: File not found: /builddir/build/BUILDROOT/janus-1.1.1-4.fc36.x86_64/usr/share/doc/janus/html/dir_000004_000002.html error: File not found: /builddir/build/BUILDROOT/janus-1.1.1-4.fc36.x86_64/usr/share/doc/janus/html/dir_000004_000005.html error: File not found: /builddir/build/BUILDROOT/janus-1.1.1-4.fc36.x86_64/usr/share/doc/janus/html/docd.png error: File not found: /builddir/build/BUILDROOT/janus-1.1.1-4.fc36.x86_64/usr/share/doc/janus/html/nav_fd.png error: File not found: /builddir/build/BUILDROOT/janus-1.1.1-4.fc36.x86_64/usr/share/doc/janus/html/nav_hd.png error: File not found: /builddir/build/BUILDROOT/janus-1.1.1-4.fc36.x86_64/usr/share/doc/janus/html/search/mag.svg error: File not found: /builddir/build/BUILDROOT/janus-1.1.1-4.fc36.x86_64/usr/share/doc/janus/html/search/mag_d.svg error: File not found: /builddir/build/BUILDROOT/janus-1.1.1-4.fc36.x86_64/usr/share/doc/janus/html/search/mag_seld.svg error: File not found: /builddir/build/BUILDROOT/janus-1.1.1-4.fc36.x86_64/usr/share/doc/janus/html/splitbard.png error: File not found: /builddir/build/BUILDROOT/janus-1.1.1-4.fc36.x86_64/usr/share/doc/janus/html/tab_ad.png error: File not found: /builddir/build/BUILDROOT/janus-1.1.1-4.fc36.x86_64/usr/share/doc/janus/html/tab_bd.png error: File not found: /builddir/build/BUILDROOT/janus-1.1.1-4.fc36.x86_64/usr/share/doc/janus/html/tab_hd.png error: File not found: /builddir/build/BUILDROOT/janus-1.1.1-4.fc36.x86_64/usr/share/doc/janus/html/tab_sd.png

RPM build errors: File not found: /builddir/build/BUILDROOT/janus-1.1.1-4.fc36.x86_64/usr/share/doc/janus/html/bc_sd.png File not found: /builddir/build/BUILDROOT/janus-1.1.1-4.fc36.x86_64/usr/share/doc/janus/html/dir_000004_000000.html File not found: /builddir/build/BUILDROOT/janus-1.1.1-4.fc36.x86_64/usr/share/doc/janus/html/dir_000004_000001.html File not found: /builddir/build/BUILDROOT/janus-1.1.1-4.fc36.x86_64/usr/share/doc/janus/html/dir_000004_000002.html File not found: /builddir/build/BUILDROOT/janus-1.1.1-4.fc36.x86_64/usr/share/doc/janus/html/dir_000004_000005.html File not found: /builddir/build/BUILDROOT/janus-1.1.1-4.fc36.x86_64/usr/share/doc/janus/html/docd.png File not found: /builddir/build/BUILDROOT/janus-1.1.1-4.fc36.x86_64/usr/share/doc/janus/html/nav_fd.png File not found: /builddir/build/BUILDROOT/janus-1.1.1-4.fc36.x86_64/usr/share/doc/janus/html/nav_hd.png File not found: /builddir/build/BUILDROOT/janus-1.1.1-4.fc36.x86_64/usr/share/doc/janus/html/search/mag.svg File not found: /builddir/build/BUILDROOT/janus-1.1.1-4.fc36.x86_64/usr/share/doc/janus/html/search/mag_d.svg File not found: /builddir/build/BUILDROOT/janus-1.1.1-4.fc36.x86_64/usr/share/doc/janus/html/search/mag_seld.svg File not found: /builddir/build/BUILDROOT/janus-1.1.1-4.fc36.x86_64/usr/share/doc/janus/html/splitbard.png File not found: /builddir/build/BUILDROOT/janus-1.1.1-4.fc36.x86_64/usr/share/doc/janus/html/tab_ad.png File not found: /builddir/build/BUILDROOT/janus-1.1.1-4.fc36.x86_64/usr/share/doc/janus/html/tab_bd.png File not found: /builddir/build/BUILDROOT/janus-1.1.1-4.fc36.x86_64/usr/share/doc/janus/html/tab_hd.png File not found: /builddir/build/BUILDROOT/janus-1.1.1-4.fc36.x86_64/usr/share/doc/janus/html/tab_sd.png ...

Will investigate further.

https://bugzilla.redhat.com/show_bug.cgi?id=2121585

--- Comment #45 from Jakub Kadlčík jkadlcik@redhat.com --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5200691 (succeeded)

Review template: https://download.copr.fedorainfracloud.org/results/frostyx/fedora-review-212...

Please take a look if any issues were found.

--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service

https://bugzilla.redhat.com/show_bug.cgi?id=2121585

--- Comment #47 from Jakub Kadlčík jkadlcik@redhat.com --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5238279 (succeeded)

Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please take a look if any issues were found.

--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service

https://bugzilla.redhat.com/show_bug.cgi?id=2121585

--- Comment #49 from Renich Bon Ciric renich@woralelandia.com --- OK, i've:

* updated to v1.1.2. * fixed the fc36 issue by selectively grabbing files for the RPM when fc36 is being used to package. * removed the libcurl patch since it's included in upstream.

SPEC: https://renich.fedorapeople.org/janus/janus.spec SRPM: https://renich.fedorapeople.org/janus/janus-1.1.2-1.fc37.src.rpm

Fingers crossed.

https://bugzilla.redhat.com/show_bug.cgi?id=2121585

--- Comment #51 from Jakub Kadlčík jkadlcik@redhat.com --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5300635 (failed)

Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field

--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service

https://bugzilla.redhat.com/show_bug.cgi?id=2121585

--- Comment #53 from Jakub Kadlčík jkadlcik@redhat.com --- Created attachment 1940547 --> https://bugzilla.redhat.com/attachment.cgi?id=1940547&action=edit The .spec file difference from Copr build 5300635 to 5303569

https://bugzilla.redhat.com/show_bug.cgi?id=2121585

--- Comment #55 from Renich Bon Ciric renich@woralelandia.com --- Hello, I'll address the review's rpmlint warnings and errors here:

janus-devel.x86_64: W: only-non-binary-in-usr-lib

There are several files here that might have to be part of the main package, as stated here (from https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages):

"As an additional complication, some software generates unversioned shared objects which are not intended to be used as system libraries. These files are usually plugins or modular functionality specific to an application, and are not located in the ld library paths or cache. This means that they are not located directly in /usr/lib or /usr/lib64, or in a directory listed as a library path in /etc/ld.so.conf (or an /etc/ld.so.conf.d/config file). Usually, these unversioned shared objects can be found in a dedicated subdirectory under /usr/lib or /usr/lib64 (e.g. /usr/lib/purple-2/ is the plugin directory used for libpurple applications). In these cases, the unversioned shared objects do not need to be placed in a -devel package."

In this case, these, in fact, are plugins and do live in a path listed as a library path. They also live in their own subdirectory.

If you agree, I am moving these to the main package. Also, I think, these warnings should be ignored.

janus-demos.noarch: W: no-documentation

There is, in fact, no documentation for demos. It's just an "offline website" that shows a demonstration of the plugin's capabilities. Let me know how to proceed here.

janus-devel.x86_64: W: no-documentation

Devel does have a ton of documentation but it is packaged in the "doc" sub-package. I didn't find anything in the packaging guidelines that says I should forcibly include anything in the devel sub-package. I think this message should be ignored as well. Let me know how to proceed, please.

janus-doc.noarch: W: files-duplicate /usr/share/doc/janus/html/search/variables_10.js /usr/share/doc/janus/html/search/all_10.js

Indeed, I have two cases of "duplicate files" here but this documentation is generated on-the-fly by doxygen. I don't know enough doxygen as to know if I can safely remove or merge these files. Let me know how to proceed with these, please. Nothing in the packaging guidelines either.

I found nothing in the packaging guidelines in regards to duplicate documentation resources. The only duplication subject I could find was in regards to bundled libraries.

janus-doc.noarch: E: file-contains-date-and-time /usr/share/doc/janus/html/recordplay.html janus-doc.noarch: E: file-contains-current-date /usr/share/doc/janus/html/voicemail.html

As mentined above, the documentation package is generated by doxygen. All files will have the current date so, IMHO, that message should be ignored. About the files containing the current date, yes, this is, also, expected.

One curious thing, though. When I run rpmlint against the doc subpackage, I don't get those messages; not even with the `--strict` flag. I wonder if this message is no longer useful and the builder's rpmlint version still has it?

janus.x86_64: W: crypto-policy-non-compliance-openssl /usr/bin/janus SSL_CTX_set_cipher_list

I've talked about this with upstream here: https://groups.google.com/g/meetecho-janus/c/ESCW9mQJpYc/m/YGXU4J0VAwAJ

I've proposed a patch but, as said there, I am not a C developer.

In any case, that conversation fell off. I'm gonna start a thread on their mailing list just about this to see if we can work it out.

janus-plugins-audiobridge.x86_64: W: binary-or-shlib-calls-gethostbyname /usr/lib64/janus/plugins/libjanus_audiobridge.so.1.1.2 janus-plugins-nosip.x86_64: W: binary-or-shlib-calls-gethostbyname /usr/lib64/janus/plugins/libjanus_nosip.so.1.1.2 janus-plugins-sip.x86_64: W: binary-or-shlib-calls-gethostbyname /usr/lib64/janus/plugins/libjanus_sip.so.1.1.2

These I haven't mentioned, I think, to upstream. I'll see if I can get them to switch to getaddrinfo.

https://bugzilla.redhat.com/show_bug.cgi?id=2121585

--- Comment #57 from Renich Bon Ciric renich@woralelandia.com --- (In reply to Benson Muite from comment #56)

a) devel packages should have header files and .so libraries, other library files .so.1 and .so.1.1.2 should be in main packages. Should the plugins have devel packages? If not, plugin libraries should not be on ld path. A method of listing private libraries which may work is described at: https://lists.fedoraproject.org/pipermail/devel/2012-June/169190.html

Hey Benson, nice to read you. :D

Well, I failed to see which the listing method was. I've added the __provides_exclude_from and __requires_exclude_from macros to all .so files to avoid looking for dependencies there since they, indeed, are private libraries. (event handlers, loggers, plugins and transports).

If you think I need to create devel packages for every plugin and include the .so files there, I will. No problem.

I might've understood wrongly what you said.

b) no-documentation warnings are fine

OK. Phew!

c) Ok on duplicates at this point. Can address this after other issues. It is likely there are minor differences in the files.

OK.

d) rpmlint -e file-contains-date-and-time file-contains-date-and-time: Your file uses __DATE__ and __TIME__ which causes the package to rebuild when not needed.

rpmlint -e file-contains-current-date file-contains-current-date: Your file contains the current date, this may cause the package to rebuild in excess.

Doxygen does not add a timestamp: https://github.com/meetecho/janus-gateway/blob/master/docs/janus-doxygen. cfg#L1219 https://github.com/meetecho/janus-gateway/blob/master/docs/janus-doxygen. cfg#L1846

However, footer has a date: https://github.com/meetecho/janus-gateway/blob/master/docs/footer.html#L16

I've created a patch to remove the date from the footer. I'll include it in the next build. Hopefully, that takes care of most of the messages.

For record_play not sure what is causing this error: https://github.com/meetecho/janus-gateway/blob/master/src/plugins/ janus_recordplay.c

I see there is an example date written in an example, right after the note: https://janus.conf.meetecho.com/docs/recordplay.html

That might be triggering the warning, right?

For version, maybe it is better to get GitHub CI to generate this information and have it distributed: https://github.com/meetecho/janus-gateway/blob/master/src/version.h https://stackoverflow.com/questions/1704907/how-can-i-get-my-c-code-to- automatically-print-out-its-git-version-hash/1843783#1843783

version.c gets auto-generated after `make`. it's even ignored in .gitignore to this end. I have no idea of how it gets generated but, when it does, it has the current date.

[root@bc8d0dcfefb2 janus]# cat src/version.c #include "version.h" const char *janus_build_git_sha = "e8d1395d3de9caa5e244605ec1a7281cd7d3ecf1"; const char *janus_build_git_time = "Wed Feb 1 05:08:47 UTC 2023"; int janus_version = 1102; const char *janus_version_string = "1.1.2"; const char *libnice_version_string = "0.1.19";

It seems one can set SOURCE_DATE_EPOCH as an optional parameter before using autogen https://github.com/meetecho/janus-gateway/blob/master/src/Makefile.am#L178 However, having this information in the release would likely enable more efficient automated builds.

I didn't really understand what you meant here. We should pass this SOURCE_DATE_EPOCH env var to autgen? Which date should we provide? The commit's date?

OK, I know where version.c gets generated. Right bellow the link you gave me: https://github.com/meetecho/janus-gateway/blob/master/src/Makefile.am#L183. With gawk. :D

What do we do with this?

e) Raised an issue on gethostbyname https://github.com/meetecho/janus-gateway/issues/3156

Thank you very much for the help. :D

f) Further comments: i) Consider adding make as a build dependency, cmake will bring it in, but one might consider builds without cmake

Done. It's been added to BuildRequires.

ii) Would it be better to use BoringSSL https://boringssl.googlesource.com/boringssl/ instead of OpenSSL

Well, the message in their own website is discouraging. "Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is.". I'd rather stick to openssl unless you think boring is better.

The updated SPEC and SRPM:

SPEC: https://renich.fedorapeople.org/janus/janus.spec SRPM: https://renich.fedorapeople.org/janus/janus-1.1.2-3.fc37.src.rpm

https://bugzilla.redhat.com/show_bug.cgi?id=2121585

--- Comment #59 from Jakub Kadlčík jkadlcik@redhat.com --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5382837 (succeeded)

Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please take a look if any issues were found.

--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service

https://bugzilla.redhat.com/show_bug.cgi?id=2121585

--- Comment #61 from Renich Bon Ciric renich@woralelandia.com --- OK, here's a test. Lorenzo asked us to see if this was enough when it comes to "gethostbyname":

SPEC: https://renich.fedorapeople.org/janus/janus.spec SRPM: https://renich.fedorapeople.org/janus/janus-1.1.2-4.fc37.src.rpm

If all goes well, this should solve the "binary-or-shlib-calls-gethostbyname" issue. Fingers crossed. In my test, it does. ;D

[builder@bldr0 fc-rawhide]$ ls build.log janus-plugins-nosip-1.1.2-4.fc39.x86_64.rpm hw_info.log janus-plugins-nosip-debuginfo-1.1.2-4.fc39.x86_64.rpm installed_pkgs.log janus-plugins-recordplay-1.1.2-4.fc39.x86_64.rpm janus-1.1.2-4.fc39.src.rpm janus-plugins-recordplay-debuginfo-1.1.2-4.fc39.x86_64.rpm janus-1.1.2-4.fc39.x86_64.rpm janus-plugins-sip-1.1.2-4.fc39.x86_64.rpm janus-debuginfo-1.1.2-4.fc39.x86_64.rpm janus-plugins-sip-debuginfo-1.1.2-4.fc39.x86_64.rpm janus-debugsource-1.1.2-4.fc39.x86_64.rpm janus-plugins-streaming-1.1.2-4.fc39.x86_64.rpm janus-demos-1.1.2-4.fc39.noarch.rpm janus-plugins-streaming-debuginfo-1.1.2-4.fc39.x86_64.rpm janus-devel-1.1.2-4.fc39.x86_64.rpm janus-plugins-textroom-1.1.2-4.fc39.x86_64.rpm janus-doc-1.1.2-4.fc39.noarch.rpm janus-plugins-textroom-debuginfo-1.1.2-4.fc39.x86_64.rpm janus-eventhandlers-gelf-1.1.2-4.fc39.x86_64.rpm janus-plugins-videocall-1.1.2-4.fc39.x86_64.rpm janus-eventhandlers-gelf-debuginfo-1.1.2-4.fc39.x86_64.rpm janus-plugins-videocall-debuginfo-1.1.2-4.fc39.x86_64.rpm janus-eventhandlers-mqtt-1.1.2-4.fc39.x86_64.rpm janus-plugins-videoroom-1.1.2-4.fc39.x86_64.rpm janus-eventhandlers-mqtt-debuginfo-1.1.2-4.fc39.x86_64.rpm janus-plugins-videoroom-debuginfo-1.1.2-4.fc39.x86_64.rpm janus-eventhandlers-nanomsg-1.1.2-4.fc39.x86_64.rpm janus-plugins-voicemail-1.1.2-4.fc39.x86_64.rpm janus-eventhandlers-nanomsg-debuginfo-1.1.2-4.fc39.x86_64.rpm janus-plugins-voicemail-debuginfo-1.1.2-4.fc39.x86_64.rpm janus-eventhandlers-rabbitmq-1.1.2-4.fc39.x86_64.rpm janus-tools-1.1.2-4.fc39.x86_64.rpm janus-eventhandlers-rabbitmq-debuginfo-1.1.2-4.fc39.x86_64.rpm janus-tools-debuginfo-1.1.2-4.fc39.x86_64.rpm janus-eventhandlers-sample-1.1.2-4.fc39.x86_64.rpm janus-transports-http-1.1.2-4.fc39.x86_64.rpm janus-eventhandlers-sample-debuginfo-1.1.2-4.fc39.x86_64.rpm janus-transports-http-debuginfo-1.1.2-4.fc39.x86_64.rpm janus-eventhandlers-ws-1.1.2-4.fc39.x86_64.rpm janus-transports-mqtt-1.1.2-4.fc39.x86_64.rpm janus-eventhandlers-ws-debuginfo-1.1.2-4.fc39.x86_64.rpm janus-transports-mqtt-debuginfo-1.1.2-4.fc39.x86_64.rpm janus-loggers-json-1.1.2-4.fc39.x86_64.rpm janus-transports-nanomsg-1.1.2-4.fc39.x86_64.rpm janus-loggers-json-debuginfo-1.1.2-4.fc39.x86_64.rpm janus-transports-nanomsg-debuginfo-1.1.2-4.fc39.x86_64.rpm janus-plugins-audiobridge-1.1.2-4.fc39.x86_64.rpm janus-transports-pfunix-1.1.2-4.fc39.x86_64.rpm janus-plugins-audiobridge-debuginfo-1.1.2-4.fc39.x86_64.rpm janus-transports-pfunix-debuginfo-1.1.2-4.fc39.x86_64.rpm janus-plugins-duktape-1.1.2-4.fc39.x86_64.rpm janus-transports-rabbitmq-1.1.2-4.fc39.x86_64.rpm janus-plugins-duktape-debuginfo-1.1.2-4.fc39.x86_64.rpm janus-transports-rabbitmq-debuginfo-1.1.2-4.fc39.x86_64.rpm janus-plugins-echotest-1.1.2-4.fc39.x86_64.rpm janus-transports-websockets-1.1.2-4.fc39.x86_64.rpm janus-plugins-echotest-debuginfo-1.1.2-4.fc39.x86_64.rpm janus-transports-websockets-debuginfo-1.1.2-4.fc39.x86_64.rpm janus-plugins-lua-1.1.2-4.fc39.x86_64.rpm root.log janus-plugins-lua-debuginfo-1.1.2-4.fc39.x86_64.rpm state.log [builder@bldr0 fc-rawhide]$ rpmlint *.rpm ========================================================================= rpmlint session starts ========================================================================= rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 59

janus-devel.x86_64: W: only-non-binary-in-usr-lib janus-demos.noarch: W: no-documentation janus-devel.x86_64: W: no-documentation janus.x86_64: W: incoherent-version-in-changelog 1.1.2-3 ['1.1.2-4.fc39', '1.1.2-4'] janus-doc.noarch: W: files-duplicate /usr/share/doc/janus/html/search/variables_10.js /usr/share/doc/janus/html/search/all_10.js janus-doc.noarch: W: files-duplicate /usr/share/doc/janus/html/search/variables_a.js /usr/share/doc/janus/html/search/all_a.js janus.x86_64: W: crypto-policy-non-compliance-openssl /usr/bin/janus SSL_CTX_set_cipher_list ========================================= 59 packages and 0 specfiles checked; 0 errors, 7 warnings, 0 badness; has taken 6.3 s ==========================================

https://bugzilla.redhat.com/show_bug.cgi?id=2121585

Jakub Kadlčík jkadlcik@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- URL| |https://janus.conf.meetecho | |.com/

--- Comment #63 from Jakub Kadlčík jkadlcik@redhat.com --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5580064 (succeeded)

Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please take a look if any issues were found.

--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.

https://bugzilla.redhat.com/show_bug.cgi?id=2121585

--- Comment #65 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 1965307 --> https://bugzilla.redhat.com/attachment.cgi?id=1965307&action=edit The .spec file difference from Copr build 5580064 to 5929568

https://bugzilla.redhat.com/show_bug.cgi?id=2121585

--- Comment #67 from Renich Bon Ciric renich@woralelandia.com --- Hello again,

So, I've:

* Updated to v1.2.0. * Removed the audiobridge plugin. * Again, selectively including files generated by doxygen in Fedora 37, 38, 39 and rawhide. * Patched janus so it uses the system's cypher recommendations.

SPEC: https://renich.fedorapeople.org/janus/janus.spec SRPM: https://renich.fedorapeople.org/janus/janus-1.2.0-1.fc40.src.rpm

https://bugzilla.redhat.com/show_bug.cgi?id=2121585

--- Comment #69 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6281436 (succeeded)

Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please take a look if any issues were found.

--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.

https://bugzilla.redhat.com/show_bug.cgi?id=2121585

--- Comment #71 from Benson Muite benson_muite@emailplus.org --- Service file works.

audiobridge plugin seem to be missing.

It may be helpful to get the demo package to explicitly require all needed plugins

May also want to set the folder for the demo package /usr/share/janus/demos to have se-linux context for a webserver httpd_sys_content_t

https://bugzilla.redhat.com/show_bug.cgi?id=2121585

--- Comment #73 from Renich Bon Ciric renich@woralelandia.com --- OK, here's here's what I did:

- Moved .so files into their respective plugins. Plugins don't work without them. - Added lua-json as a dependency for the lua plugin. - Added plugin dependencies to janus-demos. - Added back the audiobridge plugin.

spec: https://renich.fedorapeople.org/janus/janus.spec srpm: https://renich.fedorapeople.org/janus/janus-1.2.0-2.fc38.src.rpm

https://bugzilla.redhat.com/show_bug.cgi?id=2121585

--- Comment #75 from Benson Muite benson_muite@emailplus.org --- For selinux permissions see:

https://fedoraproject.org/wiki/PackagingDrafts/SELinux

Probably does not make sense to create a new policy, since if one wants to run demos, they are read by a web server. Thus add:

Requires(post): policycoreutils-python Requires(postun): policycoreutils-python

...

%post semanage fcontext -a -t httpd_sys_content_t '%{_datadir}/%{name}/demos(/.*)?' 2>/dev/null || : restorecon -R %{_datadir}/awstats/wwwroot/cgi-bin || :

%postun if [ $1 -eq 0 ] ; then # final removal semanage fcontext -d -t httpd_sys_content_t '%{_datadir}/%{name}/demos(/.*)?' 2>/dev/null || : fi

https://bugzilla.redhat.com/show_bug.cgi?id=2121585

--- Comment #77 from Renich Bon Ciric renich@woralelandia.com --- Right on. Had to tweak that a little. The requires is for policycoreutils-python-utils, which would be a kind of a para-palindrome if it was named policycoreutils-python-utilscorepolicy. :D

Bad joke, I know.

Here're the resources:

spec: https://renich.fedorapeople.org/janus/janus.spec srpm: https://renich.fedorapeople.org/janus/janus-1.2.0-3.fc38.src.rpm

A test run and it seems to have worked.

~~~ [renich@desktop rpmbuild]$ sudo dnf --nogpgcheck --repofrompath=local,results/fedora-38-x86_64/ install janus-demos [sudo] password for renich: Sorry, try again. [sudo] password for renich: Added local repo from results/fedora-38-x86_64/ local

1.1 MB/s | 23 kB 00:00 Dependencies resolved. ===================================================================================================================================================================================================================== Package Architecture Version Repository Size ===================================================================================================================================================================================================================== Installing: janus-demos noarch 1.2.0-3.fc38 local 1.3 M Installing dependencies: janus x86_64 1.2.0-3.fc38 local 356 k janus-plugins-audiobridge x86_64 1.2.0-3.fc38 local 122 k janus-plugins-echotest x86_64 1.2.0-3.fc38 local 34 k janus-plugins-recordplay x86_64 1.2.0-3.fc38 local 200 k janus-plugins-sip x86_64 1.2.0-3.fc38 local 97 k janus-plugins-streaming x86_64 1.2.0-3.fc38 local 4.0 M janus-plugins-textroom x86_64 1.2.0-3.fc38 local 55 k janus-plugins-videocall x86_64 1.2.0-3.fc38 local 39 k janus-plugins-videoroom x86_64 1.2.0-3.fc38 local 159 k sofia-sip x86_64 1.13.13-1.fc38 fedora 619 k usrsctp x86_64 1:0.9.5.0-6.fc38 fedora 258 k

Transaction Summary ===================================================================================================================================================================================================================== Install 12 Packages

Total size: 7.2 M Total download size: 877 k Installed size: 12 M Is this ok [y/N]: y Downloading Packages: (1/2): usrsctp-0.9.5.0-6.fc38.x86_64.rpm

147 kB/s | 258 kB 00:01 (2/2): sofia-sip-1.13.13-1.fc38.x86_64.rpm

274 kB/s | 619 kB 00:02 --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- Total

300 kB/s | 877 kB 00:02 Running transaction check Transaction check succeeded. Running transaction test Transaction test succeeded. Running transaction Preparing :

1/1 Installing : usrsctp-1:0.9.5.0-6.fc38.x86_64

1/12 Running scriptlet: janus-1.2.0-3.fc38.x86_64

2/12 Installing : janus-1.2.0-3.fc38.x86_64

2/12 Running scriptlet: janus-1.2.0-3.fc38.x86_64

2/12 Installing : janus-plugins-audiobridge-1.2.0-3.fc38.x86_64

3/12 Installing : janus-plugins-echotest-1.2.0-3.fc38.x86_64

4/12 Installing : janus-plugins-recordplay-1.2.0-3.fc38.x86_64

5/12 Installing : janus-plugins-streaming-1.2.0-3.fc38.x86_64

6/12 Installing : janus-plugins-textroom-1.2.0-3.fc38.x86_64

7/12 Installing : janus-plugins-videocall-1.2.0-3.fc38.x86_64

8/12 Installing : janus-plugins-videoroom-1.2.0-3.fc38.x86_64

9/12 Installing : sofia-sip-1.13.13-1.fc38.x86_64

10/12 Installing : janus-plugins-sip-1.2.0-3.fc38.x86_64

11/12 Installing : janus-demos-1.2.0-3.fc38.noarch

12/12 Running scriptlet: janus-demos-1.2.0-3.fc38.noarch

12/12 Verifying : sofia-sip-1.13.13-1.fc38.x86_64

1/12 Verifying : usrsctp-1:0.9.5.0-6.fc38.x86_64

2/12 Verifying : janus-1.2.0-3.fc38.x86_64

3/12 Verifying : janus-demos-1.2.0-3.fc38.noarch

4/12 Verifying : janus-plugins-audiobridge-1.2.0-3.fc38.x86_64

5/12 Verifying : janus-plugins-echotest-1.2.0-3.fc38.x86_64

6/12 Verifying : janus-plugins-recordplay-1.2.0-3.fc38.x86_64

7/12 Verifying : janus-plugins-sip-1.2.0-3.fc38.x86_64

8/12 Verifying : janus-plugins-streaming-1.2.0-3.fc38.x86_64

9/12 Verifying : janus-plugins-textroom-1.2.0-3.fc38.x86_64

10/12 Verifying : janus-plugins-videocall-1.2.0-3.fc38.x86_64

11/12 Verifying : janus-plugins-videoroom-1.2.0-3.fc38.x86_64

12/12

Installed: janus-1.2.0-3.fc38.x86_64 janus-demos-1.2.0-3.fc38.noarch janus-plugins-audiobridge-1.2.0-3.fc38.x86_64 janus-plugins-echotest-1.2.0-3.fc38.x86_64 janus-plugins-recordplay-1.2.0-3.fc38.x86_64 janus-plugins-sip-1.2.0-3.fc38.x86_64 janus-plugins-streaming-1.2.0-3.fc38.x86_64 janus-plugins-textroom-1.2.0-3.fc38.x86_64 janus-plugins-videocall-1.2.0-3.fc38.x86_64 janus-plugins-videoroom-1.2.0-3.fc38.x86_64 sofia-sip-1.13.13-1.fc38.x86_64 usrsctp-1:0.9.5.0-6.fc38.x86_64

Complete! [renich@desktop rpmbuild]$ ll -Z /usr/share/janus/demos/ total 956 drwxr-xr-x. 1 root root system_u:object_r:httpd_sys_content_t:s0 92 Sep 15 17:36 background drwxr-xr-x. 1 root root system_u:object_r:httpd_sys_content_t:s0 176 Sep 15 17:36 css drwxr-xr-x. 1 root root system_u:object_r:httpd_sys_content_t:s0 20 Sep 15 17:36 docs drwxr-xr-x. 1 root root system_u:object_r:httpd_sys_content_t:s0 482 Sep 15 17:36 js drwxr-xr-x. 1 root root system_u:object_r:httpd_sys_content_t:s0 72 Sep 15 17:36 surround -rw-r--r--. 1 root root system_u:object_r:httpd_sys_content_t:s0 9225 Sep 14 18:00 admin.html -rw-r--r--. 1 root root system_u:object_r:httpd_sys_content_t:s0 52489 Sep 14 18:00 admin.js -rw-r--r--. 1 root root system_u:object_r:httpd_sys_content_t:s0 4750 Sep 14 18:00 audiobridgetest.html -rw-r--r--. 1 root root system_u:object_r:httpd_sys_content_t:s0 17812 Sep 14 18:00 audiobridgetest.js -rw-r--r--. 1 root root system_u:object_r:httpd_sys_content_t:s0 7847 Sep 14 18:00 canvas.html -rw-r--r--. 1 root root system_u:object_r:httpd_sys_content_t:s0 24660 Sep 14 18:00 canvas.js -rw-r--r--. 1 root root system_u:object_r:httpd_sys_content_t:s0 6023 Sep 14 18:00 citeus.html -rw-r--r--. 1 root root system_u:object_r:httpd_sys_content_t:s0 4922 Sep 14 18:00 demos.html -rw-r--r--. 1 root root system_u:object_r:httpd_sys_content_t:s0 6893 Sep 14 18:00 devicetest.html -rw-r--r--. 1 root root system_u:object_r:httpd_sys_content_t:s0 30010 Sep 14 18:00 devicetest.js -rw-r--r--. 1 root root system_u:object_r:httpd_sys_content_t:s0 6343 Sep 14 18:00 e2etest.html -rw-r--r--. 1 root root system_u:object_r:httpd_sys_content_t:s0 29170 Sep 14 18:00 e2etest.js -rw-r--r--. 1 root root system_u:object_r:httpd_sys_content_t:s0 7562 Sep 14 18:00 echotest.html -rw-r--r--. 1 root root system_u:object_r:httpd_sys_content_t:s0 28294 Sep 14 18:00 echotest.js -rw-r--r--. 1 root root system_u:object_r:httpd_sys_content_t:s0 1150 Sep 14 18:00 favicon.ico -rw-r--r--. 1 root root system_u:object_r:httpd_sys_content_t:s0 92 Sep 14 18:00 footer.html -rw-r--r--. 1 root root system_u:object_r:httpd_sys_content_t:s0 7327 Sep 14 18:00 forkme_left_darkblue_121621.png -rw-r--r--. 1 root root system_u:object_r:httpd_sys_content_t:s0 3348 Sep 14 18:00 index.html -rw-r--r--. 1 root root system_u:object_r:httpd_sys_content_t:s0 113533 Sep 14 18:00 janus.js -rw-r--r--. 1 root root system_u:object_r:httpd_sys_content_t:s0 20596 Sep 14 18:00 janus-logo.png -rw-r--r--. 1 root root system_u:object_r:httpd_sys_content_t:s0 20535 Sep 14 18:00 janus-logo-small.png -rw-r--r--. 1 root root system_u:object_r:httpd_sys_content_t:s0 9574 Sep 14 18:00 meetecho-logo.png -rw-r--r--. 1 root root system_u:object_r:httpd_sys_content_t:s0 7300 Sep 14 18:00 multiopus.html -rw-r--r--. 1 root root system_u:object_r:httpd_sys_content_t:s0 23485 Sep 14 18:00 multiopus.js -rw-r--r--. 1 root root system_u:object_r:httpd_sys_content_t:s0 6697 Sep 14 18:00 mvideoroomtest.html -rw-r--r--. 1 root root system_u:object_r:httpd_sys_content_t:s0 45364 Sep 14 18:00 mvideoroomtest.js -rw-r--r--. 1 root root system_u:object_r:httpd_sys_content_t:s0 2433 Sep 14 18:00 navbar.html -rw-r--r--. 1 root root system_u:object_r:httpd_sys_content_t:s0 4965 Sep 14 18:00 nosiptest.html -rw-r--r--. 1 root root system_u:object_r:httpd_sys_content_t:s0 19972 Sep 14 18:00 nosiptest.js -rw-r--r--. 1 root root system_u:object_r:httpd_sys_content_t:s0 5202 Sep 14 18:00 recordplaytest.html -rw-r--r--. 1 root root system_u:object_r:httpd_sys_content_t:s0 22786 Sep 14 18:00 recordplaytest.js -rw-r--r--. 1 root root system_u:object_r:httpd_sys_content_t:s0 5332 Sep 14 18:00 screensharingtest.html -rw-r--r--. 1 root root system_u:object_r:httpd_sys_content_t:s0 21535 Sep 14 18:00 screensharingtest.js -rw-r--r--. 1 root root system_u:object_r:httpd_sys_content_t:s0 4191 Sep 14 18:00 settings.js -rw-r--r--. 1 root root system_u:object_r:httpd_sys_content_t:s0 7306 Sep 14 18:00 siptest.html -rw-r--r--. 1 root root system_u:object_r:httpd_sys_content_t:s0 72555 Sep 14 18:00 siptest.js -rw-r--r--. 1 root root system_u:object_r:httpd_sys_content_t:s0 4608 Sep 14 18:00 streamingtest.html -rw-r--r--. 1 root root system_u:object_r:httpd_sys_content_t:s0 33360 Sep 14 18:00 streamingtest.js -rw-r--r--. 1 root root system_u:object_r:httpd_sys_content_t:s0 3555 Sep 14 18:00 support.html -rw-r--r--. 1 root root system_u:object_r:httpd_sys_content_t:s0 5219 Sep 14 18:00 textroomtest.html -rw-r--r--. 1 root root system_u:object_r:httpd_sys_content_t:s0 14063 Sep 14 18:00 textroomtest.js -rw-r--r--. 1 root root system_u:object_r:httpd_sys_content_t:s0 2611 Sep 14 18:00 up_arrow.png -rw-r--r--. 1 root root system_u:object_r:httpd_sys_content_t:s0 7959 Sep 14 18:00 videocalltest.html -rw-r--r--. 1 root root system_u:object_r:httpd_sys_content_t:s0 32457 Sep 14 18:00 videocalltest.js -rw-r--r--. 1 root root system_u:object_r:httpd_sys_content_t:s0 8223 Sep 14 18:00 videoroomtest.html -rw-r--r--. 1 root root system_u:object_r:httpd_sys_content_t:s0 41665 Sep 14 18:00 videoroomtest.js -rw-r--r--. 1 root root system_u:object_r:httpd_sys_content_t:s0 5409 Sep 14 18:00 virtualbg.html -rw-r--r--. 1 root root system_u:object_r:httpd_sys_content_t:s0 26122 Sep 14 18:00 virtualbg.js -rw-r--r--. 1 root root system_u:object_r:httpd_sys_content_t:s0 5274 Sep 14 18:00 webaudio.html -rw-r--r--. 1 root root system_u:object_r:httpd_sys_content_t:s0 13494 Sep 14 18:00 webaudio.js ~~~

https://bugzilla.redhat.com/show_bug.cgi?id=2121585

--- Comment #79 from Benson Muite benson_muite@emailplus.org --- html documentation downloads javascript and css files from Cloudflare, yet most of them are packaged.

Demo files try to read /usr/share/font-awesome-web/css/ which will typically not be available when the demos are accessed from a remote website.

https://bugzilla.redhat.com/show_bug.cgi?id=2121585

--- Comment #81 from Benson Muite benson_muite@emailplus.org --- A description of steps have taken to deploy Janus: https://github.com/nairobilug/nairobilug.or.ke/pull/201/files

Some web applications like Apache or Nginx can run directly when installed. For Janus, choices of configuration options make this more difficult. One could enable all transports, but STUN server choice should be set by the person deploying. May want to examine choices made in other distros. Will see if can add more documentation to the .jcfg files upstream. It may be helpful to package some of the additional Javascript files and remove non-essential ones from the demos. FEdora had jquery 1:

https://src.fedoraproject.org/rpms/js-jquery1/blob/f32/f/js-jquery1.spec And has newer versions: https://src.fedoraproject.org/rpms/js-jquery https://src.fedoraproject.org/rpms/js-jquery2 Will see if can make a pull request upstream

https://bugzilla.redhat.com/show_bug.cgi?id=2121585

--- Comment #83 from Benson Muite benson_muite@emailplus.org --- Pull request to use newer versions of jquery and other external assets: https://github.com/meetecho/janus-gateway/pull/3279