https://bugzilla.redhat.com/show_bug.cgi?id=1590417
Bug ID: 1590417 Summary: Review Request: kata-ksm-throttler - Kata ksm throttler Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: lsm5@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://pagure.io/kata-ksm-throttler/blob/master/f/kata-ksm-throttler.spec SRPM URL: TBD Description: TBD Fedora Account System Username: lsm5
https://bugzilla.redhat.com/show_bug.cgi?id=1590417
Lokesh Mandvekar lsm5@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1585446 | |(FEDORA_KATA_TRACKER)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1585446 [Bug 1585446] Kata Containers Package Review Tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1590417
Lokesh Mandvekar lsm5@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Alias| |FEDORA_KATA_KSM_THROTTLER
https://bugzilla.redhat.com/show_bug.cgi?id=1590417
--- Comment #1 from Lokesh Mandvekar lsm5@redhat.com --- Spec URL: https://pagure.io/kata-rpm-reviews/blob/master/f/kata-ksm-throttler/kata-ksm... SRPM URL: https://pagure.io/kata-rpm-reviews/blob/master/f/kata-ksm-throttler/SRPMS/ka...
Description: This project implements a Kernel Same-page Merging throttling daemon.
Its goal is to regulate KSM by dynamically modifying the KSM sysfs entries, in order to minimize memory duplication as fast as possible while keeping the KSM daemon load low.
Koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=27608195
$ rpmlint -i kata-ksm-throttler.spec RPMS/* SRPMS/kata-ksm-throttler-1.0.0-1.gitaa4d33d.fc28.src.rpm 4 packages and 1 specfiles checked; 0 errors, 0 warnings.
https://bugzilla.redhat.com/show_bug.cgi?id=1590417
Lokesh Mandvekar lsm5@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |fkluknav@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=1590417
Lokesh Mandvekar lsm5@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1590417
Margaret LaBrecque margaret.labrecque@intel.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW CC| |lsm5@redhat.com, | |margaret.labrecque@intel.co | |m Flags| |needinfo?(lsm5@redhat.com)
--- Comment #2 from Margaret LaBrecque margaret.labrecque@intel.com --- Could you update the target Fedora release? What kind of testing will Red Hat do when they put this in Fedora? will you attach your test results to the BZ?
https://bugzilla.redhat.com/show_bug.cgi?id=1590417
Lokesh Mandvekar lsm5@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(lsm5@redhat.com) |
--- Comment #3 from Lokesh Mandvekar lsm5@redhat.com --- See https://bugzilla.redhat.com/show_bug.cgi?id=1590414#c2
https://bugzilla.redhat.com/show_bug.cgi?id=1590417
--- Comment #4 from Lokesh Mandvekar lsm5@redhat.com --- Spec URL: https://pagure.io/kata-rpm-reviews/blob/master/f/kata-ksm-throttler/kata-ksm... SRPM URL: https://copr-be.cloud.fedoraproject.org/results/lsm5/kata/fedora-rawhide-x86...
* Sat Nov 10 2018 Lokesh Mandvekar lsm5@fedoraproject.org - 1.3.1-1.git6e903fb - bump to v1.3.1 - built commit 6e903fb
https://bugzilla.redhat.com/show_bug.cgi?id=1590417
--- Comment #5 from Lokesh Mandvekar lsm5@redhat.com --- Spec URL: https://pagure.io/kata-rpm-reviews/blob/master/f/kata-ksm-throttler/kata-ksm... SRPM URL: https://copr-be.cloud.fedoraproject.org/results/lsm5/kata/fedora-rawhide-x86...
* Sat Nov 10 2018 Lokesh Mandvekar lsm5@fedoraproject.org - 1.3.1-1.git6e903fb - bump to v1.3.1 - built commit 6e903fb
https://bugzilla.redhat.com/show_bug.cgi?id=1590417
--- Comment #6 from Lokesh Mandvekar lsm5@redhat.com --- Spec URL: https://pagure.io/kata-rpm-reviews/blob/master/f/kata-ksm-throttler/kata-ksm... SRPM URL: https://copr-be.cloud.fedoraproject.org/results/lsm5/kata/fedora-rawhide-x86...
https://bugzilla.redhat.com/show_bug.cgi?id=1590417
Lokesh Mandvekar lsm5@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED
--- Comment #7 from Lokesh Mandvekar lsm5@redhat.com --- Spec URL: https://pagure.io/kata-rpm-reviews/raw/master/f/kata-ksm-throttler/kata-ksm-... SRPM URL: https://copr-be.cloud.fedoraproject.org/results/lsm5/kata/fedora-rawhide-x86...
https://bugzilla.redhat.com/show_bug.cgi?id=1590417
--- Comment #8 from Frantisek Kluknavsky fkluknav@redhat.com --- MUST: rpmlint must be run on the source rpm and all binary rpms the build produces. The output should be posted in the review: kata-ksm-throttler.src: E: unknown-key RSA#8055c25b (MD5 kata-ksm-throttler.x86_64: E: unknown-key RSA#8055c25b (MD5 kata-ksm-throttler-debuginfo.x86_64: E: useless-provides debuginfo(build-id) kata-ksm-throttler-debuginfo.x86_64: E: unknown-key RSA#8055c25b (MD5 kata-ksm-throttler-debugsource.x86_64: W: no-documentation kata-ksm-throttler-debugsource.x86_64: E: unknown-key RSA#8055c25b (MD5 4 packages and 1 specfiles checked; 5 errors, 1 warnings. All of the warnings seem irrelevant.
MUST: If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in bugzilla, describing the reason that the package does not compile/build/work on that architecture. The bug number MUST be placed in a comment, next to the corresponding ExcludeArch line.
https://bugzilla.redhat.com/show_bug.cgi?id=1590417
Frantisek Kluknavsky fkluknav@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #9 from Frantisek Kluknavsky fkluknav@redhat.com --- fedora-review also did not found any defects. Other than the exclusive architecture, looks good to me.
https://bugzilla.redhat.com/show_bug.cgi?id=1590417
--- Comment #10 from Lokesh Mandvekar lsm5@redhat.com --- instead of excludearch, we have included exclusivearch: x86_64 since other arches aren't supported at this time afaik.
Frantisek, thanks for the review and approval.
https://bugzilla.redhat.com/show_bug.cgi?id=1590417
--- Comment #11 from Gwyn Ciesla limburgher@gmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/kata-ksm-throttler
package-review@lists.fedoraproject.org