https://bugzilla.redhat.com/show_bug.cgi?id=1750506
Artur Iwicki <fedora(a)svgames.pl> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |fedora(a)svgames.pl
--- Comment #5 from Artur Iwicki <fedora(a)svgames.pl> ---
License: GNU 2
"GNU" is not a licence, though they
did publish the rather popular GNU General
Public License. ;)
The upstream readme says it's GPL 2 or later, so you should use "GPLv2+"
here.
https://fedoraproject.org/wiki/Licensing:Main#Good_Licenses
%description
[...long text here...]
You need to manually wrap the description text so that each
line has no more
than 80 characters.
%files
%{_datadir}/applications/hasciicam.desktop
You should add "BuildRequires:
desktop-file-utils" to the spec and run
"desktop-file-validate" on the .desktop file (preferably during %check).
%files
%{_datadir}/icons/hasciicam.png
I'm not entirely sure about this, but the icon
should go in
"%{_datadir}/icons/hicolor/$SIZE/apps/", or alternatively
"%{_datadir}/pixmaps/".
You can either patch the build files or move the file in %install.
%files
%{_mandir}/man1/hasciicam.1.gz
Do not assume that man pages will be gzip-compressed.
Use a wildcard here.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_manpages
%files
%doc README AUTHORS COPYING NEWS TODO ChangeLog
The COPYING file should be marked as
"%license", not "%doc".
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component