Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Merge Review: junit

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225954

------- Additional Comments From tbento@redhat.com 2007-02-09 16:17 EST ------- Created an attachment (id=147809) --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=147809&action=vie...) Spec File

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Merge Review: junit

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225954

tbento@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |tbento@redhat.com

------- Additional Comments From tbento@redhat.com 2007-02-09 16:58 EST ------- Here are a list to my changes:

- I changed the License to CPL, because the Packaging Guidelines states that we should use standard abbreviations and rpmlint generated a warning stating that "Common Public License" was not recognized.

- I changed the Group to Development/Tools/Java from Development/Testing, as was suggested by Tom.

- I switched the source back to junit3.8-2.zip because someone was misinformed and had removed all the binaries.

- I removed "-rm -rf $RPM_BUILD_ROOT" from the %prep section because rpmlint generated a warning stating that $RPM_BUILD_ROOT should not be touched in the prep stage because it will break short circuiting .

- I added "-rm -rf $RPM_BUILD_ROOT" to the %install section because rpmlint generated an error stating that we should clean $RPM_BUILD_ROOT this section.

- The %post and %postun sections for demo were removed because they were causing an error while building.

- I had to "escape" the macros used in the %changelog because macros are expanded in the %changelog section.

- The --excludes were added to aot-compile-rpm to solve a building error.

If someone could kindly review this, that would be great. Thanks. Tania

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Merge Review: junit

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225954

fitzsim@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review?

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Merge Review: junit

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225954

fitzsim@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+

------- Additional Comments From fitzsim@redhat.com 2007-02-12 18:52 EST ------- I see you were just running untabify. I made a few more small changes and committed this on your behalf.

$ rpmlint /home/fitzsim/sources/rpms/junit/devel/i386/junit-demo-3.8.2-3jpp.1.i386.rpm W: junit-demo no-documentation

OK because this is a sub-package and the base package contains documentation.

$ rpm -qp --provides /home/fitzsim/sources/rpms/junit/devel/i386/junit-3.8.2-3jpp.1.i386.rpm junit-3.8.2.jar.so junit = 3.8.2-3jpp.1

$ rpm -qp --requires /home/fitzsim/sources/rpms/junit/devel/i386/junit-3.8.2-3jpp.1.i386.rpm /bin/sh /bin/sh java-gcj-compat java-gcj-compat libc.so.6 libc.so.6(GLIBC_2.1.3) libdl.so.2 libgcc_s.so.1 libgcc_s.so.1(GCC_3.0) libgcj_bc.so.1 libm.so.6 libpthread.so.0 librt.so.1 libz.so.1 rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rtld(GNU_HASH)

$ rpm -qp --provides /home/fitzsim/sources/rpms/junit/devel/i386/junit-manual-3.8.2-3jpp.1.i386.rpm junit-manual = 3.8.2-3jpp.1

$ rpm -qp --requires /home/fitzsim/sources/rpms/junit/devel/i386/junit-manual-3.8.2-3jpp.1.i386.rpm rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1

$ rpm -qp --provides /home/fitzsim/sources/rpms/junit/devel/i386/junit-javadoc-3.8.2-3jpp.1.i386.rpm junit-javadoc = 3.8.2-3jpp.1

$ rpm -qp --requires /home/fitzsim/sources/rpms/junit/devel/i386/junit-javadoc-3.8.2-3jpp.1.i386.rpm rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1

$ rpm -qp --requires /home/fitzsim/sources/rpms/junit/devel/i386/junit-demo-3.8.2-3jpp.1.i386.rpm java-gcj-compat java-gcj-compat junit = 3.8.2-3jpp.1 rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1

$ rpm -qp --provides /home/fitzsim/sources/rpms/junit/devel/i386/junit-demo-3.8.2-3jpp.1.i386.rpm junit-demo = 3.8.2-3jpp.1

$ rpm -qp --provides /home/fitzsim/sources/rpms/junit/devel/i386/junit-debuginfo-3.8.2-3jpp.1.i386.rpmjunit-3.8.2.jar.so.debug

junit-debuginfo = 3.8.2-3jpp.1

$ rpm -qp --requires /home/fitzsim/sources/rpms/junit/devel/i386/junit-debuginfo-3.8.2-3jpp.1.i386.rpm rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1

APPROVED.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=225954

Alexander Kurtakov akurtako@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |akurtako@redhat.com

--- Comment #6 from Alexander Kurtakov akurtako@redhat.com 2009-10-01 03:51:18 EDT --- This package is approved. Can we close the Merge review now?