Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: gerris - computational fluid dynamics flow solver
https://bugzilla.redhat.com/show_bug.cgi?id=766883
Summary: Review Request: gerris - computational fluid dynamics flow solver Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: jonathan.underwood@gmail.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: ---
Spec URL: http://fedorapeople.org/~jgu/gerris.spec SRPM URL: http://fedorapeople.org/~jgu/gerris-1.3.2-3.20111123.el6.src.rpm Description: Gerris is an Open Source Free Software library for the solution of the partial differential equations describing fluid flow.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=766883
Jussi Lehtola jussi.lehtola@iki.fi changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jussi.lehtola@iki.fi
--- Comment #1 from Jussi Lehtola jussi.lehtola@iki.fi 2011-12-13 05:42:50 EST --- You're building an MPI version, so you need to comply to the MPI guidelines http://fedoraproject.org/wiki/Packaging/MPI
regarding the placement of libraries and binaries.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=766883
--- Comment #2 from Jonathan Underwood jonathan.underwood@gmail.com 2011-12-13 19:03:09 EST --- Those guidelines must have been written by someone on crack, seriously.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=766883
--- Comment #3 from Jonathan Underwood jonathan.underwood@gmail.com 2012-02-02 09:48:34 EST --- Spec URL: http://fedorapeople.org/~jgu/gerris.spec SRPM URL: http://fedorapeople.org/~jgu/gerris-1.3.2-4.20111123.el6.src.rpm
OK, new version of the packages which properly build -openmpi and -mpich2 subpackages complying with the MPI packaging guidelines (as far as I can tell).
A key change here is that I no longer split out -libs and -devel subpackages since the main runtime actually requires both the -devel and -libs packages if I go that route - gerris performs on-the-fly compilation of functions, and the upstream maintainer recommended not splitting them out:
https://groups.google.com/group/gerris-devel/browse_thread/thread/5fc0c66332...
The only possible advantage to splitting out the -devel and -libs packages is for other programs to build against, but the binary runtimes are so small that I really don't think this is useful (as we'd then end up with 10 instead of 4 subpackages).
At this point I have this building on RHEL6 but haven't had chance to build on rawhide yet.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=766883
--- Comment #4 from Jonathan Underwood jonathan.underwood@gmail.com 2012-02-04 18:33:08 EST --- Updated package with a few fixes:
Spec URL: http://fedorapeople.org/~jgu/gerris.spec SRPM URL: http://fedorapeople.org/~jgu/gerris-1.3.2-6.20111123.el6.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=766883
Jonathan Underwood jonathan.underwood@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |787414
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=766883
Jason Tibbitts tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(jonathan.underwoo | |d@gmail.com)
--- Comment #5 from Jason Tibbitts tibbs@math.uh.edu --- I am triaging old review tickets. I can't promise a review if you reply, but by closing out the stale tickets we can devote extra attention to the ones which aren't stale.
This one fails to build for me, due to come autoconf issues. Here's a scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5319486
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=766883
Jonathan Underwood jonathan.underwood@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(jonathan.underwoo | |d@gmail.com) |
--- Comment #6 from Jonathan Underwood jonathan.underwood@gmail.com --- Our local needs for this package have dropped for this, so I don't forsee having time to work on it until after July, at which point I'll pick it up. Feel free to close it, or leave it open.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=766883
Jason Tibbitts tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Whiteboard| |NotReady
--- Comment #7 from Jason Tibbitts tibbs@math.uh.edu --- Having the ticket visible with nothing to review wastes reviewer time looking at it, to the point that most people don't bother looking at old tickets because most of them aren't reviewable.
I guess I'll stick NotReady in the whiteboard so it at least drops out of the reports.
https://bugzilla.redhat.com/show_bug.cgi?id=766883
Dominik 'Rathann' Mierzejewski dominik@greysector.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |505154 (FE-SCITECH)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=505154 [Bug 505154] Tracker: Review Requests for Science and Technology related packages
https://bugzilla.redhat.com/show_bug.cgi?id=766883
James Hogarth james.hogarth@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED CC| |james.hogarth@gmail.com Blocks| |201449 (FE-DEADREVIEW) Resolution|--- |NOTABUG Last Closed| |2015-12-03 22:29:50
--- Comment #8 from James Hogarth james.hogarth@gmail.com --- I'm closing this bug as a stalled review so that anyone else interested can pick it up. This follows on from the requesters comment in 6.
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=201449 [Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response should be blocking this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=766883
James Hogarth james.hogarth@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks|787414 |
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=787414 [Bug 787414] Review Request: gfsview - A visualizer for Gerris simulations
https://bugzilla.redhat.com/show_bug.cgi?id=766883
Susi Lehtola susi.lehtola@iki.fi changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks|505154 (FE-SCITECH) |
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=505154 [Bug 505154] Tracker: Review Requests for Science and Technology related packages
package-review@lists.fedoraproject.org