https://bugzilla.redhat.com/show_bug.cgi?id=1079615
Petr Pisar <ppisar(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #3 from Petr Pisar <ppisar(a)redhat.com> ---
Spec file changes:
diff -u perl-MooX-HandlesVia.spec{.old,}
--- perl-MooX-HandlesVia.spec.old 2014-03-22 05:51:56.000000000 +0100
+++ perl-MooX-HandlesVia.spec 2014-03-25 18:07:47.000000000 +0100
@@ -1,6 +1,6 @@
Name: perl-MooX-HandlesVia
Version: 0.001005
-Release: 1%{?dist}
+Release: 2%{?dist}
Summary: NativeTrait-like behavior for Moo
License: GPL+ or Artistic
Group: Development/Libraries
@@ -9,17 +9,30 @@
BuildArch: noarch
BuildRequires: perl(Class::Method::Modifiers)
BuildRequires: perl(Data::Perl) >= 0.002006
-BuildRequires: perl(ExtUtils::MakeMaker)
+BuildRequires: perl(ExtUtils::MakeMaker) >= 6.30
BuildRequires: perl(Module::Runtime)
BuildRequires: perl(Moo) >= 1.003000
+BuildRequires: perl(Moo::Role)
BuildRequires: perl(MooX::Types::MooseLike::Base) >= 0.23
-BuildRequires: perl(Role::Tiny)
BuildRequires: perl(Role::Tiny::With)
BuildRequires: perl(Test::Exception)
BuildRequires: perl(Test::Fatal)
BuildRequires: perl(Test::More)
BuildRequires: perl(namespace::autoclean)
+BuildRequires: perl(namespace::clean)
+BuildRequires: perl(overload)
+BuildRequires: perl(strict)
BuildRequires: perl(strictures) >= 1
+BuildRequires: perl(warnings)
+
+# Redundant to BR: perl(Data::Perl)
+BuildRequires: perl(Data::Perl::Role::Bool)
+BuildRequires: perl(Data::Perl::Role::Code)
+BuildRequires: perl(Data::Perl::Role::Collection::Array)
+BuildRequires: perl(Data::Perl::Role::Collection::Hash)
+BuildRequires: perl(Data::Perl::Role::Counter)
+BuildRequires: perl(Data::Perl::Role::Number)
+BuildRequires: perl(Data::Perl::Role::String)
Requires: perl(Data::Perl) >= 0.002006
Requires: perl(Moo) >= 1.003000
@@ -50,10 +63,14 @@
make test
%files
-%doc Changes dist.ini LICENSE META.json README README.mkdn TODO
+%doc Changes LICENSE README TODO
%{perl_vendorlib}/*
%{_mandir}/man3/*
%changelog
+* Tue Mar 25 2014 Ralf Corsépius <corsepiu(a)fedoraproject.org> 0.001005-2
+- Reflect review.
+- Do not package dist.ini, README.mkdn, META.json.
+
* Fri Mar 21 2014 Ralf Corsépius <corsepiu(a)fedoraproject.org> 0.001005-1
- Initial Fedora package.
TODO: I would speel `NativeTrait-like' as `Native-trait-like'
or
`NativeTraits-like' because `NativeTrait' is neither word nor Moose term
(MouseX::NativeTraits).
Not addressed. Ok.
TODO: You can replace `PERL_INSTALL_ROOT' with `DESTDIR'
argument in the
%install section.
Not addressed. Ok.
TODO: Package either README or README.mkdn. They are redundant.
TODO: Do not package dist.ini. There is nothing spectacular for the end users
besides the git URL.
-%doc Changes dist.ini LICENSE META.json README README.mkdn
TODO
+%doc Changes LICENSE README TODO
Ok.
TODO: Constrain `BuildRequire: perl(ExtUtils::MakeMaker)' with
`>= 6.30'
(Makefile.PL:7).
-BuildRequires: perl(ExtUtils::MakeMaker)
+BuildRequires: perl(ExtUtils::MakeMaker) >= 6.30
Ok.
TODO: You should build-require both `perl(namespace::clean)' and
`perl(namespace::autoclean)', or none for consistency.
+BuildRequires:
perl(namespace::clean)
Ok.
TODO: Build-require `perl(strict)' (Makefile.PL:2).
+BuildRequires: perl(strict)
Ok.
TODO: Build-require `perl(warnings)' (Makefile.PL:3).
+BuildRequires: perl(warnings)
Ok.
FIX: (Build-)require Data::Perl::* modules instead of Data::Perl
itself
(Data::Perl::Role::Collection::Array, Data::Perl::Role::Collection::Hash,
Data::Perl::Role::String, Data::Perl::Role::Number, Data::Perl::Role::Bool).
These are loaded via Moo's `with' keyword.
+BuildRequires:
perl(Data::Perl::Role::Bool)
+BuildRequires: perl(Data::Perl::Role::Code)
+BuildRequires: perl(Data::Perl::Role::Collection::Array)
+BuildRequires: perl(Data::Perl::Role::Collection::Hash)
+BuildRequires: perl(Data::Perl::Role::Counter)
+BuildRequires: perl(Data::Perl::Role::Number)
+BuildRequires: perl(Data::Perl::Role::String)
TODO: Do not build-require perl(Data::Perl::Role::Code) and
perl(Data::Perl::Role::Counter). These are not used.
TODO: Constrain these dependencies with `>= 0.002006' as was used at
perl(Data::Perl).
TODO: Do not build-require `perl(Data::Perl). It's not used.
FIX: Do not Build-require `perl(Role::Tiny)'. It's not used
anywhere. It's loaded
via Role::Tiny::With.
-BuildRequires: perl(Role::Tiny)
Ok.
FIX: Build-require `perl(Moo::Role)' (t/handlesvia_in_role.t:7).
+BuildRequires: perl(Moo::Role)
Ok.
TODO: Build-require `perl(overload)'
(t/from-moose/trait_array.t:98).
+BuildRequires: perl(overload)
Ok.
FIX: Correct `atttribute' spelling.
$ rpmlint
perl-MooX-HandlesVia.spec
../SRPMS/perl-MooX-HandlesVia-0.001005-2.fc21.src.rpm
../RPMS/noarch/perl-MooX-HandlesVia-0.001005-2.fc21.noarch.rpm
perl-MooX-HandlesVia.src: W: spelling-error %description -l en_US proxying ->
propping
perl-MooX-HandlesVia.src: W: spelling-error %description -l en_US atttribute ->
attribute, attributive, attribution
perl-MooX-HandlesVia.noarch: W: spelling-error %description -l en_US proxying
-> propping
perl-MooX-HandlesVia.noarch: W: spelling-error %description -l en_US atttribute
-> attribute, attributive, attribution
2 packages and 1 specfiles checked; 0 errors, 4 warnings.
Not address.
TODO: Please replace `atttribute' with `attribute' in the description.
FIX: Require Data::Perl::* modules instead of Data::Perl itself
(Data::Perl::Role::Collection::Array, Data::Perl::Role::Collection::Hash,
Data::Perl::Role::String, Data::Perl::Role::Number, Data::Perl::Role::Bool).
The Data::Perl is not used by this RPM package directly. It's used by those
modules indirectly. Those modules are loaded by Moo's keyword `with' which is
not
yet recognized by RPM dependency generator.
$ rpm -q --requires -p
../RPMS/noarch/perl-MooX-HandlesVia-0.001005-2.fc21.noarch.rpm | sort | uniq -c
1 perl(Class::Method::Modifiers)
1 perl(Data::Perl) >= 0.002006
1 perl(:MODULE_COMPAT_5.18.2)
1 perl(Module::Runtime)
1 perl(Moo) >= 1.003000
1 perl(Role::Tiny::With)
1 perl(strictures) >= 1
1 rpmlib(CompressedFileNames) <= 3.0.4-1
1 rpmlib(FileDigests) <= 4.6.0-1
1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
1 rpmlib(PayloadIsXz) <= 5.2-1
TODO: Please mirror the Data::Perl::* build-requires into requires. This is how
Perl modules dependencies have to be specified in the RPM.
Package builds in F21
(
http://koji.fedoraproject.org/koji/taskinfo?taskID=6675583). Ok.
Please consider fixing the `TODO' items before building this package.
Resolution: Package APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component