Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=701028
--- Comment #3 from Remi Collet <fedora(a)famillecollet.com> 2011-05-15 11:51:37 EDT
---
- spec file name must be fixed
http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Spec_file_name
- use install with -p option to preserve file timestamp
- sed are unreadable, use special substitution instead
- should preserve timestamp on upstream as much as possible
per exemple :
# UNIX format conversion
for fic in ChangeLog README COPYING; do
touch -r $fic .timestamp
sed -i -e 's/\f//;s/\r//' $fic
touch -r .timestamp $fic
done
- remove rm -rf %{buildroot} in %prep
$ rpmlint -I rpm-buildroot-usage
rpm-buildroot-usage:
$RPM_BUILD_ROOT should not be touched during %build or %prep stage, as it may
break short circuit builds.
-add rm -rf %{buildroot} in %install
- issue with license file
$ rpmlint -I incorrect-fsf-address
incorrect-fsf-address:
The Free Software Foundation address in this file seems to be outdated or
misspelled. Ask upstream to update the address, or if this is a license file,
possibly the entire file with a new copy available from the FSF.
You should, at least, open an upstream bug (don't know if he's alive, as this
1.0b1 seems quite old... 2005)
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.