https://bugzilla.redhat.com/show_bug.cgi?id=1154750
Bug ID: 1154750 Summary: Review Request: mozilla-privacy-badger - Protects your privacy by blocking spying ads and invisible trackers Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: dominik@greysector.net QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://rathann.fedorapeople.org/review/mozilla-privacy-badger/mozilla-priva... SRPM URL: https://rathann.fedorapeople.org/review/mozilla-privacy-badger/mozilla-priva... Description: Privacy Badger is a browser add-on that stops advertisers and other third-party trackers from secretly tracking where you go and what pages you look at on the web. If an advertiser seems to be tracking you across multiple websites without your permission, Privacy Badger automatically blocks that advertiser from loading any more content in your browser. To the advertiser, it's like you suddenly disappeared.
Fedora Account System Username: rathann
https://bugzilla.redhat.com/show_bug.cgi?id=1154750
Andy Lutomirski luto@mit.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |luto@mit.edu Assignee|nobody@fedoraproject.org |luto@mit.edu Flags| |fedora-review?
--- Comment #1 from Andy Lutomirski luto@mit.edu --- The source URL should probably be something like:
https://addons.mozilla.org/firefox/downloads/file/261868/privacy_badger-%%7B...
The draft specs seem to suggest that the xpi should be unpacked. Does this extension work if it's unpacked?
The FSF seems to thing that CC-BY is incompatible with the GPL [1].
[1] https://www.gnu.org/licenses/license-list.html#ccby
https://bugzilla.redhat.com/show_bug.cgi?id=1154750
Andy Lutomirski luto@mit.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED
https://bugzilla.redhat.com/show_bug.cgi?id=1154750
--- Comment #2 from Dominik 'Rathann' Mierzejewski dominik@greysector.net --- Spec URL: https://rathann.fedorapeople.org/review/mozilla-privacy-badger/mozilla-priva... SRPM URL: https://rathann.fedorapeople.org/review/mozilla-privacy-badger/mozilla-priva...
* Mon Jan 12 2015 Dominik 'Rathann' Mierzejewski rpm@greysector.net - 0.2.4-1 - update to 0.2.4
* Mon Dec 15 2014 Dominik 'Rathann' Mierzejewski rpm@greysector.net - 0.2.3-1 - update to 0.2.3 - switch source URL to EFF site - minimum firefox version is 26 - simplify and improve install commands - fix install path for seamonkey
I've identified a number of bundled libraries and I'll work on unbundling them next. I'll try replacing the bundled sha1 code with some other implementation under an acceptable licence.
The extension seems to work just fine when unpacked.
https://bugzilla.redhat.com/show_bug.cgi?id=1154750
Dominik 'Rathann' Mierzejewski dominik@greysector.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |858027
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=858027 [Bug 858027] Review Request: jquery-ui - JavaScript library of interface components based on jQuery
https://bugzilla.redhat.com/show_bug.cgi?id=1154750
Dominik 'Rathann' Mierzejewski dominik@greysector.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1221209
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1221209 [Bug 1221209] Review Request: addon-sdk - SDK to create Firefox add-ons using standard Web technologies
https://bugzilla.redhat.com/show_bug.cgi?id=1154750
--- Comment #3 from Dominik 'Rathann' Mierzejewski dominik@greysector.net --- Spec URL: https://rathann.fedorapeople.org/review/mozilla-privacy-badger/mozilla-priva... SRPM URL: https://rathann.fedorapeople.org/review/mozilla-privacy-badger/mozilla-priva...
* Wed May 13 2015 Dominik 'Rathann' Mierzejewski rpm@greysector.net - 0.2.6.1-1.d219f00 - update to latest git master - build from github source - unbundle jquery - drop obsolete patch
TODO: unbundle other bundled JS libs.
https://bugzilla.redhat.com/show_bug.cgi?id=1154750
Dominik 'Rathann' Mierzejewski dominik@greysector.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1078359 (js-reviews)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1078359 [Bug 1078359] JavaScript review tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1154750
Dominik 'Rathann' Mierzejewski dominik@greysector.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks|1078359 (js-reviews) |
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1078359 [Bug 1078359] JavaScript review tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1154750
Andy Lutomirski luto@mit.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW Assignee|luto@mit.edu |nobody@fedoraproject.org Flags|fedora-review? |
--- Comment #4 from Andy Lutomirski luto@mit.edu --- I'm dropping this, since I'm barely qualified to reivew JS. Note to whomever takes over: the license needs careful checking.
https://bugzilla.redhat.com/show_bug.cgi?id=1154750
Vít Ondruch vondruch@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |vondruch@redhat.com
--- Comment #5 from Vít Ondruch vondruch@redhat.com --- /usr/share/addons-sdk/.test_tmp should be probably excluded from the package.
https://bugzilla.redhat.com/show_bug.cgi?id=1154750
--- Comment #6 from Vít Ondruch vondruch@redhat.com --- (In reply to Vít Ondruch from comment #5)
/usr/share/addons-sdk/.test_tmp should be probably excluded from the package.
Ups, this actually belongs to bug 1221209
https://bugzilla.redhat.com/show_bug.cgi?id=1154750
--- Comment #7 from Dominik 'Rathann' Mierzejewski dominik@greysector.net --- Spec URL: https://rathann.fedorapeople.org/review/mozilla-privacy-badger/mozilla-priva... SRPM URL: https://rathann.fedorapeople.org/review/mozilla-privacy-badger/mozilla-priva...
* Sun Aug 09 2015 Dominik 'Rathann' Mierzejewski rpm@greysector.net - 1.0.0-1 - update to 1.0.0 (git commit b086016)
https://bugzilla.redhat.com/show_bug.cgi?id=1154750 Bug 1154750 depends on bug 1221209, which changed state.
Bug 1221209 Summary: Review Request: addon-sdk - SDK to create Firefox add-ons using standard Web technologies https://bugzilla.redhat.com/show_bug.cgi?id=1221209
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |NOTABUG
https://bugzilla.redhat.com/show_bug.cgi?id=1154750
--- Comment #8 from Dominik 'Rathann' Mierzejewski dominik@greysector.net --- Spec URL: https://rathann.fedorapeople.org/review/mozilla-privacy-badger/mozilla-priva... SRPM URL: https://rathann.fedorapeople.org/review/mozilla-privacy-badger/mozilla-priva...
- update to 1.0.5 (signed, from addons.mozilla.org)
It works with FF43+ with signature checking enabled, but at the cost of having bundled jQuery and other stuff. Also, we can't build from source anymore, but that is another story, because we don't have jpm packaged anyway.
https://bugzilla.redhat.com/show_bug.cgi?id=1154750
--- Comment #9 from Dominik 'Rathann' Mierzejewski dominik@greysector.net --- Spec URL: https://rathann.fedorapeople.org/review/mozilla-privacy-badger/mozilla-priva... SRPM URL: https://rathann.fedorapeople.org/review/mozilla-privacy-badger/mozilla-priva...
- update to 1.0.6
https://bugzilla.redhat.com/show_bug.cgi?id=1154750
Stephen Gallagher sgallagh@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |182235 (FE-Legal)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=182235 [Bug 182235] Fedora Legal Tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1154750
Dominik 'Rathann' Mierzejewski dominik@greysector.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks|182235 (FE-Legal) |
--- Comment #10 from Dominik 'Rathann' Mierzejewski dominik@greysector.net --- No reason given for FE-Legal block, so lifting. Feel free to re-add with rationale.
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=182235 [Bug 182235] Fedora Legal Tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1154750
--- Comment #11 from Dominik 'Rathann' Mierzejewski dominik@greysector.net --- Spec URL: https://rathann.fedorapeople.org/review/mozilla-privacy-badger/mozilla-priva... SRPM URL: https://rathann.fedorapeople.org/review/mozilla-privacy-badger/mozilla-priva...
- update to 1.7.0 - drop CC-BY from License: (not sure how it got there)
https://bugzilla.redhat.com/show_bug.cgi?id=1154750
--- Comment #12 from Andy Lutomirski luto@kernel.org --- I assume the FE-Legal block was because an older version of this package had both CC-BY code and GPL code. I haven't checked whether the current version has that combination.
https://bugzilla.redhat.com/show_bug.cgi?id=1154750
--- Comment #13 from Dominik 'Rathann' Mierzejewski dominik@greysector.net --- (In reply to Andy Lutomirski from comment #12)
I assume the FE-Legal block was because an older version of this package had both CC-BY code and GPL code. I haven't checked whether the current version has that combination.
I don't see anything licensed with CC-BY in the current version.
Spec URL: https://rathann.fedorapeople.org/review/mozilla-privacy-badger/mozilla-priva... SRPM URL: https://rathann.fedorapeople.org/review/mozilla-privacy-badger/mozilla-priva...
* Wed Nov 02 2016 Dominik 'Rathann' Mierzejewski rpm@greysector.net - 1.8.1-1 - update to 1.8.1 - bump minimum firefox version for RHEL5
https://bugzilla.redhat.com/show_bug.cgi?id=1154750
--- Comment #14 from Dominik 'Rathann' Mierzejewski dominik@greysector.net --- Spec URL: https://rathann.fedorapeople.org/review/mozilla-privacy-badger/mozilla-priva... SRPM URL: https://rathann.fedorapeople.org/review/mozilla-privacy-badger/mozilla-priva...
* Tue Mar 21 2017 Dominik 'Rathann' Mierzejewski rpm@greysector.net - 2017.1.26.1-1 - update to 2017.1.26.1 - update source URL - update bundled components list - bump minimum firefox version for RHEL5
https://bugzilla.redhat.com/show_bug.cgi?id=1154750
--- Comment #15 from Dominik 'Rathann' Mierzejewski dominik@greysector.net --- Spec URL: https://rathann.fedorapeople.org/review/mozilla-privacy-badger/mozilla-priva... SRPM URL: https://rathann.fedorapeople.org/review/mozilla-privacy-badger/mozilla-priva...
* Sun Jul 02 2017 Dominik 'Rathann' Mierzejewski rpm@greysector.net - 2017.6.13.1-1 - update to 2017.6.13.1 - update source URL - update bundled components list - drop support for RHEL5
https://bugzilla.redhat.com/show_bug.cgi?id=1154750
--- Comment #16 from Dominik 'Rathann' Mierzejewski dominik@greysector.net --- Spec URL: https://rathann.fedorapeople.org/review/mozilla-privacy-badger/mozilla-priva... SRPM URL: https://rathann.fedorapeople.org/review/mozilla-privacy-badger/mozilla-priva...
* Wed Feb 21 2018 Dominik 'Rathann' Mierzejewski rpm@greysector.net - 2018.2.5-1 - update to 2018.2.5 - update bundled components list - drop SeaMonkey support
https://bugzilla.redhat.com/show_bug.cgi?id=1154750
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@gmail.com
--- Comment #17 from Robert-André Mauchin zebob.m@gmail.com --- - I can't find any BSD code in his package. Are you sure " and BSD" is necessary?
- You should own the install directory:
%files %license LICENSE %dir %{firefox_inst_dir} %{firefox_inst_dir}/%{ext_id}.xpi
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL (v3)", "MIT/X11 (BSD like) GPL (v3)", "Unknown or generated". 107 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/mozilla-privacy-badger /review-mozilla-privacy-badger/licensecheck.txt [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/mozilla/extensions/{ec8030f7-c20a-464f-9b0e-13a3a9e97384} [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: mozilla-privacy-badger-2018.2.5-1.fc29.noarch.rpm mozilla-privacy-badger-2018.2.5-1.fc29.src.rpm mozilla-privacy-badger.noarch: W: no-documentation mozilla-privacy-badger.src:32: W: unversioned-explicit-provides bundled(css-toggle-switch.css) mozilla-privacy-badger.src:38: W: unversioned-explicit-provides bundled(punycode) 2 packages and 0 specfiles checked; 0 errors, 3 warnings.
https://bugzilla.redhat.com/show_bug.cgi?id=1154750
--- Comment #18 from Dominik 'Rathann' Mierzejewski dominik@greysector.net --- (In reply to Robert-André Mauchin from comment #17)
- I can't find any BSD code in his package. Are you sure " and BSD" is
necessary?
- You should own the install directory:
%files %license LICENSE %dir %{firefox_inst_dir} %{firefox_inst_dir}/%{ext_id}.xpi
Thanks for the review!
Spec URL: https://rathann.fedorapeople.org/review/mozilla-privacy-badger/mozilla-priva... SRPM URL: https://rathann.fedorapeople.org/review/mozilla-privacy-badger/mozilla-priva...
* Fri Mar 09 2018 Dominik 'Rathann' Mierzejewski rpm@greysector.net - 2018.2.5-2 - drop BSD from license list (no BSD-licensed components anymore) - own firefox_inst_dir
https://bugzilla.redhat.com/show_bug.cgi?id=1154750
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Flags| |fedora-review+
--- Comment #19 from Robert-André Mauchin zebob.m@gmail.com --- Package is approved.
https://bugzilla.redhat.com/show_bug.cgi?id=1154750
--- Comment #20 from Gwyn Ciesla limburgher@gmail.com --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/mozilla-privacy-badger
https://bugzilla.redhat.com/show_bug.cgi?id=1154750
Dominik 'Rathann' Mierzejewski dominik@greysector.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |CURRENTRELEASE Last Closed| |2018-08-07 05:45:58
--- Comment #21 from Dominik 'Rathann' Mierzejewski dominik@greysector.net --- Not sure why I missed this, but this was built for F27+.
package-review@lists.fedoraproject.org