https://bugzilla.redhat.com/show_bug.cgi?id=2093465
Bug ID: 2093465 Summary: golang-github-mbrt-gmailctl - Declarative configuration for Gmail filters Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: mark.e.fuller@gmx.de QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://fuller.fedorapeople.org/golang-github-mbrt-gmailctl.spec SRPM URL: https://fuller.fedorapeople.org/golang-github-mbrt-gmailctl-0.10.4-1.fc36.sr... Description: Declarative configuration for Gmail filters Fedora Account System Username: fuller
https://bugzilla.redhat.com/show_bug.cgi?id=2093465
Mark E. Fuller mark.e.fuller@gmx.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|golang-github-mbrt-gmailctl |Review Request: |- Declarative configuration |golang-github-mbrt-gmailctl |for Gmail filters |- Declarative configuration | |for Gmail filters
https://bugzilla.redhat.com/show_bug.cgi?id=2093465
Mikel Olasagasti Uranga mikel@olasagasti.info changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |mikel@olasagasti.info Status|NEW |ASSIGNED CC| |mikel@olasagasti.info
https://bugzilla.redhat.com/show_bug.cgi?id=2093465
--- Comment #1 from Mikel Olasagasti Uranga mikel@olasagasti.info --- Spec is correct, but before approving it two questions:
- Wouldn't it better to call package directly `gmailctl` rather than `golang-github-mbrt-gmailctl`?
If you want so, define the following global:
%global goname gmailctl
Rename the spec to gmailctl.spec and change this BZ's title.
You can check `doctl` as an example.
- You defined all the BuildRequires rather than using `%go_generate_buildrequires`. In some of your other specs you're using that macro, maybe you want to change this spec to use dynamic BuildRequires?
https://bugzilla.redhat.com/show_bug.cgi?id=2093465
--- Comment #2 from Mark E. Fuller fuller@fedoraproject.org --- Thanks for the suggestions and for the review
Re: BuildRequires, I had thought when I made up the spec that I was getting an error about a name mismatch when generating the requirements automatically - that isn't happening anymore.
Updated files: Spec URL: https://fuller.fedorapeople.org/gmailctl.spec SRPM URL: https://fuller.fedorapeople.org/gmailctl-0.10.4-1.fc36.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=2093465
Mark E. Fuller fuller@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: |Review Request: gmailctl - |golang-github-mbrt-gmailctl |Declarative configuration |- Declarative configuration |for Gmail filters |for Gmail filters |
https://bugzilla.redhat.com/show_bug.cgi?id=2093465
Mikel Olasagasti Uranga mikel@olasagasti.info changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+
--- Comment #3 from Mikel Olasagasti Uranga mikel@olasagasti.info --- go2rpm package, fedora-review is correct:
- The specfile is sane - License is correct - Builds successfully in mock - No rpmlint errors - %check section passes - The latest version is packaged - The package complies with the Packaging Guidelines
Package approved! On import, don't forget to do the following:
- Add package to release-monitoring.org - Add package to Koschei. - Give go-sig privileges on package - Close the review bug by referencing it in the rpm changelog and/or the Bodhi ticket. (rhbz#BUG_ID)
Thanks!
https://bugzilla.redhat.com/show_bug.cgi?id=2093465
--- Comment #4 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/gmailctl
https://bugzilla.redhat.com/show_bug.cgi?id=2093465
Mark E. Fuller mark.e.fuller@gmx.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST
https://bugzilla.redhat.com/show_bug.cgi?id=2093465
Mark E. Fuller mark.e.fuller@gmx.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |CURRENTRELEASE Status|POST |CLOSED Last Closed| |2022-06-16 16:44:07
package-review@lists.fedoraproject.org