[Bug 481528] New: Review Request: perl-DBIx-Safe - Safer access to your database through a DBI database handle - package-review

List overview All Threads
Download

newer

[Bug 481528] New: Review Request: perl-DBIx-Safe - Safer access to your database through a DBI database handle

older

[Bug 515053] New: Review Request:...

[Bug 519071] New: Review Request:...

Red Hat Bugzilla

26 Jan 2009 26 Jan '09

1:47 a.m.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

Summary: Review Request: perl-DBIx-Safe - Safer access to your database through a DBI database handle

https://bugzilla.redhat.com/show_bug.cgi?id=481528

Summary: Review Request: perl-DBIx-Safe - Safer access to your database through a DBI database handle Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: itamar@ispbrasil.com.br QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora

Spec URL: http://www.ispbrasil.com.br/perl-DBIx-Safe/perl-DBIx-Safe.spec SRPM URL: http://www.ispbrasil.com.br/perl-DBIx-Safe/perl-DBIx-Safe-1.2.5-1.fc9.src.rp...

Description: The purpose of this module is to give controlled, limited access to an application, rather than simply passing it a raw database handle through DBI. DBIx::Safe acts as a wrapper to the database, by only allowing through the commands you tell it to. It filters all things related to the database handle - methods and attributes.

koji scratch build

http://koji.fedoraproject.org/koji/taskinfo?taskID=1081910

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Show replies by date

Red Hat Bugzilla

26 Jan 26 Jan

1:48 a.m.

New subject: [Bug 481528] Review Request: perl-DBIx-Safe - Safer access to your database through a DBI database handle

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=481528

Itamar Reis Peixoto itamar@ispbrasil.com.br changed:

What |Removed |Added ---------------------------------------------------------------------------- Alias| |perl-DBIx-Safe

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

1:48 a.m.

New subject: [Bug 481528] Review Request: perl-DBIx-Safe - Safer access to your database through a DBI database handle

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=481528

Itamar Reis Peixoto itamar@ispbrasil.com.br changed:

What |Removed |Added ---------------------------------------------------------------------------- Blocks| |481527

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

10:53 a.m.

New subject: [Bug 481528] Review Request: perl-DBIx-Safe - Safer access to your database through a DBI database handle

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=481528

Parag AN(पराग) panemade@gmail.com changed:

--- Comment #1 from Parag AN(पराग) panemade@gmail.com 2009-01-26 05:53:16 EDT --- Review: + package builds in mock (rawhide i386). koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1081910 + rpmlint is silent for SRPM and for RPM. + source files match upstream with different url than given in spec. ca5abd5fec19da9d51e6312f6707c534 DBIx-Safe-1.2.5.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test outputs Nothing. + Package perl-DBIx-Safe-1.2.5-1.fc11 -> Provides: perl(DBIx::Safe) = 1.2.5 Requires: perl >= 0:5.008003 perl(DBI) >= 1.42 perl(IO::Handle) perl(strict) perl(utf8) perl(warnings)

Suggestions: 1) remove unnecessary BR from spec. BuildRequires: perl >= 1:5.6.1 2)Source URL not working. Working URL is http://search.cpan.org/CPAN/authors/id/T/TU/TURNSTEP/DBIx-Safe-1.2.5.tar.gz But looks like URL have " ** UNAUTHORIZED RELEASE **" written. Not sure what that means. 3) Good if you add BRs that will remove warnings from build.log Warning: prerequisite DBD::Pg 1.49 not found. Warning: prerequisite DBI 1.49 not found. Warning: prerequisite Test::More 0.61 not found. Warning: prerequisite Test::Simple 0.3 not found. 4) License is BSD.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

11:04 a.m.

New subject: [Bug 481528] Review Request: perl-DBIx-Safe - Safer access to your database through a DBI database handle

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=481528

--- Comment #2 from Parag AN(पराग) panemade@gmail.com 2009-01-26 06:04:08 EDT --- also, Change Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) to Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

27 Jan 27 Jan

3:29 p.m.

New subject: [Bug 481528] Review Request: perl-DBIx-Safe - Safer access to your database through a DBI database handle

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=481528

--- Comment #3 from Itamar Reis Peixoto itamar@ispbrasil.com.br 2009-01-27 10:29:15 EDT --- please look now

http://ispbrasil.com.br/perl-DBIx-Safe/perl-DBIx-Safe.spec http://ispbrasil.com.br/perl-DBIx-Safe/perl-DBIx-Safe-1.2.5-2.fc10.src.rpm

http://koji.fedoraproject.org/koji/taskinfo?taskID=108604

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

28 Jan 28 Jan

9 a.m.

New subject: [Bug 481528] Review Request: perl-DBIx-Safe - Safer access to your database through a DBI database handle

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=481528

Parag AN(पराग) panemade@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+

--- Comment #4 from Parag AN(पराग) panemade@gmail.com 2009-01-28 04:00:49 EDT --- koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1088064

1)rpmlint outputs only perl-DBIx-Safe.src: W: mixed-use-of-spaces-and-tabs (spaces: line 2, tab: line 1) ==>Can be fixed using "sed -i -e 's|\t| |g' perl-DBIx-Safe.spec"

2) Also, add following at the end of the %install section %{_fixperms} %{buildroot}/*

Make sure you will fix above 2 issues first before committing to cvs.

APPROVED.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

12:27 p.m.

New subject: [Bug 481528] Review Request: perl-DBIx-Safe - Safer access to your database through a DBI database handle

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=481528

--- Comment #5 from Itamar Reis Peixoto itamar@ispbrasil.com.br 2009-01-28 07:27:05 EDT --- fixed.

http://ispbrasil.com.br/perl-DBIx-Safe/perl-DBIx-Safe.spec http://ispbrasil.com.br/perl-DBIx-Safe/perl-DBIx-Safe-1.2.5-3.fc10.src.rpm

koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1088470

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

12:29 p.m.

New subject: [Bug 481528] Review Request: perl-DBIx-Safe - Safer access to your database through a DBI database handle

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=481528

Itamar Reis Peixoto itamar@ispbrasil.com.br changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?

--- Comment #6 from Itamar Reis Peixoto itamar@ispbrasil.com.br 2009-01-28 07:29:32 EDT --- package approved in Comment #4

New Package CVS Request ======================= Package Name: perl-DBIx-Safe Short Description: Safer access to your database through a DBI database handle Owners: itamarjp Branches: F-10 F-9 InitialCC:

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

2:20 p.m.

New subject: [Bug 481528] Review Request: perl-DBIx-Safe - Safer access to your database through a DBI database handle

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=481528

Ralf Corsepius rc040203@freenet.de changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |rc040203@freenet.de

--- Comment #7 from Ralf Corsepius rc040203@freenet.de 2009-01-28 09:20:43 EDT --- Feel adviced to add perl-sig to InitialCC, like most perl package maintainer do.

Activate the test suite. A test suite being noisy doesn't justify deactivating it.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

3:12 p.m.

New subject: [Bug 481528] Review Request: perl-DBIx-Safe - Safer access to your database through a DBI database handle

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=481528

--- Comment #8 from Itamar Reis Peixoto itamar@ispbrasil.com.br 2009-01-28 10:12:57 EDT --- (In reply to comment #7)

done.

http://ispbrasil.com.br/perl-DBIx-Safe/perl-DBIx-Safe.spec http://ispbrasil.com.br/perl-DBIx-Safe/perl-DBIx-Safe-1.2.5-4.fc10.src.rpm

----------------------------------------------------------------------------

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

29 Jan 29 Jan

12:21 a.m.

New subject: [Bug 481528] Review Request: perl-DBIx-Safe - Safer access to your database through a DBI database handle

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=481528

Kevin Fenzi kevin@tummy.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+

--- Comment #9 from Kevin Fenzi kevin@tummy.com 2009-01-28 19:21:28 EDT --- cvs done.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

11 p.m.

New subject: [Bug 481528] Review Request: perl-DBIx-Safe - Safer access to your database through a DBI database handle

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=481528

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |ON_QA

--- Comment #10 from Fedora Update System updates@fedoraproject.org 2009-01-29 18:00:48 EDT --- perl-DBIx-Safe-1.2.5-4.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update perl-DBIx-Safe'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-1072

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

5 May 5 May

5:11 a.m.

New subject: [Bug 481528] Review Request: perl-DBIx-Safe - Safer access to your database through a DBI database handle

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=481528

--- Comment #11 from Parag AN(पराग) panemade@gmail.com 2009-05-05 00:11:33 EDT --- can we close this review?

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

11:19 a.m.

New subject: [Bug 481528] Review Request: perl-DBIx-Safe - Safer access to your database through a DBI database handle

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=481528

Itamar Reis Peixoto itamar@ispbrasil.com.br changed:

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

14 Nov 14 Nov

11:25 p.m.

New subject: [Bug 481528] Review Request: perl-DBIx-Safe - Safer access to your database through a DBI database handle

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=481528

Itamar Reis Peixoto itamar@ispbrasil.com.br changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs+ |fedora-cvs?

--- Comment #12 from Itamar Reis Peixoto itamar@ispbrasil.com.br 2009-11-14 18:25:11 EDT --- Package Change Request ====================== Package Name: perl-DBIx-Safe New Branches: EL-5 Owners: itamarjp InitialCC: perl-sig

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

16 Nov 16 Nov

5:40 p.m.

New subject: [Bug 481528] Review Request: perl-DBIx-Safe - Safer access to your database through a DBI database handle

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=481528

Jason Tibbitts tibbs@math.uh.edu changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+

--- Comment #13 from Jason Tibbitts tibbs@math.uh.edu 2009-11-16 12:40:58 EDT --- CVS done.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

6:57 p.m.

New subject: [Bug 481528] Review Request: perl-DBIx-Safe - Safer access to your database through a DBI database handle

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=481528

--- Comment #14 from Fedora Update System updates@fedoraproject.org 2009-11-16 13:57:51 EDT --- perl-DBIx-Safe-1.2.5-6.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/perl-DBIx-Safe-1.2.5-6.el5

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

7 Dec 7 Dec

6:28 a.m.

New subject: [Bug 481528] Review Request: perl-DBIx-Safe - Safer access to your database through a DBI database handle

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=481528

--- Comment #15 from Fedora Update System updates@fedoraproject.org 2009-12-07 01:28:46 EDT --- perl-DBIx-Safe-1.2.5-6.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

6:28 a.m.

New subject: [Bug 481528] Review Request: perl-DBIx-Safe - Safer access to your database through a DBI database handle

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=481528

Fedora Update System updates@fedoraproject.org changed:

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

5525

Age (days ago)

5840

Last active (days ago)

package-review@lists.fedoraproject.org

19 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla