https://bugzilla.redhat.com/show_bug.cgi?id=2315523

Gris Ge fge@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Comment|0 |updated

--- Comment #0 has been edited ---

Spec URL: https://fedorapeople.org/~cathay4t/new_rpms/rust-wl-nl80211.spec SRPM URL: https://fedorapeople.org/~cathay4t/new_rpms/rust-wl-nl80211-0.2.0-1.fc42.src... Description: The new version 1.2.20 of existing nispor rpm introduced new dependency on rust crate -- wl-nl80211. Hence we need introduce its crate into fedora. This package is pure rust crate devel packages dedicate for linux netlink nl80211(wifi) communication. Fedora Account System Username: cathay4t

https://bugzilla.redhat.com/show_bug.cgi?id=2315523

Cristian Le fedora@lecris.me changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST Flags| |fedora-review+ CC| |fedora@lecris.me Assignee|nobody@fedoraproject.org |fedora@lecris.me

--- Comment #3 from Cristian Le fedora@lecris.me --- LGTM. This is a straightforward rust2rpm, and all seems fine.

My additional suggestion is to add a blank `rust2rpm.toml` just to indicate that you've used all default values. Also could you mark the bugzilla bug that requires this package that is referenced in:

The new version 1.2.20 of existing nispor rpm introduced new dependency on rust crate -- wl-nl80211. Hence we need introduce its crate into fedora

(Using Fabio's review template)

===

Package was generated with rust2rpm, simplifying the review.

✅❌❓🫤

✅ package contains only permissible content ✅ package builds and installs without errors on rawhide 🫤 test suite is run and all unit tests pass (Upstream doesn't have any tests, other than examples compiling I guess) ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license files are included with %license in %files ✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version (*NOT* pre-release) filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer)

https://bugzilla.redhat.com/show_bug.cgi?id=2315523

Gris Ge fge@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |RAWHIDE Fixed In Version| |rust-wl-nl80211-0.2.0-1.fc4 | |2 Status|RELEASE_PENDING |CLOSED Last Closed| |2024-10-09 13:28:21

https://bugzilla.redhat.com/show_bug.cgi?id=2315523

--- Comment #6 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-7745cf7dc7 (rust-wl-nl80211-0.2.0-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2024-7745cf7dc7